alexrkass / aframe-no-click-look-controls Goto Github PK

hi, any idea what causes this one?
thnx

Any way to get this down to a reasonable file size? The minified dist is over 700k (almost as big as aframe min package). Doesn't seem reasonable for someone who just wants to make an a-sky that uses mousemove instead of drag

Have a look: https://github.com/subsumo/aframe-no-click-look-controls

I've included the example files as well....

J

adding no-click-look-controls to the camera entity causes:
a-scene.js:301 Uncaught TypeError: component.tick is not a function(…)

this component only work with minimal scenes.

allow asymmetrical yaw and pitch values rather than forcing symmetrical distances from original camera position

now, the [aframe-core] has been replaced by [aframe],
and though i changed the require path,it still failed.
maybe something changed?

First off, nice component 😄 It might be nice to use the Pointer Lock API (perhaps let people opt-in through some property on the attribute value).

There aren't many but there are a few benefits I can think of: you don't have to do as much math yourself, the user can enable/disable the mousemove-based look controls (aka Pointer Lock) by pressing Escape (which is useful if the user wants to click on things outside or on top of the scene/canvas - see this example of Pointer Lock), and the cursor can be past the boundary of the browser or screen and the scene can still be moved.

Drawbacks? There is a permission prompt that appears when you engage Pointer Lock - but in Chrome you don't have to agree to it; it just shows up (Firefox will soon be changing its permissions treatment in a similar way - also like the Fullscreen API permissions are handled). Anyway, it may be worth looking into using this API. Totally up to you of course - just thought I'd mention it.