alexkuz / eslint-plugin-jinja Goto Github PK

Thanks for this library!

I tried using this with eslint 4.2.1 with this config:

{
    "env": {
        "browser": true,
        "commonjs": true
    },
    "extends": [
        "eslint:recommended"
    ],
    "plugins": [
        "eslint-plugin-jinja"
    ]
}

Eslint does not pick up the preprocessor because this line is assuming CommonJS exports. If I modify lib/index.js to export the preprocessors, then it is picked up.

Am I missing something? Happy to submit a PR with the change.

Trying to install normally gives

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^8.5.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^0.23.0 || ^1.0.0 || ^2.0.0" from [email protected]
npm ERR! node_modules/eslint-plugin-jinja2
npm ERR!   dev eslint-plugin-jinja2@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

And trying to install with --force - while it installs - just doesn't work.

Any chance that we can add ^3.0.0 to

Version 3 of eslint was released back in July and many other plugin dependencies have since moved on to that version, which makes it difficult to use eslint-plugin-jinja in conjunction with anything else at this stage.