alexeckermann / ckeditor5-emptyness Goto Github PK

Whilst the origin of the plugin was light hearted, quickly put together, and intentionally misspelt; it may be time to change the name going forwards. Looking towards production usage and adoption amongst the community.

Options:

1. ckeditor5-isempty being the most unambiguous. Only slight hitch being the plugin class having to be titlecase, Isempty, and looking weird.
2. ckeditor5-emptiness being the correct spelling. The plugin class then slightly altered to Emptiness.

An abrupt change will break builds. Hopefully, there can be a way to announce and ease this change in so that the inevitable build errors are descriptive to only need a few seconds worth of adjustments.

v0.2.0 will also amend some README language. To keep in mind that English slang and witticisms may not be helpful for developers where English is not their primary language.

Hello,

I'm trying to use the plugin with Angular. I'm having hard time to achieve that. All I need is to use it with ClassicEditor.

I added it as a dependency referancing it this way

git+https://github.com/alexeckermann/ckeditor5-emptyness.git

then I'm facing

Module not found: Error: Can't resolve '@ckeditor/ckeditor5-ui/src/template' in '/sandbox/ckeditor/node_modules/ckeditor5-emptyness/src'

I'm ready to create a PR for it once I could make it run :)

Hi, I've created a dependency free version, to be used with a compiled version, e.g. @ckeditor/ckeditor5-build-balloon via editorConfig.extraPlugins = [Emptyness]; . Maybe this helps in any way...

Gist: https://gist.github.com/Basster/bc2145f0a0d711870e1c023a1cb7825a

editor.ui.view is not directly extendable as an editor may not define its template in that view alone. An EditorUIView subclass may be a container which references several distinct child views which may or may not be structurally contained within this view in the DOM, or if the view has a DOM element at all. This was a misunderstanding based upon an incorrect test environment.

The ClassicTestEditor initialises the editor differently to a non-test ClassicEditor, rendering before its supposed to. Moreover, the structure of this test editor lead to a misunderstand of what a typical editor structure is and what view is available to have its template extended. This issue is being resolved in ckeditor5-core#137.

However, the plugin must be more resilient to handle the very rare case where a new or updated editor class does not have a known view to extend.

Hey! I'm using this library to add some placeholder text my empty editor instance, and mostly it is working great.

A co-worker of mine did notice an issue, however, where the editor is still marked as empty in a few cases where it should not be, particularly because the editor UI starts to show UI indicating that the user has made some input, but because the .ck-editor__is-empty class is still on the editor element my css ::before placeholder still shows up.

This seems to be happening if you click the blockquote or list options on an empty editor. Here's a screenshot of the result:

I'm using a custom build of ckeditor5 based on the classic build. The code is open source, so if you want to look at it it's here: https://github.com/mitodl/ckeditor-custom-build

Let me know if you need any more info!

Hello, I think this project would benefit from publishing to npm repository which would make it way easier to use.

In any case, thanks for this project!

Hi, this plugin seems not working in DecoupledEditor, here's the error message:

TypeError: Cannot read property '_isRendered' of undefined
    at Function.extend (ckeditor.js_+_957_modules:62303)
    at decouplededitoruiview_DecoupledEditorUIView.extendTemplate (ckeditor.js_+_957_modules:64124)
    at emptyness_Emptyness.init (ckeditor.js_+_957_modules:91400)

Could you provide some information to fix it.
Thanks in advance!

This plugin needs tests -- simple as they may be.

Primarily, this will help with identifying API changes in CK5 which may break the functionality.