alexdm0 / keycharm Goto Github PK

We get the following waning in an Angular project using keychartm (for vis-timeline):

WARNING in node_modules/vis-timeline/esnext/esm/vis-timeline-graph2d.js depends on 'keycharm'.
CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

It would be helpfull to also export a ESM module.
I'll try to look into this issue within the next weeks, but if somebody wants to help, please feel free to do so ;-)

Greetings,

I was wondering if there are any plans to release TypeScript definition files.
I am working on a project that exclusively uses TypeScript and keycharm was pulled in as a dependency of one of my dependencies. This is causing my TypeScript compiler to be a little bit complainy about keycharm not having any typings.

While it's trivial to work around my issue, it might actually also be interesting to just add TypeScript definitions to this project. If you are short on time, I can give it a shot over the course of the next weeks and open a PR afterwards.

Let me know your thoughts and plans on this subject matter.

Kind regards,
M.

Hi Alex,

keycharm is great and very easy to use, thanks! Just wanted to ask whether keybindings are removed automatically if bound to an element (not the window)? I expect this to be the case but the docs mention a destructor...

-Felix