Code Monkey home page Code Monkey logo

react-native-expanding-circle-transition's Issues

Evaluating PropTypes.string is undefined

Hi,

This library is working on an older version of react. So proptypes comes out to be undefined which has been deprecated from v16. Hence I guess it need to update to the latest version of react and also use prop-types library for defining PropTypes. Also there is an existing pull request for this issue, you can merge that to solve this error

TIA

Confine to view instead of modal

Nice component! I am planning to use it in my current project.

At the moment the transition is forced on the whole screen, I think the component would be more practical if it was confined only to it's parent view. For example: when you have a tab bar at the bottom, you don't want the animation to go over it. Furthermore, this enable animations that go beyond transitioning from one screen to screen, a box with some words in it for example. I believe the modification here is simple, using a view instead of a modal (the view can be hidden as well).

Another point, why not add a prop to feed the modal (or it's replacement) with some content (children), and a flag to keep it visible after the animation, say keepVisible, this way the component can be used for prompt actions or messages, extending its capabilities even more.

I actually worked on the code a little, but then I stopped and though that I should share here first. Thanks for the great work.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.