alexbeltran / gobacnet Goto Github PK

Right now the package is using global loggrus instead of keeping a local instance. This has caused issues when trying to use the loggrus package from outside the package. This was observed in baccli.

The types subpackage is nice to handle internally but once other projects start to use it, a flatter structure would be nice so all the end user of the library will have to do is import gobacnet instead of import gobacnet and import gobacnet/types.

This flattening is less important for parts that are not exposed such as the tsm and utsm.

read mutil error!
read property is ok. help

time="2022-08-29T12:01:32+08:00" level=debug msg="Broadcast Address: 192.168.32.255"
time="2022-08-29T12:01:32+08:00" level=debug msg="Local Address: 192.168.32.199/24"
time="2022-08-29T12:01:32+08:00" level=debug msg="Port: bac0"
time="2022-08-29T12:01:32+08:00" level=debug msg="Received IAm Message"
time="2022-08-29T12:01:34+08:00" level=debug msg="Received Complex Ack"
time="2022-08-29T12:01:34+08:00" level=debug msg="WEIRD PACKET: Class 2 Code 32: [48 1 14 12 0 0 0 7 30 41 70 94 145 2 145 32 95 41 85 78 68 193 199 32 164 79 31]"
time="2022-08-29T12:01:34+08:00" level=debug msg="Received Complex Ack"
time="2022-08-29T12:01:34+08:00" level=debug msg="WEIRD PACKET: Class 2 Code 32: [48 1 14 12 0 0 0 7 30 41 70 94 145 2 145 32 95 41 85 78 68 193 199 32 164 79 31]"
time="2022-08-29T12:01:34+08:00" level=error msg="read udp [::]:47808: use of closed network connection"

Using a large size such as:
./baccli discover -s 50000

causes a deadlock

At the moment, we query devices as fast as possible. This may not be the best for devices since they are typically fairly slow. I think an option to have a rate limiter based on ever bacnet device address may help with congestion.

This will help with readability. :)

github.com/alexbeltran/gobacnet/net

Keep getting the error:
←[31mFATA←[0m[0000] route ip+net: no such network interface

Add Travis CLI

This is due to skipping an enumeration of what the string type is.

@alexbeltran hi, i tried whoIs command in my windows pc , its is working
but when i try to run readprop command im not getting the output
C:\Users\DELL\go\src\github.com\alexbeltran\gobacnet>baccli whoIs -i "Npcap Loopback Adapter" -p 47808
{
"ID": {
"Type": 8,
"Instance": 1294418
},
"MaxApdu": 1464,
"Segmentation": 0,
"Vendor": 260,
"Addr": {
"Net": 0,
"Len": 0,
"MacLen": 6,
"Mac": "qf7CI9KO",
"Adr": null
},
"Objects": {}
}
]
Failed to write to log, write gobacnet.log: file already closed
for the above command im getting the output like this

can you tell me how to run readprop commmand below i mentioned how did i tried

C:\Users\DELL\go\src\github.com\alexbeltran\gobacnet>baccli readprop -d 1294418 -o 0 -j 0 -i Npcap Loopback Adapterr

im getting the errors like
time="2019-08-08T17:18:19+05:45" level=fatal msg="route ip+net: no such network interface"
plz help me with this issue
thank you

Right now when a read property is not handle correctly it will time out instead of interpreting type 80 messages.

Currently all errors are simply passed. Adding a little bit of context as we pass it up the chain will help with debugging.

i.e.

_, err := os.Create()
if err != nil{
    return fmt.Errof("unable to create file: %v")
}

instead of

_, err := os.Create()
if err != nil{
    return err
}

This would be useful when passing up the chain since there are multiple stages and packages used for each command called. An example would be an error in the encoding portion could give additional context in the net layer so we know at what point it fails.

See title