alexbain / backbone-firebase Goto Github PK

Hi alex, thanks for the really useful library.

Something that through me when I was getting up and running with it, was how there is no need to call fetch when instantiating a collection.

After this runs

notes = new Notes() 
board = new Board(model: notes).render().$el.appendTo('body')

the appropriate events on the collection start firing

initialize: ->
  @model.bind 'add', @addModel, @

So I guess this isn't an issue as such but maybe something to add to the docs

Model URL is a bit awkward. The model must declare a URL, but what should that be?

If I put something like this:

Backbone.Model.extend({  url: 'users/'  });

Then Backbone.sync( 'create' ... ) will work fine. But a read/update/delete will modify the parent tree (oops).

I can add a function, but the function will have to know what operation is taking place on it. Because for create it needs to return the url path of the parent (e.g. users/), but for update, read and delete ops, it needs to return something like users/my_unique_id

I'll add a commit to my PR to make Backbone.sync take care of suffixing the record ID as needed, so that all the model needs to understand is what it's table name (parent path) is.

It looks like Backbone.sync() will fail unless the model has aurl` attribute](https://github.com/alexbain/backbone-firebase/blob/master/backbone-firebase.js#L121).

That should probably be added to the readme example?

this.reference is declared on line 22 (with default URL) and then again on line 33, creating two Firebase instances (double overhead).

urlError is invoked on line 121, but does not exist