alexandregpereira / monster-compendium Goto Github PK

How to reproduce

1. Launch the app
2. Open the folder tab
3. Hold down on an existing folder
4. Click delete

Expected behavior

The folder disappears and is deleted.

Actual behavior

The folder does not disappear

Additional information:

1. Google Pixel 5 - Android 14
2. App version 24.02.16.14489

When reading the view code by PR, it very hard to distinguish if the composable function is model instance or not. Like the code below, it was removed from a fragment and took me some time to understand that is not a instance of a model (it is the call of composable component MonsterDetail).

    CircularLoading(viewState.isLoading) {
        viewState.monsters.takeIf { it.isNotEmpty() }?.let {
            MonsterDetail(
                it,
                viewState.initialMonsterIndex,
                contentPadding,
                onMonsterChanged = { monster ->
                    viewModel.setMonsterIndex(monster.index)
                },
                onOptionsClicked = viewModel::onShowOptionsClicked
            )
            ...
        }
    }

I think that is a good idea to add a prefix or suffix to identify that is composable function more easily.