the icon is normal for me about thorium-win-avx2 HOT 18 CLOSED

Hmm. Can you provide a screenshot? And the icon bug just came back when I tested it in a win7 and win10 VM. So I assumed it would look the same for everyone, so Im interested.

from thorium-win-avx2.

Hmm. Can you provide a screenshot? And the icon bug just came back when I tested it in a win7 and win10 VM. So I assumed it would look the same for everyone, so Im interested.

The 103 version of the taskbar icon is normal, but the icon in the taskbar thumbnail is not displayed properly.

from thorium-win-avx2.

i am on windows 11 but i only get that icon bug when hovering over the taskbar icon and it shows on the alt tab screen but when looking on the taskbar and the actual browser its fine @Alex313031

from thorium-win-avx2.

@gz83 @crocer211 Is Thorium pinned to the taskbar? Unpin it if so, the bug might show up like it does for me on the taskbar. Making a new regular windows build to test.

from thorium-win-avx2.

@Alex313031 unpinned it and its still normal maybe its working fine in windows 11

from thorium-win-avx2.

@gz83 @crocer211 Is Thorium pinned to the taskbar? Unpin it if so, the bug might show up like it does for me on the taskbar. Making a new regular windows build to test.

I don't have Thorium pinned to the taskbar, the taskbar thumbnails are displayed like the above in normal mode and incognito mode.

from thorium-win-avx2.

@crocer211 @gz83 Thats weird. It has the bug for me in my win7, win 10, and win 11 vbox vms. And that was with fully uninstalling the previous version and reinstalling the new one, as I always do to test new releases to remove any variables. Im making a new AVX2 release right now, so we'll see if its all good.

The last time this bug showed up, it was because the //chromium/src/chrome/app/theme dir had a PRESUBMIT.py that was set to python2, and needed to be updated to python3, which I did, and then ironically it was converted to python3 upstream just two weeks later. Nothing has changed in that dir upstream or in thorium since then, so Im stumped as to what it is now.

At first I thought it was the icons themselves, which made me mad because I used GIMP, and exported them in the exact fashion that Microsoft describes, and converted them to an .ico the way the chromium documentation describes, and then even ran it through optimize_ico.py in //chromium/src/scripts, which it says to do, and on top of checking the color space and losslessly compressing it, it also checks for the right internal format too. It turns out that the PRESUBMIT.py runs this anyway, but also runs optimize_png, which is needed before compilation of the theme dir, and because it was incorrectly set as python2, none of these were being run, but the compiler didn't catch it since it is run at the preprocessing stage.

If this release has the same issue, I'm going to compile it with -v I.E. verbose, and check to make sure everything in the theme dir is being run as it should.

from thorium-win-avx2.

@gz83 And granted, this is a good thing, yet it is still a bug since it showed up for me and its still showing up for you guys on hover and task switcher.
Its a good thing though because at least for my users the main icon on the taskbar isnt the ugly yellow warning. And the reason it is that of all things is that is the icon that windows uses when it detects a built in icon on an exe, but there is something wrong with it. If theres no icon at all , it uses the blank box icon which you may have seen at some point with some .exe.

from thorium-win-avx2.

@gz83 And granted, this is a good thing, yet it is still a bug since it showed up for me and its still showing up for you guys on hover and task switcher. Its a good thing though because at least for my users the main icon on the taskbar isnt the ugly yellow warning. And the reason it is that of all things is that is the icon that windows uses when it detects a built in icon on an exe, but there is something wrong with it. If theres no icon at all , it uses the blank box icon which you may have seen at some point with some .exe.

Thank you very much for such a detailed answer, which also gave me a better understanding of the mechanism of the relevant icons. The blank box icon you proposed, I have encountered it before.

from thorium-win-avx2.

@Alex313031 i have not seen that blank box icon before but at least its correct for the taskbar and the actual app icon

from thorium-win-avx2.

@gz83 @crocer211 Fixed!!! It was a typo in the last time I rebased the chrome_constants file which also sets certain asset names like the logo png name etc. Twas a stupid error. Will upload this fixed build soon.

On a sad note, this had the win 10 bug come back again, but strangely worked fine on win 11.

from thorium-win-avx2.

@gz83 @crocer211 Fixed!!! It was a typo in the last time I rebased the chrome_constants file which also sets certain asset names like the logo png name etc. Twas a stupid error. Will upload this fixed build soon.

On a sad note, this had the win 10 bug come back again, but strangely worked fine on win 11.

Does the error on win 10 mean that the browser needs to be opened in compatibility mode? Or is there something wrong with the icon?

from thorium-win-avx2.

@gz83 @crocer211 Sorry, should have specified. The compatibility bug is back. Lol the universe decided to switch the bugs between these releases.

from thorium-win-avx2.

@Alex313031 well you said it doesnt show it on win 11 well at least im on win 11

from thorium-win-avx2.

@gz83 @crocer211 Sorry, should have specified. The compatibility bug is back. Lol the universe decided to switch the bugs between these releases.

Is this a problem caused by adjusting the compilation parameters?

from thorium-win-avx2.

@gz83 I don't think so.

from thorium-win-avx2.

@gz83 I don't think so.

Looking forward to further investigation on this issue in the future.

from thorium-win-avx2.

@gz83 If I can fix the settings search issue and compatibility mode issue I will be happy. The least amount of friction for my users. Because while it doesn't break the browser, who want to have to go dig up the chrome.exe file and set compat mode.

from thorium-win-avx2.