alefragnani / vscode-bookmarks Goto Github PK

Running VSCode 0.10.1

To reproduce:

1. install the bookmarks extension
2. open a file
3. invoke the ">Bookmarks: Toggle" command in the Command Palette.

Result:
"No handler found for the command booksmarks.toggle"

In the console i see the following message:

TypeError: Cannot read property 'document' of undefined

If you set bookmarks for files that are only previewed, they are not restored when returning to that file.

Only files that goes to Working Files (double clicked in treeview or modified in preview) are saving the bookmarks.

It would be great to see the bookmarks on the scroll bar, like the error / warning marks.

Since the insider 1.6.0, the bookmark icons are not shown. The bookmark itself (the navigation feature) works, but no icon is presented in the gutter.

Reported in VS Code repo microsoft/vscode#12111.

When navigating the list by keyboard arrows each file is loaded in "preview" mode until the next bookmarked file is loaded (preview mode transfers to next file, previous file is pinned).

Clicking off the list (click into the file body) closes the preview (of currently selected bookmark in list) and returns the user to the last bookmark of the previous file pinned.

There are two issues really. 1) clicking in the document that is previewed closes the document, 2) previous documents get pinned causing a pile-up of documents to be opened.

It would be good to have a little preview when hovering the mark of a bookmark on the scrollbar.

I hope this is a doable feature.

As for breakpoints, it would be easier to add / remove bookmarks via the context menu if it's doable. 😋

Request feature:

Now the extension works great, but the problem is that it is based on line number, so every time I changed the code, the bookmark should update accordingly in order to match the latest change.

Any improvement could be very thankful. :)

Currently we cannot select when moving between bookmarks. This suggestion is to add commands to select while jumping to next/previous bookmark in the current file.

OS: Linux and MacOS
version: 0.9.2

Steps to reproduce:

1. Open to files and split them vertically
2. Create a book mark in each file
3. Focus one buffer and jump to next tag

Expected:
The cursor should jump to the buffer in the split.

Actual:
A new buffer was open with the file in the current split.

Here's a video of the reproduction:

Would it be possible to add the capability to place the opened file into edit mode when a bookmark is added?

To be more clear:

1. Open a project with multiple files.
2. Click on a file and add a bookmark without making any other edits. The file will be listed with the file name in italics
3. Click on another file
4. The file gets closed (yet the bookmark does persist)

Could we have the option so that the file is placed into edit mode and does not get closed when a bookmark is added?

Would be a nice feature to be able to make the bookmarks sticky to the original line of code when the bookmark was first added. After a while of coding all my bookmarks make no sense anymore.

The bookmarks function properly but there is no indicator. Using version 1.7.2 on OS X.

Using the next or previous bookmark either via the hot key, or selecting from the list, is not working. It doesn't seem to do anything. I have this same exact problem with another library of yours (project manager). Seems like the same issue.

When attempting to use any of the bookmark commands on a very large file (100,000 lines anecdotally) an info popup appears at the top displaying the message: "Open a file first to toggle bookmarks".

My reproduction:

1. Open large file.
2. Attempt to toggle breakpoint
3. Failure message appears.
4. Create copy of the large file.
5. Cut the file down to 50 lines.
6. Save, close, reopen pruned copy.
7. Can now toggle breakpoints.

currently when I close the project and reopen it, bookmarks are gone. is this a bug or I have to save bookmarks somehow that I don't know about

Replace the current bookmark icon for a transparent one, so it will be shown correctly no matter the theme used

I have the latest version. When I try to toggle bookmarks i get the message "Open a File First to toggle bookmarks."

Windows 7, x64
Latest VS Code

Create a new command (Bookmarks: List) that will show all bookmarked lines, with its content, so you easily identify which bookmark you would want to go.

The thought is to be able to set/toggle a bookmark by clicking in the gutter. When you click in the gutter for a line you could keep clicking and it would cycle between the break point and a bookmark or none.

If you delete a file which previously had a bookmark, the all file list no longer works.

Allow the user to define which icon to use as bookmark

Both Notepad++ and Atom uses F2. Set/Unset with e.g. Shift+F2 and then F2 to jump between.

Steps to reproduce:

• Open folder
• Open any file and set bookmark in any line
• Close editor
• Press F1 and select Bookmarks: List

VSCode show:

Error "Running the contributed command:'bookmarks.list' failed."

If file editor has opened, then all works.

Version 0.10.8
Commit db71ac615ddf9f33b133ff2536f5d33a77d4774e
Date 2016-02-05T10:00:07.223Z
Shell 0.35.6
Renderer 45.0.2454.85
Node 4.1.1

as described

Based on the review in the marketplace

If the Bookmarks List command can list all the bookmarks in all files, not just the current file, and the Bookmark Clear can clear all the bookmarks in all files, then it will be awesome.

If you edit the file outside VSCode, no matter if you have the file opened or not, the bookmarks become invalid.

Two problems appears:

• If the file is shorter than before, the bookmarks from the deleted lines are moved (appears) to the end of the file (last line). But if you try to navigate with next, it is not reached
• If you try to List bookmarks, and error occurs and the list is not displayed

A fix should be check for unreacheable bookmarks when loading, removing them from the file. This should fix both erros.

An enhancement should be add the line contents to the bookmark data so not only unreacheable bookmarks should be fixed, but also outside moved lines could be detected and even fixed

Currently bookmarks only use entire lines. When jumping to a bookmark the cursor moves to column 1. This suggestion is to have the bookmark remember the column number where the bookmark was set and return to the column number also.

Set to true by default is more logical in my opinion.

Is there any way to bookmark w/ mouse?

Local storage of bookmarks contains many files with no bookmarks. For large projects, this list continue to grow large.

I expect my bookmarks to be there when I close/reopen the program. It would be nice if they auto-saved.

VSCode Version: 1.3.1
OS Version: WIndows 10 (polish language)
Bookmarks: 0.9.0
Steps to Reproduce:

Press key RightAlt-l
Instead of getting polish character "Ł" some other operation is done (cursor is going to 1 col)

I actually have no extension in my vscode. I used to use atom where it was always said how to install. Could you add the instructions to the readme?

I expect bookmarks to behave like in Visual Studio, so bookmarks.navigateThroughAllFiles should default to true. I'm not sure if this even needs to be configurable.

DevConsole logs following warnings with your extenstion

Hi, @alefragnani

I'm not really sure if it is a bug or maybe a feature, but once VS Code is closed I loose all of my bookmarks. It would really be nice to have them saved cross code's sessions.

Keeping this aside, I think this plug-in is a must and should be included in the core of the editor. Nice work!!! Thanks you.

Not sure if this is an issue or a feature that hasn't been implemented yet...

1. Set a bookmark
2. Scroll down/up until bookmark is not in the current window
3. Try to jump to the bookmark, nothing happens, unless the text cursor is not on the same line as the bookmark

A command for selecting all bookmarked lines in the current file could be useful (for example, when working with log files). For example: Scroll through a log file and bookmark lines of interest. Run command to select all lines that are bookmarked, then copy to clipboard.

Nice extension BTW. Are you considering to extend it to include functions like those found in Notepad++?

• Cut Bookmarked Lines
• Copy Bookmarked Lines
• Paste to (Replace) Bookmarked Lines
• Remove Bookmarked Lines
• Remove Unmarked Lines - leave only Bookmarked lines
• Inverse Bookmark
• Find based Bookmark (find and mark the lines where is found)

Just a suggestion, the extension is great already.

Allow the bookmarks to be saved and restored, even if you close VS Code or change the active Project/Folder.

Hi,

Unless I'm missing something, it appears that executing "Jump to Next" or "Jump to Previous" only includes bookmarks in the same file. In Visual Studio 'full', the feature will include bookmarks across all files. This is extremely useful in large projects.

Do you think that this is this something very difficult to achieve? If you don't, then I'm open to helping.

Kind regards and thanks for the plug-in.

To reproduce this issue,

1. Enable bookmarks.useStickyBookmarks = true (I also have "editor.trimAutoWhitespace": false, but the bug persists with or without it)
2. Create a file and add it into git so that it's tracked.
3. Open the file in vscode and change it. Save the changes but don't stage the changes in git.
4. Add a bookmark on the file.
5. Close the file and then open it again.
6. Make a change to the file above the line that's bookmarked. The bookmark moves or fails.

Here's a gif of the bug in action. Note the lines indicating that the file is currently versioned and changed in git.

The bookmark works at first; it only fails after closing the file and reopening it:

Does it support to add a message for each bookmark?

I config in 'settings.json' as follow:

"bookmarks.useStickyBookmarks": true

When i add some new blank line before the bookmark, the bookmarks can not stick

do you know why it would do that. I had developer's console on but that's all it said.

Don't see any config block in vs settings to remap the keybindings. Is it possible? Thanks

The extension logs a message about activation. I don't think it needs to be in production version:

I don't know if this kind of integration is possible, but it'd be handy if so