alcueca / erc7399-reference Goto Github PK

https://github.com/alcueca/erc7399/blob/56ba9dfdee8ad34150bc77de2bb67c950a1bb415/src/FlashLender.sol#L58

This is a concatenation of (address, bytes4),

I spent some time trying to figure out what you mean by this but cant figure it out. What is a concatenation of (address, bytes4)? It's not the data passed to the callback nor is it the bytes data that is returned to this function so what are you referring to? 🤔

https://github.com/alcueca/erc7399/blob/56ba9dfdee8ad34150bc77de2bb67c950a1bb415/src/FlashLender.sol#L14

idk if it's too much of an implementation detail for the EIP, but you could offer token-based fees (instead of one fee for all tokens) by having this supportedTokens mapping be a mapping of address --> SupportedToken struct. If a uint type less than 256 bits is chosen, then both would fit in a single word which could be read by a single SLOAD.

struct SupportedToken {
  bool enabled;
  uint128 fee;
}