alblue / com.packtpub.e4 Goto Github PK

In TimeZoneLabelProvider#getStyledText, the offset calculation should be like this:
int offset = ((TimeZone) element).getOffset(System.currentTimeMillis());

rather than:
int offset = -((TimeZone) element).getOffset(0);

since this is also how the offset is calculated in TimeZoneViewerComparator.

Without this fix, the offsets displayed in the UI are not sorted and the minus/plus prefix is reverse.

Great book, btw! :-)

Hi,

I installed a new Eclipse and download the sample code from the site. I followed the instruction to run it as Eclipse Application, and click the Sample Command in Sample Menu, but no Dialog box appeared. What went wrong ?

Thanks

Peter

Save time to readers and add direct link to the book at amazon http://www.amazon.com/Eclipse-Plug--Development-Example-Beginners/dp/1782160329 in the REAME

Hi author, I follow your book trying to create a SWTBot test case. For the first time, it takes a very long time to run, but in the end it would pass all test cases.
However when I try to run the same code for second time, only testUI() will pass, the other three will have org.eclipse.swtbot.swt.finder.exceptions.WidgetNotFoundException: The widget was null.

I though I have typo somewhere so I download the sample code from github, but the problem still exist. In the book you worte

If one is not currently visible, it polls (every 500 milliseconds by default) until one is found or the default timeout period (5 seconds) ends when a WidgetNotFoundException is thrown

But I don't see why the first time all test cases will pass but not the second time.

How could you view if your book would be in Chinese?
How much would license, help with translation etc?