albinogeek / sc2-rsu Goto Github PK

GUI Changes:

• Show Account(s) and Toon(s) in the UI
  • Toggle which Toon(s) are ignored

Core Changes:

• Store Account(s) and Toon(s) between runs
  • Check for new Account(s) and Toon(s) on startup
  • Check for new Account(s) and Toon(s) periodically

Configuration Changes:

• Known Accounts/Toons
• Ignored Accounts/Toons

• upload Command
  • Filter Support:
    • Account ID
    • Toon ID
    • Map Name
    • Date/Time
  • Wildcard Support

I just leave the program (sc2-rsu-0.4.1-linux-amd64) open for a while after I played some matches and at some point I get this:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x98f6e3]

goroutine 11 [running, locked to thread]:
fyne.io/fyne/widget.(*tableRenderer).moveIndicators(0xc000228a10)
	/go/pkg/mod/fyne.io/[email protected]/widget/table.go:317 +0x183
fyne.io/fyne/widget.(*tableRenderer).Layout(0xc000228a10, 0x283, 0x1d1)
	/go/pkg/mod/fyne.io/[email protected]/widget/table.go:242 +0x2f
fyne.io/fyne/internal/driver/glfw.updateLayout(0xecff00, 0xc0001320c0)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/glfw/canvas.go:633 +0x11e
fyne.io/fyne/internal/driver/glfw.(*glCanvas).ensureMinSize.func1(0xc0018b8370)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/glfw/canvas.go:335 +0x168
fyne.io/fyne/internal/driver/glfw.(*glCanvas).walkTree.func2(0xecf480, 0xc001a07900, 0xecfea0, 0xc000040a80)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/glfw/canvas.go:513 +0xd8
fyne.io/fyne/internal/driver.walkObjectTree(0xecf480, 0xc001a07900, 0xecfea0, 0xc000040a80, 0x198, 0x5f, 0x0, 0x0, 0x7fffffff, 0x7fffffff, ...)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/util.go:88 +0x27f
fyne.io/fyne/internal/driver.walkObjectTree(0xecfea0, 0xc000040a80, 0xecff00, 0xc0001320c0, 0xa6, 0x5b, 0x0, 0x0, 0x7fffffff, 0x7fffffff, ...)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/util.go:81 +0x1f6
fyne.io/fyne/internal/driver.walkObjectTree(0xecff00, 0xc0001320c0, 0xecf1e0, 0xc0000a7270, 0xa6, 0x40, 0x0, 0x0, 0x7fffffff, 0x7fffffff, ...)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/util.go:81 +0x1f6
fyne.io/fyne/internal/driver.walkObjectTree(0xecf1e0, 0xc0000a7270, 0xecf1e0, 0xc0000a67d0, 0xa2, 0x3c, 0x0, 0x0, 0x7fffffff, 0x7fffffff, ...)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/util.go:81 +0x1f6
fyne.io/fyne/internal/driver.walkObjectTree(0xecf1e0, 0xc0000a67d0, 0xecf1e0, 0xc0000a6820, 0x0, 0x0, 0x0, 0x0, 0x7fffffff, 0x7fffffff, ...)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/util.go:81 +0x1f6
fyne.io/fyne/internal/driver.walkObjectTree(0xecf1e0, 0xc0000a6820, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x7fffffff, 0x7fffffff, ...)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/util.go:81 +0x1f6
fyne.io/fyne/internal/driver.WalkVisibleObjectTree(0xecf1e0, 0xc0000a6820, 0xc0020b5ce8, 0xc0020b5cc0, 0x46371f)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/util.go:25 +0x82
fyne.io/fyne/internal/driver/glfw.(*glCanvas).walkTree(0xc0000ca500, 0xc0012ac5c0, 0x0, 0xc0020b5db8)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/glfw/canvas.go:519 +0x15c
fyne.io/fyne/internal/driver/glfw.(*glCanvas).walkTrees(0xc0000ca500, 0x0, 0xc0020b5db8)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/glfw/canvas.go:526 +0x4f
fyne.io/fyne/internal/driver/glfw.(*glCanvas).ensureMinSize(0xc0000ca500, 0xc0020b5e28)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/glfw/canvas.go:340 +0x98
fyne.io/fyne/internal/driver/glfw.(*gLDriver).repaintWindow.func1()
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/glfw/loop.go:156 +0x40
fyne.io/fyne/internal/driver/glfw.(*window).RunWithContext(0xc000230000, 0xc0020b5e60)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/glfw/window.go:1095 +0x38
fyne.io/fyne/internal/driver/glfw.(*gLDriver).repaintWindow(0xc0000a6fa0, 0xc000230000)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/glfw/loop.go:155 +0x60
fyne.io/fyne/internal/driver/glfw.(*gLDriver).startDrawThread.func1(0xc0000a6fa0, 0xc000038780, 0xc0000a7040)
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/glfw/loop.go:208 +0x223
created by fyne.io/fyne/internal/driver/glfw.(*gLDriver).startDrawThread
	/go/pkg/mod/fyne.io/[email protected]/internal/driver/glfw/loop.go:182 +0xbd

• download Command
  • Filter Support:
    • Account ID
    • Toon ID
    • Map Name
    • Date/Time
    • Type [ AutoMM, AutoMM A.I, Private, AutoMM Archon
    • Format [ 1v1, 2v2, 3v3, 4v4 ]
    • Matchup [ TTTTvZZZZ, etc... ]
  • Wildcard Support

• delete Command
  • Filter Support:
    • Account ID
    • Toon ID
    • Map Name
    • Date/Time
    • Type [ AutoMM, AutoMM A.I, Private, AutoMM Archon
    • Format [ 1v1, 2v2, 3v3, 4v4 ]
    • Matchup [ TTTTvZZZZ, etc... ]
  • Wildcard Support
• preserve flag to Download before Deleting

Maybe require Elite Member? This feature could introduce some load on SC2ReplayStats servers, due to the lack of API endpoint therefore requiring browser automation, loading the replays list, filtering the results, and clicking the "Delete" link for each replay that matches the given filters.

• download Command
  • Filter Support:
    • Account ID
    • Toon ID
    • Map Name
    • Date/Time
    • Type [ AutoMM, AutoMM A.I, Private, AutoMM Archon
    • Format [ 1v1, 2v2, 3v3, 4v4 ]
    • Matchup [ TTTTvZZZZ, etc... ]
  • Wildcard Support

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
I find it annoying to use a CLI when a GUI would make it nice and pleb level for me :)

Describe the solution you'd like
I would like a nice GUI to interact with the application because I'm too lazy to use the CLI.

Summary

Currently make release does not add the --release flag to the fyne-cross command like it should.

Describe the bug
replays will not upload, returns an unauthorized error

To Reproduce
Steps to reproduce the behavior:

1. Run application
2. Play starcraft
3. Replays fail to upload

Expected behavior
replays fail to upload

Screenshots
Error as shown in GUI

Screenshot of the error message in the terminal:

Desktop (please complete the following information):

• OS: Linux x86_64
• Distro: Arch
• Version: latest release of sc2-rsu

Additional context
the accounts tab is blank despite the api key being accepted

Description

Calling defer on Close might result in errors. For instance, if you wrote data to the file, it might have been cached in memory and not flushed to disk by the time you called Close. This error should be explicitly handled. Ref: - https://www.joeshaw.org/dont-defer-close-on-writable-files/

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/AlbinoGeek/sc2-rsu/issue/SCC-SA5001/occurrences/

This has been fixed on the gui/v2 branch, but has not been merged into main yet.

Application Changes:

• update Command
  • Ability to download updates
• Check for updates on startup
• Check for updates periodically

Configuration Changes:

• update.check.enabled To toggle checking for updates
• update.check.period How often to check for updates
• update.automatic.enabled Enable automatic downloading of updates

Summary

Error message shown when enabling previously-ignored toons after program restart.

Reproduction

1. Set up sc2-rsu
2. Ignore some toons
3. Close sc2-rsu
4. Re-open sc2-rsu
5. Un-ignore those toons

Possible Source

When paths are watched it may not be considering the ignores

Originally posted by @AlbinoGeek in #11 (comment)

• Move away from viper for configuration
  • package types
    • Config struct
    • Config.Load(filename) error
    • Config.LoadEncrypted(filename, passphrase) error
    • Config.Save(filename) error
    • Config.SaveEncrypted(filename, passphrase) error
    • NewConfig() *Config
  • Detect Encrypted Configuration presence
    • Request passphrase on startup to decrypt
    • Scrub passphrase from memory after decryption