albertomontalesi / coderschool_week2_chatapp Goto Github PK

Hi @lanhhoang, nice work with your assignment 2 submission 👍

The goals of this homework are:

• to know how to implement authentication from scratch in Rails with the help of the has_secure_password class method and the brypt gem (while understanding what they do under the hood)
• to design a more complex schema for a web app and be more familiar with ActiveRecord API such as custom foreign keys for belongs_to/has_many, using has_many :through and building more advanced queries by chaining where, order, and merge
• to build more complex forms in views that involve multiple models.

Quick review:

• Correctly handle user signup in Users controller and user login in Sessions controller and define current_user correcty
• Use validations for improtant columns
• Try to use more partial
• Correctly define belongs_to/has_many with custom class_name and foreign_id
• Correctly use has_many :through for friendship
• Follow basic Ruby style guide: don't use multiple empty lines to separate methods, one is enough

Great work on implementing all required stories and also some optional stories.

Detailed review

Gemfile:

• You put bcrypt gem to development/test gem group, It means bcrypt is not available on Production(Heroku), so I think it could be your problem with heroku, try to move it out of the group and redeploy.

group :development, :test do
  # Call 'byebug' anywhere in the code to stop execution and get a debugger console
  gem 'byebug', platform: :mri
end
gem 'bcrypt', '~> 3.1', '>= 3.1.11' ------ this line
gem 'bootstrap', '~> 4.0.0.alpha6'
source 'https://rails-assets.org' do
  gem 'rails-assets-tether', '>= 1.3.3'
end

Routes file:

• Good RESTful routes with resources method and Clean custom routes

Controllers:

• good use pf before_action
• define current_user in ApplicationController and use helper_method to make it available for the view

Congrats again on the submission. Everyone has limited time; it's good to see you .... Let us know if you have any feedback.