albell / parse-srcset Goto Github PK

Would like to see this on jsDelivr.

This parser is friggin’ amazing, and we’d love to have you involved in Picturefill.

We’ve started putting a more formal team together for the project, and this parser completely blows mine out of the water in terms of accuracy, efficiency, and code organization—would you be interested in teaming up?

https://github.com/baloneysandwiches/parse-srcset/blob/master/parse-srcset.js#L57-L58
does not match https://html.spec.whatwg.org/multipage/infrastructure.html#space-character

Would be useful

https://github.com/baloneysandwiches/parse-srcset/blob/master/parse-srcset.js#L26
spec
https://html.spec.whatwg.org/multipage/infrastructure.html#valid-non-negative-integer
Leading + or - is not allowed.

((intVal >= 0) can be removed also.)

Hi, could you make a new release and publish it on npmjs?

https://github.com/baloneysandwiches/parse-srcset/blob/master/parse-srcset.js#L31
spec
https://html.spec.whatwg.org/multipage/infrastructure.html#valid-floating-point-number
The + is not allowed. The rest of the regex is correct AFAICT.

The inline documentation says that the `x' descriptor is exposed a 'x', but instead it is exposed as 'd'.

I would prefer, if it would be the x key, because every candidate has a computable pixel density. So the d can be used to bring sizes and w descriptor together.

Hi

I'm struggling with parsing srcsets where the urls in the srcset have commas in them.

I've had a look at your code, which seems very thorough, but looks like you render a parse error when a URL has a comma in it?

Is that right?