Code Monkey home page Code Monkey logo

aladdin-contracts's People

Contributors

0xum1ng avatar starit-eth avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

aladdin-contracts's Issues

【Vaults】合约优化

测试结果:
(1)Desposit,当 存款数量 > 钱包余额,合约返回的错误:An error occurred: Internal JSON-RPC error. { "code": -32603, "message": "Error: VM Exception while processing transaction: reverted with reason string 'SafeERC20: low-level call failed'" }

image

(2)Withdraw,当 取款数量 > 存款余额,合约返回的错误:An error occurred: Internal JSON-RPC error. { "code": -32603, "message": "Error: VM Exception while processing transaction: reverted with reason string 'Vault: not enough share'" }

image

(3)【待评估】取款数量=0,前端直接提交至合约,合约可以成功,没有任何报错

预期结果:
(1)和(2)看能不能优化一下提示语,对用户更加友好
(3)【待评估】这种取款数量为0的,合约是不是应该直接拒绝

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.