al-serebrov / python-auto-ria Goto Github PK

There are some parameters, that look like they are boolean (True / False):

myCarAveragePrice = RiaAverageCarPrice(
    ....   
    custom=0,
    damage=0,
    under_credit=0,
    confiscated=0,
    on_repair_parts=0
)

These look like boolean parameters, but they are handled as integers.
Can they be something different than 0 or 1?
If not - they should be bool and not int.

The test for average calculation using all search parameters should be added.

Now there are 11 requests in the API implementation, there are issues:

• not all parameters could be set (a lot of them is None)
• not all requests are needed

It's needed to add checks for presence of parameters and rewrite an __init__() method of RiaAverageCarPrice the way it doesn't make unnecessary requests.

We need to decide whether the state parameter would be required, making the whole-country price search unavailable, or we shouldn't make request getting a list of cities if the state isn't set.

The functions select_item(), select_list() are in use while there are no tests for them.
Tests should be added for:

• check exact match
• check wild-carded match

Now request mocks are inside the test_average.py, but they should be moved to separate fixture in the conftest.py