Code Monkey home page Code Monkey logo

Comments (7)

0-5-0 avatar 0-5-0 commented on June 16, 2024 2

Yes I guess Meteo France goes up to 16, Open-Meteo is 15 and OpenWeatherMap is 8.

Maybe the wording could be "Number of days to show if available (includes Current)", to kind of hint that it doesn't guarantee the number, similar to the feels like setting.

Used the AI bot in Brave browser to see if it could be shorter:
"Days in forecast (if available, includes Current)"

@farfromrefug
I'm happy to contribute what I can, looking for Open-Meteo apps it was initially a bit hard to find but with key words in the description now and having it on the Open-Meteo page hopefully it'll bring more people who can also enjoy it. You've done so much work on this app and have been able to implement so many suggestions lately that I wanted to say thanks and why I became a supporter.

Exposing the Open-Meteo models I think you're the first to do that for Open-Meteo, transparency and colours on the map look great, CM vs MM again the first for Open-Meteo apps. Open-Meteo is a great API and accessing it from this app makes it even better :).

from oss-weather.

0-5-0 avatar 0-5-0 commented on June 16, 2024 1

Works fine with 15, "includes current" looks good.

from oss-weather.

farfromrefug avatar farfromrefug commented on June 16, 2024

@0-5-0 it is released!

from oss-weather.

0-5-0 avatar 0-5-0 commented on June 16, 2024

There's a typo in the text under settings, says "forcast" but should be "forecast", aside from that it says 16 days as the max but if I select it it gives me an error, if I choose 15 days it shows 14, choosing 14 days shows 13 and so on.

There might be a number off somewhere.

Trimming the list works great otherwise, just off by 1 number compared to what's selected in the settings.

from oss-weather.

farfromrefug avatar farfromrefug commented on June 16, 2024

@0-5-0 the number takes the current day into account. so if you choose 5 it will show 4 days after today. could change that

from oss-weather.

0-5-0 avatar 0-5-0 commented on June 16, 2024

That makes sense if it includes the current day's forecast at the top. If someone might only want to show the current day's forecast and nothing else, might be useful if the chart grows some day and it's configurable.

Maybe writing the text as "Number of days to forecast (includes Current)" could clear things up.

Number of days 16 gives me the following error "Forecast days is invalid. Allowed range 0 to 16. Given 16."

from oss-weather.

farfromrefug avatar farfromrefug commented on June 16, 2024

@0-5-0 YOu are right will change the text. About 16 guess it was too much for OM. Will put 15 as max. BTW it depends on the provider, with OM i can ask up to 15. For other i can only filter from what the api returns (which can me much less).
BTW @0-5-0 I really want to thank you for your contributions. You can contact me by mail if you want.

from oss-weather.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.