Code Monkey home page Code Monkey logo

Comments (12)

farfromrefug avatar farfromrefug commented on September 25, 2024

@0-5-0 thanks. And it does not look good there! everything seems out of place.
What s your system font scale?

from oss-weather.

0-5-0 avatar 0-5-0 commented on September 25, 2024

I had it on 0.8, I find 1.0 too big. Here's a few screenshots of the different charts using a day with more data, the one above was "current" day so I guess it trims a lot of chart.

Screen 1 - 1.0 Scale, "old" chart:

Screen 2 - 0.8 Scale, "old" chart:

Screen 3 - 1.0 Scale, "new" chart:

Screen 4 - 0.8 Scale, "new" chart:

from oss-weather.

0-5-0 avatar 0-5-0 commented on September 25, 2024

I'm also wondering if maybe it trimmed a bunch of the "current" day chart (which would have been looking for yesterday's 8PM data) because of the date in the top right? If I click on Sunday it's probably a good example it shows "Saturday" in the top right, then the chart starts at 4:00PM Saturday.

You can kind of see the same thing in the screenshots above where I had opened Saturday, it shows Friday in the top right then the chart starts Friday 8-9PM and goes into Saturday.

It might be the date thing/timezone issue throwing it off.

from oss-weather.

farfromrefug avatar farfromrefug commented on September 25, 2024

@0-5-0 thanks for the detailed report! (as usual!). I will update a new version which will hopefully fix it

from oss-weather.

0-5-0 avatar 0-5-0 commented on September 25, 2024

The date looks ok now on the latest version, I noticed if I enable "Weather Data -> Show current day in daily list", this is what's causing the first day in the daily list to show up with no chart in the daily view. It also staggers the rest of the charts for all the days.

from oss-weather.

0-5-0 avatar 0-5-0 commented on September 25, 2024

The data in the chart also seems to start on the previous day still. If I open Wednesday from Daily List, it shows Wednesday in Daily View, but the "new" chart starts on Tuesday. This is all with "show current day in daily list" unselected.

I also tried using Grenoble and it looks fine using Grenoble with "show current day" selected or unselected, but Thursday has no chart for some reason.

So it's as if the timezone issue also applies separately to the chart itself. You can try with Toronto Canada to test.

from oss-weather.

farfromrefug avatar farfromrefug commented on September 25, 2024

@0-5-0 i cant reproduce the wrong date yet. will try more.
Also for thursday not showing chart that s normal. charts are based on hourly data. And we only get a limited number of them in prediction (around 72 hours)

from oss-weather.

0-5-0 avatar 0-5-0 commented on September 25, 2024

Here's an example where I selected Wednesday using Toronto as the location from the Daily View list, you can see the chart starts "Tue" and then finishes "Wed".

The same settings, selecting Wednesday in the Daily View list but with Grenoble as the location, you can see the chart starts "Wed" and ends "Wed".

This is why I think the chart itself also has the timezone issue that the top right date had and that the Daily View list had 😅

from oss-weather.

0-5-0 avatar 0-5-0 commented on September 25, 2024

Here's a screenshot of Toronto with the "old" chart, you can see under the time it's "Tue" with the "old" chart as well.

from oss-weather.

farfromrefug avatar farfromrefug commented on September 25, 2024

@0-5-0 great explanation! thanks will look at that tomorrow

from oss-weather.

farfromrefug avatar farfromrefug commented on September 25, 2024

@0-5-0 should be better in latest. let me know

from oss-weather.

0-5-0 avatar 0-5-0 commented on September 25, 2024

Looks great now, thank you :)

from oss-weather.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.