akkana / pho Goto Github PK

Hi, I just got word of this project from your recent blog article. I wanted to ask you if you heard of the niche called tag file systems. If not - maybe look it up. If you find it interesting, you could try to intgrate it with the app? Some links to get you started:

• https://elbosso.github.io/tag_basierte_dateisysteme.html#content (Its in german because it is in my own blog),
• https://github.com/StrumentiResistenti/Tagsistant
• https://github.com/oniony/TMSU/wiki
• https://www.tagsistant.net/
• https://www.tagspaces.org/

Hi, I've been using pho to look at some pictures from an old phone (Motorola G5S) and kept getting the error above for many of the files. The error causes pho to stop and no output is produced (e.g. notes or rotation info for previous files) other than the error message.
I have found a workaround for the issue, which was to change the hardcoded MAX_SECTIONS (in exif/jpgfile.c) from 20 to 100 and recompile. I haven't noticed any adverse effects since making the change, and I haven't gotten the error since.
Perhaps this number should be increased or alternatively an argument could be passed at run time to override it (something like --max-sections=100).
Thanks.

Suggested by 石柱 (pinkme005 yahoo.com.cn) in email:

Could you add more scale ratio to pho ,for example:25%,50%,75%. 125%,150%...?

One of the aspect ratio code changes broke image scaling. You can't do double or half size any more.

Suggested by 石柱 (pinkme005 yahoo.com.cn) in email:

When operating in normal, windowed (non-presentation) mode, if the image is larger than the screen size, pho should limit the window size to the screen size and show scrollbars.

Makefile calls "make" directly, which is wrong, as actual binary can be called differently (e.g. GNU make is called "gmake" in FreeBSD). Canonical way to reference make implementation that reads your Makefile is to use $(MAKE) instead. Simple patch:

--- Makefile.orig
+++ Makefile
@@ -40,7 +40,7 @@
 tar: clean $(TARFILE)

 $(TARFILE):
-       ( make clean && \
+       ( $(MAKE) clean && \
          cd .. && \
          tar czvf $(TARFILE) --exclude=.svn --exclude=.git --owner=root $(CWDBASE) && \
          mv $(TARFILE) $(CWD) && \
@@ -64,5 +64,5 @@
        rm -f *.[oas] *.ld core* pho xpho pho-*.tar.gz *.rpm
        rm -f build-stamp configure-stamp
        rm -rf debian/pho
-       cd exif; make clean
+       cd exif; $(MAKE) clean