Code Monkey home page Code Monkey logo

Comments (15)

haohcraft avatar haohcraft commented on May 3, 2024

Ran into the same issue

from react-slick.

haohcraft avatar haohcraft commented on May 3, 2024

Related to kenwheeler/slick#412

if we upgrade the slick version we are using here, it would fix

from react-slick.

yankrasny avatar yankrasny commented on May 3, 2024

I've run into the same issue. On desktop, onClick events work as expected, but on mobile (whether in the chrome simulator or on an actual phone) onClick events don't go through. Thinking that this may have been related to facebook/react#1169, I added cursor: pointer on all clickable elements, but that did not solve the problem.

from react-slick.

vramana avatar vramana commented on May 3, 2024

@yankrasny Can you make a gist or jsfiddle? From which I can reporduce this issue? It will help a lot.

from react-slick.

yankrasny avatar yankrasny commented on May 3, 2024

@vramana sure, I'll try to get you an example later today. Thanks for the quick response.

from react-slick.

yankrasny avatar yankrasny commented on May 3, 2024

Hey @vramana, here are the jsfiddles for desktop and mobile.

Desktop: https://jsfiddle.net/yankrasny/hug2f0r1/6/
Mobile (access from a mobile or a simulator, I used chrome): https://jsfiddle.net/m/rvt/

The behavior is to display the link that was last clicked as proof that the onClick event went through. It works on desktop but not on mobile.

You'll also notice that on desktop, clicking any of the slides brings you back to the first one. I believe @haohcraft is right and this may be related to kenwheeler/slick#412.

from react-slick.

stevemckenzie avatar stevemckenzie commented on May 3, 2024

This is also happening for me.

from react-slick.

stevemckenzie avatar stevemckenzie commented on May 3, 2024

@akiran any update on this?

from react-slick.

akiran avatar akiran commented on May 3, 2024

@stevemckenzie Can you test the fix in 0.6.1 version

from react-slick.

yankrasny avatar yankrasny commented on May 3, 2024

Just tested version 0.6.1 and the issue appears to be fixed. Thank you!

from react-slick.

stevemckenzie avatar stevemckenzie commented on May 3, 2024

Thank you @akiran ! This definitely fixes the ability to touch links in slides.

I thought this was going to fix the automatically scrolling back to the first item when you start scrolling the page issue too but it didn't.

from react-slick.

akiran avatar akiran commented on May 3, 2024

@stevemckenzie Can you open a separate issue for the scrolling issue.

from react-slick.

gus4no avatar gus4no commented on May 3, 2024

how can I get version 0.6.1 with this fix? Available versions using bower are 0.5.0, 0.4.1 and 0.3.1

from react-slick.

akiran avatar akiran commented on May 3, 2024

I created a github release with 0.6.4 version.

Now you should be able to get it from bower

from react-slick.

gus4no avatar gus4no commented on May 3, 2024

Thank you very much! @akiran

from react-slick.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.