Code Monkey home page Code Monkey logo

Comments (1)

jimbokid avatar jimbokid commented on May 18, 2024

Problem Description

Upon investigating an issue within the component of the react-slick package, I discovered that the currentSlide prop was occasionally receiving non-integer values (e.g., 1.66777) when rendering the last slide. This irregularity can cause unexpected behavior in the rendering and functionality of the dots navigation.

Resolution

To address this bug, I have implemented a fix in the component. The solution involves wrapping the currentSlide with Math.round to ensure it always receives an integer value, eliminating potential discrepancies.

dotProps = {
        ...dotProps,
        clickHandler: this.changeSlide,
        onMouseEnter: pauseOnDotsHover ? this.onDotsLeave : null,
        onMouseOver: pauseOnDotsHover ? this.onDotsOver : null,
        onMouseLeave: pauseOnDotsHover ? this.onDotsLeave : null,
        currentSlide: Math.round(dotProps.currentSlide)    // <--- this line fixed issue
      };
      dots = <Dots {...dotProps} />;

Implementation

The modified code has been pushed to a fork of the original repository. You can review the changes and test the fix by accessing my fork:

GitHub Fork with the Fix
In addition, I have published an npm package with the alteration for those who require an immediate solution:

react-slick-fixed-dots on npm
I look forward to the community's feedback on this solution, and I'm open to further improvements. Thank you for your consideration.

from react-slick.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.