akira-cn / babel-plugin-transform-private Goto Github PK

🍺 Great plugin. Such awesome.

I will propose an enhancement to support "class properties" provided in Babel via https://www.npmjs.com/package/babel-plugin-transform-class-properties.

class Example {
  _x = 0;
  _y = 0;
  right() {
    this._x += 1;
  }
  down() {
    this._y += 1;
  }
}

I've tried running transform-private both before and after transform-class-properties with the same result: The other plugin moves the property declarations into the constructor, but they are not translated into symbol properties by this plugin.

Interestingly, The class properties are correctly declared as symbols in the output, but I assume that this is just a lucky side effect of babel-plugin-syntax-class-properties. The output looks something like this:

const Example = function() {
  const [$_x$, $_y$] = [Symbol('$_x$'), Symbol('$_y$')];
  let Example = class Example {
    constructor(...args) {
      return super(...args), this._x = 0, this._y = 0; // not symbols!
    }
  }
  return Example;
}()

This may not be easy to implement, but then again, perhaps it is?