ajkerzner / ateam Goto Github PK

I'd like it to be centered.

AboutScreen.java has a main method. It should not have a main method.

Only one main method should be present, and it will be in Main.java.

Recommended fix:
main methods in MainScreen.java, NameScreen.java, etc. should be changed from public static void main(...) to public static void startGame(), or equivalent.

The name change will prevent running the wrong main method to start the program. This makes it easier when compressing the project into a runnable jar file.
Keeping the method static will allow us to use the method without creating an object of that class.
It is not necessary to force this method to be void.
It is not necessary to name it startGame().

In Main.java, the main method will execute:
MainScreen.startGame().

MainScreen's startGame() method should call NameScreen's whateverMethod().

Draw the tic-tac-toe board.

Popups do not get the correct parent pane.

Make it happen

So, I put together a working example, and verified that the code behind the game is finished.
Oh, and my working example is pretty awesome.

My recommendation is to rewrite the original MainScreen.java class with my version - it needs a lot more polish, and some more stuff added (like names, sidebars, bottom bar, connection with other screens, additional error-handling, and comments/formatting).

It also has appropriate keyboard shortcuts and whatever.

This is not because I like your code. This is because I hate autogenerated code.

Winning screen should not close the application.

No limits on the length of a player name.

I'm thinking these two should be merged.

Title says it all

Example. Alt-F4 = close window

Layout should be fixed
Size should also be fixed

Closing AboutScreen via the red X on the title bar (Operating System dependent) should not close the MainScreen.

Mnemonic for Help menu is actually the mnemonic for About menu.

No game logic is present.

NameScreen.java has a main method. It should not have a main method.

Caused by Alex Kerzner

Buttons need to be connected to keyboard equivalents.

Line circa 4, 44: * @author WalterGoerling added, * @author JosephMiller moved to after Walter's name.

Add a version indicator