- Auth2
- API Call Calling with saved data on repo and until app not closed and pattern with API access and re-Auth when auth session finished.
- Vertical Page Control
- Refresh
- Navigation bar according to Survey mage
survey's Introduction
survey's People
survey's Issues
Process need to be improved
The commit history is very limited (only 5 commits) which means that the commits have been large. Instead, it would be better to have numerous but smaller commits which would help in reverting changes, rebasing or cherry-picking tasks.
In addition, you did not make use of the pull requests which are a powerful tool to perform code review (even when working alone in a project).
Question - Why not using Alamofire or an alternative?
For commercial projects, you are better off not re-inventing the wheel as you would avoid lots of stability and security concerns. Instead of using oauth2.session.dataTask
in ApiAccess
, I would recommend to follow the guide in the wiki of p2.oauth2
Question - Why not using UIPageViewController?
UIKit has a built-in pager view controller (just like in Android) which is UIPageViewController. This controller also have built-in support for a paging indicator. So why having it built with a custom UIScrollView
and VerticalPageControl
?
Naming needs to be clearer
Across the whole project, it's often hard to follow the code as variables, method and class names are not very clear:
Subview of what? As this is the actual view containing the whole survey list, the name is sub-par.
Never use abbreviated names for variables name, be clear.
I am not following the naming of CoreApiAccess
as the child class of ApiAccess
. Core
or Base
seems to be the parent class.
Inconsistent code formatting
Missing platform setting in podfile
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.