Code Monkey home page Code Monkey logo

survey's Introduction

Survey Application

  • Auth2
  • API Call Calling with saved data on repo and until app not closed and pattern with API access and re-Auth when auth session finished.
  • Vertical Page Control
  • Refresh
  • Navigation bar according to Survey mage

survey's People

Contributors

ajayodedara avatar

survey's Issues

Process need to be improved

The commit history is very limited (only 5 commits) which means that the commits have been large. Instead, it would be better to have numerous but smaller commits which would help in reverting changes, rebasing or cherry-picking tasks.

In addition, you did not make use of the pull requests which are a powerful tool to perform code review (even when working alone in a project).

commits_ _ajayodedara_survey

Naming needs to be clearer

Across the whole project, it's often hard to follow the code as variables, method and class names are not very clear:

subview_swift

Subview of what? As this is the actual view containing the whole survey list, the name is sub-par.

surveyviewcontroller_swift

Never use abbreviated names for variables name, be clear.

coreapiaccess_swift

I am not following the naming of CoreApiAccess as the child class of ApiAccess. Core or Base seems to be the parent class.

Inconsistent code formatting

Across the whole project, it's often hard to follow the code as there are inconsistent line breaks, spacing and code organization:

surveyviewcontroller_swift

surveyviewcontroller_swift

repository_swift

Missing platform setting in podfile

hyper_and_ajay

The platform setting is always added to the podfile but you need to comment it out:

# Uncomment the next line to define a global platform for your project
# platform :ios, '9.0'

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.