aisingapore / peekingduck Goto Github PK

1. Implement standardized logging
2. Remove all print/other logging from ALL python files
3. Add new logging to ALL python files
4. Update how to do so in HOUSE RULES.

Within sample node:

from typing import ...
docstrings
typehinting
inputs[self.inputs[0]] to inputs["bbox"]

• Some draw functions return {} in .py while .yml shows output ["img"]
• input.live does not take any input, but .yml shows input ["source"]
• output.screen returns empty {}, but .yml shows ["end"]
• and others to be checked.

Fix the linting errors under "Run linter" in:
https://github.com/aimakerspace/PeekingDuck/runs/2418435037?check_suite_focus=true

This was the dev branch that was merged on Friday evening 23 Apr.

@tanddoubleu:

• All yolo related
• Module peekingduck.weights_utils.checker
• Module peekingduck.weights_utils.downloader

@leeping-ng:

• Module peekingduck.pipeline.nodes.input.utils.preprocess
• Module peekingduck.pipeline.nodes.input.utils.read
• Module peekingduck.pipeline.nodes.input.live
• Module peekingduck.pipeline.nodes.input.recorded
• Module peekingduck.pipeline.nodes.heuristic.3dLocFromBbox

@jwaycube:

• Module peekingduck.pipeline.nodes.output.media_writer
• Module peekingduck.pipeline.nodes.node
• Module peekingduck.pipeline.pipeline

@wowowowameratsu:

• Module peekingduck.config
• Module peekingduck.runner
• Module peekingduck.cli

@chngzyk:
Module peekingduck.pipeline.nodes.draw.utils.drawfunctions
Module peekingduck.pipeline.nodes.draw.bbox
Module peekingduck.pipeline.nodes.output.screen

• Try Github hosted runners first
• Try self hosted runners next

Look into Azure CDN to speed up the distribution, maybe even mirror on GCP also

in preparation for launch, newcomer/example scripts should be created and curated.

• colab in python-mode
• example scripts (?)

suggest for yolo_node module to be renamed to yolo to be consistent with the other nodes

__main__.py will be deprecated soon; to add setupLogger to cli.py once #35 has been merged

Originally posted by @wowowowameratsu in #39 (comment)

This provides some info on how to track visits and clones: https://opensource.guide/metrics/

Perhaps can get from this repo: https://github.com/xuannianz/EfficientDet

ConfigLoader is refactored to split the responsibility of

1. Loading Configs from config folder
2. Loading and instantiating nodes

Present difficulties:

• Will keep looping and re-downloading, but if {"end": True} it will not continue with other nodes
• Input.recorded checks that the folder has the required files during init stage. However, when downloading from cloud, it's natural to not have the files yet during init stage, throwing an error

Use factory manager to handle object creation for nodes, to create more separation of concern

setup.cfg now does not detect yml files in new nested structure

utils is also missing __init__.py

Refactored ConfigLoader to be added to CLI to compile configs

• Refactor existing Posenet from Makerpose
• To discuss: mutability in existing code makes it confusing, but to modify it will require significant effort

I get the error in the title when running input.live in run_config.yml.

Seems to be an issue with thread.start() not running properly as expected.

pkdk need to be able to save to multiple files as output. The plan is to implement this file output as a node.

D.O.D.

• save single image
• save single video
• save multi images
• save multi videos

Last videofile doesn't get saved properly

"""
python version 3.7
opencv-python==4.5.1.48
"""

Doesn't work for me, I get this error. Something to do with file pathing?

    from .yolo import yolo_model
  File "/opt/anaconda3/envs/makerpose/lib/python3.7/site-packages/peekingduck/pipeline/nodes/model/yolo/yolo_model.py", line 5, in <module>
    from peekingduck.weights_utils import checker, downloader

ModuleNotFoundError: No module named 'peekingduck.weights_utils'

Originally posted by @leeping-ng in #35 (comment)