aidarkhanov / nanoid Goto Github PK

../github.com/aidarkhanov/nanoid/nanoid.go:32:11: invalid operation: 2 << (31 - bits.LeadingZeros32(uint32(len(alphabet) - 1 | 1))) (shift count type int, must be unsigned integer)

It's give me this error when I try to get package with go get github.com/aidarkhanov/nanoid
It was working before this commit b8b9271

Hello!

I am trying read your implementation and docs (I want to generate identifiers only from symbols) - I found it and all right.

But in your README (you just copy that string, I know :)) you wrote that nanoid used more characters than UUID. I decide to compare your source code and original and found that you used different strings in default mode:

• you are used string alphabet = "-0123456789ABCDEFGHNRVfgctiUvz_KqYTJkLxpZXIjQW"
• from original repository let urlAlphabet = 'ModuleSymbhasOwnPr-0123456789ABCDEFGHNRVfgctiUvz_KqYTJkLxpZXIjQW'

It is not a problem - I can specify it by myself via Generate, for example. But I think that all general implementation should work the same as original.

And I think that you should rewrite your code like:

// GenerateString generates a random string based on
// alphabet and size.
func GenerateString(alphabet string, size int) (string, error) {
	id, err := FormatString(generateRandomBuffer, alphabet, size)
	if err != nil {
		return "", err
	}
	return id, nil
}

// New generates a random string.
func New() (string, error) {
	return GenerateString(alphabet, size)
}

Because the original code looks like duplicate logic.