ahsanulabeer / colmaracademy Goto Github PK

Criteria 1: HTML Structure  

• _Score Level: 3/4
• _Comment(s): Your HTML structure looks good. Good indentation and good use of an array of elements. However, your links to your images and the CSS file was wrong. You used an absolute path instead of relative meaning none of the files loaded until I fixed the link.

<link rel="stylesheet" href="./resources/css/style.css">

vs

<link rel="stylesheet" href="/Users/ahsanulabeer/Documents/HTML/ColmarAcademy/resources/css/style.css">

Criteria 2: Visual Layout for Both Desktop and Mobile Sizes

• _Score Level: 2/4
• _Comment(s): The larger sizes look good. However, mobile sizes are crammed and don't resize. They break their containers in most areas and the the nav bar doesn't collapse.

Criteria 3: Responsive Design (Media Queries, Responsive Units, etc.)

• _Score Level: 2/4
• _Comment(s): Larger views are good, the smaller views really need more attention.

Criteria 4: Visual Design and Accessibility (Color Palette, Typography, Transitions, etc.)

• _Score Level: 2/4
• _Comment(s): Overall, it doesn't look bad. However, it doesn't look like a lot of effort was put into making the page really pop. There is no color or over effects. It's just white and gray for the most part.

Overall Score: 9/16

You made a really good effort but I think you should definitely revisit the lessons. The mobile views on the page were really lacking. A lot of the elements didn't fit their containers and the nav bar didn't collapse into icons as requested. There also wasn't a lot of extra added to the page like colors or effects. However, your CSS and HTML code was tidy and correct. Try working on the mobile views a little more and playing around with CSS and you should be good to go.