ahoo-wang / cosid Goto Github PK

debug的时候配置的是:

cosid:

  namespace: ${spring.application.name}
  snowflake:
    enabled: true
    machine:
      distributor:
        type: redis

默认是share的ID生成器吧 我代码获取的和 @cosid生成的数字不一直 刚刚开始看代码 有点懵逼 望解答
代码是这样获取的

      // 获取的是 315557917682049024    3开头的
      long id = idGeneratorProvider.getShare().generate();

实体打注解的

   // 生成的id为 ：6922446069401911327
  @CosId
  @TableId(value = "id", type = IdType.INPUT)
  private Long id;

想请问 手动获取创建的id也想要 6开头的怎么弄 可以吗？

1.8.6版本

Steps to reproduce the behavior

Example codes for reproduce this issue (such as a github link).

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

CosId was added in Apache ShardingSphere recently, when I'm running shardingsphere-sharding-core module's unit test in IDEA, it has some failed cases of CosIdIntervalShardingAlgorithmTest which are related with IntervalTimeline.sharding. Failed result:

Related code:

        @Test
        public void assertDoSharding() {
            RangeShardingValue shardingValue = new RangeShardingValue<>(LOGIC_NAME, COLUMN_NAME, rangeValue);
            Collection<String> actual = shardingAlgorithm.doSharding(ALL_NODES, shardingValue);
            assertThat(actual, is(expected));
        }

In fact, actual and expected has the same elements, but they're different Collection's sub-type, so they're not equals. Debug screenshot:

actual is instance of Collections$SingletonSet, but expected is instance of ExactCollection.

Describe the solution you'd like
A clear and concise description of what you want to happen.

In IntervalTimeline.java

    @Override
    public Collection<String> sharding(Range<LocalDateTime> shardingValue) {
//...
        if (lowerOffset == upperOffset) {
            return Collections.singleton(lastInterval.getNode());
        }
//...
        ExactCollection<String> nodes = new ExactCollection<>(nodeSize);
//...
        return nodes;
    }

Collections.singleton(lastInterval.getNode()) could be replaced to return ExactCollection or , just like other return statements.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

It's possible to fix it by changingexpected in CosIdIntervalShardingAlgorithmTest.rangeArgsProvider, but it's a little strange, users should not concern about the implementation of IntervalTimeline.sharding.

Additional context
Add any other context or screenshots about the feature request here.

The https://cosid.ahoo.me/config/snowflake.html#iddefinition Is wrong

The right example :

cosid:
namespace: ${spring.application.name}
machine:
enabled: true
distributor:
type: redis
guarder:
enabled: true
machine-bit: 8
snowflake:
enabled: true
zone-id: Asia/Shanghai
epoch: 1660000000000
provider:
order_item:
timestamp-bit: 40
sequence-bit: 8

guava [30.0-jre] -> [29.0-jre]

guava 29.0-jre：
Direct vulnerabilities:
CVE-2020-8908

Hello, in combination with whether there are specific documents for springboot, I can see that there are some configurations in readme, but there is no specific description for many springboot configurations. Can you provide a specific configuration description? Furthermore, the description of different packages in Maven warehouse. thank you

And are there best practices.
Moreover, the cosid-rest-api failed

1.7.9

cosid:
  namespace: ${spring.application.name}
  segment:
    enabled: true
    mode: chain
    chain:
      safe-distance: 5
      prefetch-worker:
        core-pool-size: 2
        prefetch-period: 1s
    distributor:
      type: redis
    share:
      offset: 5
      step: 100
      converter:
        prefix:
        type: radix
        radix:
          char-size: 6
          pad-start: false
    provider:
      order:
        offset: 1
        step: 100

@Cosid(value="order")
private Long id;

id指定了provider是order, mybatis实际插入数据库为何每次都是按照share的offset开始插入, 是用的姿势不对吗?

     new User(null, "张三");
   
    @Insert(value = "insert into user values (#{id} ,#{name} )")
    void save(User xx);

节点一直重启的情况下，machineId是不是会超出上限？

https://github.com/Ahoo-Wang/CosId/tree/main/examples/cosid-example/src/main/java/me/ahoo/cosid/example/entity/interval

Bug Report

跑循环生成测试第一个生成的ID不是有序步长递增的，我跑的测试很简单 这个是为何？望解答 thanks. 我跑了很多次基本都是这个结果

    public static void main(String[] args) {

//      epoch和 machineId做了修改  其他都是默认值    
        MillisecondSnowflakeId millisecondSnowflakeId = new MillisecondSnowflakeId(1577836800000L, 41, 10, 12, 3);
        for (int i = 0; i < 100; i++) {
            long generate = millisecondSnowflakeId.generate();
            System.out.println(generate);
        }
    }

跑出来的结果是：

# 第一个ID生成和第二个没有递增关系  从第二个开始 3 4 5一直往后才有递增关系

321493968892211200 

321493968896405504
321493968896405505
321493968896405506
321493968896405507
321493968896405508
321493968900599808
321493968900599809
321493968900599810
321493968900599811
321493968900599812
321493968900599813
321493968900599814
321493968900599815
321493968900599816
321493968900599817
321493968900599818
321493968900599819
321493968900599820
321493968900599821
321493968900599822
321493968900599823
321493968900599824
321493968900599825
321493968900599826
321493968900599827
321493968900599828
321493968900599829
321493968900599830
321493968900599831
321493968900599832
321493968900599833
321493968900599834
321493968900599835
321493968900599836
321493968900599837
321493968900599838
321493968900599839
321493968900599840
321493968900599841
321493968900599842
321493968900599843
321493968900599844
321493968904794112
321493968904794113
321493968904794114
321493968904794115
321493968904794116
321493968904794117
321493968904794118
321493968904794119
321493968904794120
321493968904794121
321493968904794122
321493968904794123
321493968904794124
321493968904794125
321493968904794126
321493968904794127
321493968904794128
321493968904794129
321493968904794130
321493968904794131
321493968904794132
321493968904794133
321493968904794134
321493968904794135
321493968904794136
321493968904794137
321493968904794138
321493968904794139
321493968904794140
321493968904794141
321493968904794142
321493968904794143
321493968908988416
321493968908988417
321493968908988418
321493968908988419
321493968908988420
321493968908988421
321493968908988422
321493968908988423
321493968908988424
321493968908988425
321493968908988426
321493968908988427
321493968908988428
321493968908988429
321493968908988430
321493968908988431
321493968908988432
321493968908988433
321493968908988434
321493968908988435
321493968908988436
321493968908988437
321493968908988438
321493968908988439
321493968908988440

Which version of CosId did you use?

1.12.0

cosid-spring-boot-starter 由于 spring-cloud-commons 包的引入会抛出 兼容性的异常 CompatibilityNotMetException，可以根据提示在配置文件中配置

spring:
  cloud:
    compatibility-verifier:
      enabled: false

可以解决。

Which version of CosId did you use?

1.12.1

Bug Report

之前 单机、主从的redis都正常

我们的测试环境使用的docker部署的单机的redis，线上和UAT环境使用的阿里云的云产品【云数据库Redis版】，集群5.0版本。当我们准备部署上阿里云上的时候服务启动的时候报了lua脚本执行错误。
如下:

[2022-07-07 16:06:40.182] [INFO ] [SWTraceId - TID: N/A] [] [me.ahoo.cosid.spring.redis.SpringRedisMachineIdDistributor] - distributeRemote - instanceId:[InstanceId{instanceId=172.28.25.39:7, stable=false}] - machineBit:[10] @ namespace:[xxxx-service]. 
[2022-07-07 16:06:40.300] [WARN ] [SWTraceId - TID: N/A] [] [org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext] - Exception encountered during context initialization - cancelling refresh attempt: org.springframework.context.ApplicationContextException: Unable to start web server; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.springframework.boot.autoconfigure.web.servlet.ServletWebServerFactoryConfiguration$EmbeddedTomcat': Initialization of bean failed; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'sqlSessionFactory' defined in class path resource [com/baomidou/mybatisplus/autoconfigure/MybatisPlusAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.apache.ibatis.session.SqlSessionFactory]: Factory method 'sqlSessionFactory' threw exception; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'shareSnowflakeId' defined in class path resource [me/ahoo/cosid/spring/boot/starter/snowflake/CosIdSnowflakeAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [me.ahoo.cosid.snowflake.SnowflakeId]: Factory method 'shareSnowflakeId' threw exception; nested exception is org.springframework.dao.InvalidDataAccessApiUsageException: ERR bad lua script for redis cluster, all the keys that the script uses should be passed using the KEYS array, and KEYS should not be in expression. channel: [id: 0x7f4f67ec, L:/172.28.25.39:43428 - R:r-bp1usnu4324n3247.redis.rds.aliyuncs.com/12.9.0.43:579] command: (EVAL), params: [[45, 45, 32, 105, 116, 99, 95, 105, 100, 120, ...], 1, [123, 112, 105, 109, 115, 45, 102, 105, 110, 97, ...], [49, 55, 50 
, 46, 50, 56, 46, 50, 53, 46, ...], [49, 48, 50, 51], [49, 54, 53, 55, 49, 56, 49, 50, 48, 48, ...], [49, 54, 53, 55, 49, 56, 48, 57, 48, 48, ...]]; nested exception is org.redisson.client.RedisException: ERR bad lua script for redis cluster, all the keys that the script uses should be passed using the KEYS array, and KEYS should not be in expression. channel: [id: 0x7f4f67ec, L:/172.28.25.39:43428 - R:r-adsadsadsad.redis.rds.aliyuncs.com/12.9.0.1213:349] command: (EVAL), params: [[45, 45, 32, 105, 116, 99, 95, 105, 100, 120, ...], 1, [123, 112, 105, 109, 115, 45, 102, 105, 110, 97, ...], [49, 55, 50, 46, 50, 56, 46, 50, 53, 46, ...], [49, 48, 50, 51], [49, 54, 53, 55, 49, 56, 49, 50, 48, 48, ...], [49, 54, 53, 55, 49, 56, 48, 57, 48, 48, ...]] 
[2022-07-07 16:06:40.345] [WARN ] [SWTraceId - TID: N/A] [] [org.springframework.context.annotation.CommonAnnotationBeanPostProcessor] - Destroy method on bean with name 'lifecycleBootstrap' threw an exception: org.springframework.beans.factory.BeanCreationNotAllowedException: Error creating bean with name 'redisClientFactory': Singleton bean creation not allowed while singletons of this factory are in destruction (Do not request a bean from a BeanFactory in a destroy method implementation!) 
[2022-07-07 16:06:40.357] [INFO ] [SWTraceId - TID: N/A] [] [org.springframework.boot.autoconfigure.logging.ConditionEvaluationReportLoggingListener] - 
 
Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled. 
[2022-07-07 16:06:40.361] [ERROR] [SWTraceId - TID: N/A] [] [org.springframework.boot.SpringApplication] - Application run failed 

Reason analyze (If you can)

阿里云官网对其做了解释，是限制了lua脚本的一些调用规则https://help.aliyun.com/document_detail/92942.html?spm=5176.13910061.sslink.1.36426f0dV6cOrU

引用自：https://www.jianshu.com/p/6bd82d96ffcf

已经测试过，可以通过控制台将script_check_enable修改为0解决，但是有没有说要对lua脚本做一些调整 符合它的限制的可能？

Is your feature request related to a problem? Please describe.
第一点，我所在的小庙，为了运维方便，使用k8s来维护生产环境的项目，且使用了HPA做弹性伸缩。
有些项目，存在这样的情况：没有人用的时候，一天都没有几个请求，一旦有人使用到业务高峰的时候，可能会有3k多的并发。庙里配备的运维人员又少，所以类似这样的项目，我们暂时采用k8s的HPA功能做弹性伸缩，事实上也有着很不错的表现。
然后cosid，号段链模式，将会有prefetchWorker线程，预取号段，被预取的号段，将会维护在服务的内存中，不会持久化（如果没有理解错的话）。我看了您的文档，并不怀疑cosid的性能。
但是可能在业务高峰的时候，k8s弹性伸缩，java服务的deployment多出很多个pod，然后这多个实例都预取了号段，且并发越大安全距离会越大，预取号段会越多，正常使用扛过高峰之后，k8s又会弹性伸缩移除掉很多pod。这些被移除的pod预取的号段，可能还没有使用，然后pod就没了，号段就浪费了，id就浪费了。实际存储在库里的id就可能会有较大的不连续。
但是其实我们庙里的业务量根本远远不可能将Long型的id用完，所以这里的号段浪费其实是可以容忍的。

第二点，我所在的小庙有些业务要使用到bitset，之前好多项目使用的是雪花算法变种作为分布式id的解决方案。但是雪花算法对bitset的使用非常不友好，所以我考虑改用号段算法去实现分布式id，然后就查到了cosid这个项目。
在号段被浪费的情况下，bitset的长度可能会受到影响，消耗更多内存。即使我对bitset进行分片，也有可能因为号段中id的浪费，导致分片的bitset中存在大量0，和少量1的情况，造成内存的浪费。请问有没有什么优化的手段？

Describe the solution you'd like
我阅读了cosid的文档，认为可以将号段步长“step”配置的小一点，安全距离"safe-distence"配置小一点，可以尽可能的减少号段和id的浪费。

Describe alternatives you've considered
可不可以有一种新的预取号段的方式。现有cosid的prefetchWorker会自适应的改变安全距离“safe-distence”。
prefetchWorker自适应改变预取周期“prefetch-period”。并发越高，预取周期越短，然后安全距离固定。来实现？

或者将使用号段和使用完毕号段的信息和时间持久化。每隔一段时间将那些比较古老的，没有使用过号段回收。但是这样会打破趋势递增的规则。

Additional context
无

• 官方命名空间（springboot 官方项目）
  前缀：spring-boot-starter-
  模式：spring-boot-starter-{模块名}
  举例：spring-boot-starter-web、spring-boot-starter-jdbc
• 自定义命名空间（非springboot 官方）
  后缀：-spring-boot-starter
  模式：{模块}-spring-boot-starter
  举例：mybatis-spring-boot-starter

TODO

假如应用宕机或者直接被kill掉，zk对应的节点不会被删除，导致应用在zk生成的节点会生成越来越多，宕机一次多生成一次。为什么这个节点不做成临时节点？这样宕机节点也会被删除。

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Bug Report

Before report a bug, make sure you have:

• Searched open and closed GitHub issues.
• Read documentation: CosId Doc.

Which version of CosId did you use?

1.10.0

Reason analyze (If you can)

    public SecondSnowflakeId(long machineId) {
        this(CosId.COSID_EPOCH_SECOND, DEFAULT_TIMESTAMP_BIT, DEFAULT_MACHINE_BIT, DEFAULT_SEQUENCE_BIT, machineId);
    }

    public SecondSnowflakeId(int machineBit, long machineId) {
        super(CosId.COSID_EPOCH, DEFAULT_TIMESTAMP_BIT, machineBit, DEFAULT_SEQUENCE_BIT, machineId);
    }

这两个构造函数的epoch值不同，第二个应该使用CosId.COSID_EPOCH_SECOND

如果Distributor类型为JDBC或者其他，这个自动关闭钩子，如果运行在数据库关闭之后，那边会引起访问数据库，建议让使用者来决定是否由cosid关闭；增加一个是否自动关闭的属性或者构造函数设置，使用者可以设置

Bug Report

Before report a bug, make sure you have:

• Searched open and closed GitHub issues.
• Read documentation: CosId Doc.

Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot reproduce it on current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Which version of CosId did you use?

1.10.2

Expected behavior

Gradle build succeeded

Actual behavior

Gradle build error

> Task :compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Could not resolve all files for configuration ':compileClasspath'.
   > Could not resolve com.squareup.okhttp3:okhttp:3.14.9.
     Required by:
         project : > me.ahoo.cosid:cosid-core:1.10.2 > me.ahoo.cosid:cosid-dependencies:1.10.2
      > No matching variant of com.squareup.okhttp3:okhttp:4.9.3 was found. The consumer was configured to find an API of a component compatible with Java 11, preferably in the form of class files, preferably optimized for standard JVMs, and its dependencies declared externally, as well as attribute 'org.gradle.category' with value 'platform' but:
          - Variant 'apiElements' capability com.squareup.okhttp3:okhttp:4.9.3 declares an API of a component compatible with Java 8, packaged as a jar, and its dependencies declared externally:
              - Incompatible because this component declares a component, as well as attribute 'org.gradle.category' with value 'library' and the consumer needed a component, as well as attribute 'org.gradle.category' with value 'platform'
              - Other compatible attribute:
                  - Doesn't say anything about its target Java environment (preferred optimized for standard JVMs)
          - Variant 'javadocElements' capability com.squareup.okhttp3:okhttp:4.9.3 declares a runtime of a component, and its dependencies declared externally:
              - Incompatible because this component declares a component, as well as attribute 'org.gradle.category' with value 'documentation' and the consumer needed a component, as well as attribute 'org.gradle.category' with value 'platform'
              - Other compatible attributes:
                  - Doesn't say anything about its target Java environment (preferred optimized for standard JVMs)
                  - Doesn't say anything about its target Java version (required compatibility with Java 11)
                  - Doesn't say anything about its elements (required them preferably in the form of class files)
          - Variant 'runtimeElements' capability com.squareup.okhttp3:okhttp:4.9.3 declares a runtime of a component compatible with Java 8, packaged as a jar, and its dependencies declared externally:
              - Incompatible because this component declares a component, as well as attribute 'org.gradle.category' with value 'library' and the consumer needed a component, as well as attribute 'org.gradle.category' with value 'platform'
              - Other compatible attribute:
                  - Doesn't say anything about its target Java environment (preferred optimized for standard JVMs)
          - Variant 'sourcesElements' capability com.squareup.okhttp3:okhttp:4.9.3 declares a runtime of a component, and its dependencies declared externally:
              - Incompatible because this component declares a component, as well as attribute 'org.gradle.category' with value 'documentation' and the consumer needed a component, as well as attribute 'org.gradle.category' with value 'platform'
              - Other compatible attributes:
                  - Doesn't say anything about its target Java environment (preferred optimized for standard JVMs)
                  - Doesn't say anything about its target Java version (required compatibility with Java 11)
                  - Doesn't say anything about its elements (required them preferably in the form of class files)

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 2s
2 actionable tasks: 1 executed, 1 up-to-date

Reason analyze (If you can)

Steps to reproduce the behavior

execute gradle clean build -x test

Example codes for reproduce this issue (such as a github link).

ext {
    set('springCloudVersion', "2021.0.2")
    set('cosidVersion', '1.10.2')
    set('okhttpVersionn', '4.9.3')
}

dependencies {
    implementation 'org.springframework.boot:spring-boot-starter-web'
    implementation 'org.springframework.boot:spring-boot-starter-jdbc'

    implementation 'me.ahoo.cosid:cosid-core'
    implementation 'me.ahoo.cosid:cosid-jackson'
    implementation 'me.ahoo.cosid:cosid-jdbc'
    implementation 'me.ahoo.cosid:cosid-mybatis'
    implementation 'me.ahoo.cosid:cosid-redis'
    implementation 'me.ahoo.cosid:cosid-shardingsphere'
    implementation 'me.ahoo.cosid:cosid-spring-boot-starter'
    implementation 'me.ahoo.cosid:cosid-spring-redis'
    implementation 'me.ahoo.cosid:cosid-zookeeper'

    implementation "com.squareup.okhttp3:okhttp:${okhttpVersionn}"
}

订单号通常是日期时间+xxx，比如20220520142030+87663233， 请教这个生产这种格式的序列号支持吗？

Bug Report

 demo测试  spring boot 2.6.6 运行异常 ，spring boot 2.5.12 运行正常
 部分异常日志：
 1、description = 'Spring Boot [2.6.6] is not compatible with this Spring Cloud release train', action = 'Change Spring Boot version to one of the following versions [2.4.x, 2.5.x] .
  2、If you want to disable this check, just set the property [spring.cloud.compatibility-verifier.enabled=false]']]

Before report a bug, make sure you have:

• Searched open and closed GitHub issues.
• Read documentation: CosId Doc.

Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot reproduce it on current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Which version of CosId did you use?

Expected behavior

Actual behavior

Reason analyze (If you can)

猜测：me.ahoo.cosid:cosid-spring-boot-starter 引用 org.springframework.cloud:spring-cloud-commons 导致的版本不兼容

Steps to reproduce the behavior

Example codes for reproduce this issue (such as a github link).

SnowflakeId

MachineIdDistributorProxy(Client) --http--> cosid-proxy(Server/Broker)

SegmentId

IdSegmentDistributorProxy(Client) --http--> cosid-proxy(Server/Broker)

Bug Report

Before report a bug, make sure you have:

• Searched open and closed GitHub issues.
• Read documentation: CosId Doc.

Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot reproduce it on current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Which version of CosId did you use?

1.13.1

Expected behavior

正常结束

Actual behavior

报错

me.ahoo.cosid.machine.NotFoundMachineStateException: Not found the MachineState of instance[InstanceId{instanceId=xxx:xxx, stable=true}]@[{cosid}]!
	at me.ahoo.cosid.machine.AbstractMachineIdDistributor.resetStorage(AbstractMachineIdDistributor.java:100) ~[cosid-core-1.13.1.jar:?]
	at me.ahoo.cosid.machine.AbstractMachineIdDistributor.revert(AbstractMachineIdDistributor.java:80) ~[cosid-core-1.13.1.jar:?]
	at me.ahoo.cosid.spring.boot.starter.machine.CosIdLifecycleMachineIdDistributor.stop(CosIdLifecycleMachineIdDistributor.java:49) ~[cosid-spring-boot-starter-1.13.1.jar:?]
	at org.springframework.context.SmartLifecycle.stop(SmartLifecycle.java:117) ~[spring-context-5.3.21.jar:5.3.21]
	at org.springframework.context.support.DefaultLifecycleProcessor.doStop(DefaultLifecycleProcessor.java:234) ~[spring-context-5.3.21.jar:5.3.21]
	at org.springframework.context.support.DefaultLifecycleProcessor.access$300(DefaultLifecycleProcessor.java:54) ~[spring-context-5.3.21.jar:5.3.21]
	at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.stop(DefaultLifecycleProcessor.java:373) ~[spring-context-5.3.21.jar:5.3.21]
	at org.springframework.context.support.DefaultLifecycleProcessor.stopBeans(DefaultLifecycleProcessor.java:206) ~[spring-context-5.3.21.jar:5.3.21]
	at org.springframework.context.support.DefaultLifecycleProcessor.onClose(DefaultLifecycleProcessor.java:129) ~[spring-context-5.3.21.jar:5.3.21]
	at org.springframework.context.support.AbstractApplicationContext.doClose(AbstractApplicationContext.java:1067) ~[spring-context-5.3.21.jar:5.3.21]
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.doClose(ServletWebServerApplicationContext.java:174) ~[spring-boot-2.7.1.jar:2.7.1]
	at org.springframework.context.support.AbstractApplicationContext.close(AbstractApplicationContext.java:1021) ~[spring-context-5.3.21.jar:5.3.21]
	at org.springframework.boot.SpringApplicationShutdownHook.closeAndWait(SpringApplicationShutdownHook.java:145) ~[spring-boot-2.7.1.jar:2.7.1]
	at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]
	at org.springframework.boot.SpringApplicationShutdownHook.run(SpringApplicationShutdownHook.java:114) ~[spring-boot-2.7.1.jar:2.7.1]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]

Reason analyze (If you can)

Steps to reproduce the behavior

将 state-storage 设置为 false

Example codes for reproduce this issue (such as a github link).

cosid:
  machine:
    enabled: true
    stable: true
    state-storage:
      enabled: false
    distributor:
      type: manual
      manual:
        machine-id: 0
    guarder:
      enabled: false
    clock-backwards:
      spin-threshold: 1
      broken-threshold: 10000
  snowflake:
    enabled: true
    epoch: 1659283200000
    share:
      clock-sync: true
      friendly: true

Minimum code coverage threshold: 80%

Bug Report

Before report a bug, make sure you have:

• Searched open and closed GitHub issues.
• Read documentation: CosId Doc.

Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot reproduce it on current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Which version of CosId did you use?

ShardingSphere 5.20 ,CosId 1.14.4

Expected behavior

期望输出 table_20221015_06

Actual behavior

实际输出 table_20221015_00

Reason analyze (If you can)

源代码

  /**
     * 计算单位偏移量.
     * Start with 0
     *
     * @param start 最小值
     * @param time  time
     * @return offset
     */
    public int offsetUnit(LocalDateTime start, LocalDateTime time) {
        return getDiffUnit(start, time) / amount;
    }

    private int getDiffUnit(LocalDateTime startInterval, LocalDateTime time) {
        switch (unit) {
            case YEARS: {
                return getDiffYear(startInterval, time);
            }
            case MONTHS: {
                return getDiffYearMonth(startInterval, time);
            }
            case DAYS: {
                return getDiffYearMonthDay(startInterval, time);
            }
            case HOURS: {
               //这里直接取的天数*24换算成小时,导致不足一天hours的精度丢失，偏移量计算不正确
                return getDiffYearMonthDay(startInterval, time) * 24;
            }
            case MINUTES: {
                return getDiffYearMonthDay(startInterval, time) * 24 * 60;
            }
            case SECONDS: {
                return getDiffYearMonthDay(startInterval, time) * 24 * 60 * 60;
            }
            default:
                throw new IllegalStateException("Unexpected value: " + unit);
        }
    }

Steps to reproduce the behavior

Example codes for reproduce this issue (such as a github link).

    public static void main(String[] args) {
        DateTimeFormatter dateTimeFormatter = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss");
        String lower = "2022-10-10 00:00:00";
        String upper = "2022-10-16 00:00:00";
        LocalDateTime lowerDate = LocalDateTime.parse(lower, dateTimeFormatter);
        LocalDateTime upperDate = LocalDateTime.parse(upper, dateTimeFormatter);
        IntervalTimeline timeline = new IntervalTimeline("table_", Range.closed(lowerDate, upperDate), IntervalStep.of(ChronoUnit.HOURS, 6), DateTimeFormatter.ofPattern("yyyyMMdd_HH"));
        LocalDateTime shardingValue = LocalDateTime.parse("2022-10-15 11:40:00", dateTimeFormatter);
        String table = timeline.sharding(shardingValue);
        System.out.println(table);
    }

比如生成10位,不需要过长的,
另外是否可以指定以固定数字开头或者固定字母开头使 ID 容易分辨

Is your feature request related to a problem? Please describe.

Describe the solution you'd like
机器位=3多的话，最多8个实例，机器号范围：0～7. 针对实例由于非优雅关闭导致的机器号未被回收，建议加入心跳机制

Error creating bean with name 'shareSnowflakeId' defined in class path resource [me/ahoo/cosid/spring/boot/starter/snowflake/CosIdSnowflakeAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [me.ahoo.cosid.snowflake.SnowflakeId]: Factory method 'shareSnowflakeId' threw exception; nested exception is me.ahoo.cosid.CosIdException: java.io.IOException: Invalid file path

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

• More bits of IdConverter to further compress string ID length.
• Keep that the string IDs are in order.

#11

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update dependency org.activiti:activiti-engine to v7-201802-ea

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• fix(deps): update dependency com.netease.nim:camellia-id-gen-core to v1.2.27
• fix(deps): update dependency org.apache.shardingsphere:shardingsphere-sharding-core to v5.5.0

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

apache/shardingsphere#14047 (comment)

https://cosid.ahoo.me/guide/Performance-CosId-Leaf.html

Describe the solution you'd like

Add benchmark comparison between cosid and leaf. and add to workflows.

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

Due to the resource constraints of GitHub runner, the benchmark running in GitHub runner is very different from the benchmark in the real environment (nearly twice),
However, it is still valuable to compare the benchmark before and after commit and the third-party library when running in the same environment and configuring resources (both running in GitHub runner).

因受到 GitHub Runner 资源限制，运行在 GitHub Runner 中的基准测试与真实环境基准测试对比有非常大的差距（近2倍），
但是对于运行在同一环境配置资源情况下（都运行在 GitHub Runner），进行 commit 前后的基准对比、以及第三方库的对比依然是有价值的。