ahmkel / keras-project-template Goto Github PK

This always returns true because self.config is a dotmap.DotMap object.

It seems like current code have little bug on comet import
according to the report, we have to import comet before keras modules

Create the trainer
importing trainers.CifarTrainer
getattr CifarTrainer
<class 'trainers.CifarTrainer.CifarTrainer'>
Please import Comet before importing any keras modules

Hi @Ahmkel, this repo is really great! thanks for putting the time to implement this.
When I run the code follow the way in README, I have this issue...

Traceback (most recent call last):
  File "main.py", line 36, in <module>
    main()
  File "main.py", line 23, in main
    data_loader = SimpleMnistDataLoader(config)
  File "/home/scr/Documents/Keras-Project/data_loader/simple_mnist_data_loader.py", line 7, in __init__
    super(SimpleMnistDataLoader, self).__init__(config)

My python version is 2.7.12

AttributeError: 'Experiment' object has no attribute 'log_multiple_params'

It seems that log_multiple_params function in comet.ml has changed to log_parameters()

Issue

When hasattr() function is called on a DotMap instance (config in this case) regarding a non existing attribute, it is automatically created.

E.g. Let's say 'config' is a DotMap instance which does not have 'testAttr' as an attribute. It will be created after a hasattr() function call.

Solution

Convert DotMap instance to dict and then call hasattr, self.config.toDict().

or

replace hasattr() function with attr in self.config

I will open a pull request with my proposed solution tomorrow. 😃