ahmetuysal / nest-hackathon-starter Goto Github PK

Can you please add signup test to auth.service.spec to check if validation of username in auth.service signup function (or rather in signup-request.model) is working as expected?

I changed @Matches(RegExp(...)) expression and want to test different values of username.

I tried to wite such a test, and tried and tried... With no success unfortunately :)

There is:

  @Get('change-email')
  @HttpCode(HttpStatus.OK)
  async changeEmail(@Param('token') token: string): Promise<void> {
    await this.authService.changeEmail(token);
  }

Should be:

  @Get('change-email')
  @HttpCode(HttpStatus.OK)
  async changeEmail(@Query('token') token: string): Promise<void> {
    await this.authService.changeEmail(token);
  }

Hello there, fantastic starter - has really helped me studying nest.js!

I have a question about the Mailsender service as seen here

Why not inject it normally and use ConfigService for the Nodemailer env variables? Is there a benefit to import it directly?

Thanks!

Hello,

I'm looking over your code and I'm wondering why you have UserEntity and UserModel. It looks like duplicate code? What's the purpose of this?

Thanks

There is:

const userEntity = await this.userService.getUserEntityByUsername(
      changeEmailRequest.newEmail,
    );

Should be:

const userEntity = await this.userService.getUserEntityByEmail(
      changeEmailRequest.newEmail,
    );

I'm learning to use jest in e2e testing, and I'm finding an error or two :)

To eliminate that warning afterAll function from test/auth.e2e-spec.ts should be put in test/app.e2e-spec.ts file too.
I know it is totally not important :)

sendResetPasswordMail function:

there is:

await this.emailChangeRepository.insert(passwordReset);

should be:

await this.passwordResetRepository.insert(passwordReset);

Describe the bug
For individual users, SendGrid is difficult to be successfully registered. I've tried many times and can't register successfully.

To Reproduce
Steps to reproduce the behavior:
...

Expected behavior
...

Screenshots
...

Desktop (please complete the following information):
...

Smartphone (please complete the following information):
...

Additional context
I highly recommend providing another way to send emails. Thank you for your reading:)

Good morning my friends

About error ocurred

I'm testing this project and the following error is being returned

>
 
node ➜ /workspace/ahmetuysal_nest-hackathon-starter (main ✗) $ ls $(npm bin)
acorn                        jsesc                       rimraf
browserslist                 json5                       schematics
commitlint                   JSONStream                  semver
conventional-commits-parser  js-yaml                     shjs
cross-env                    lint-staged                 terser
cross-env-shell              mime                        tree-kill
detect-libc                  mkdirp                      tsc
escodegen                    nanoid                      ts-jest
esgenerate                   nest                        ts-node
eslint                       node-pre-gyp                ts-node-cwd
eslint-config-prettier       node-which                  ts-node-script
esparse                      nopt                        ts-node-transpile-only
esvalidate                   opencollective              ts-script
git-raw-commits              opencollective-postinstall  tsserver
husky-run                    parser                      uuid
husky-upgrade                prettier                    webpack
import-local-fixture         prisma
jest                         prisma2
 
>
 
node ➜ /workspace/ahmetuysal_nest-hackathon-starter (main ✗) $ npm run start:dev
Debugger attached.

> [email protected] start:dev /workspace/ahmetuysal_nest-hackathon-starter
> dotenv -e env/local.env -- nest start --watch

sh: 1: dotenv: not found
npm ERR! code ELIFECYCLE
npm ERR! syscall spawn
npm ERR! file sh
npm ERR! errno ENOENT
npm ERR! [email protected] start:dev: `dotenv -e env/local.env -- nest start --watch`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the [email protected] start:dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/node/.npm/_logs/2022-01-18T20_49_32_207Z-debug.log
Waiting for the debugger to disconnect...

>

Thanks in advance to everyone who can contribute.

hey, i just like to let you guys know, that in https://github.com/theodorusclarence/expansion-pack/blob/main/dialog-zustand/src/pages/sandbox/dialog-zustand.tsx
the Layout component as outer wrapper is missing, so i was wondering why no dialog was showing.
maybe should be added by default or it should be noted in the install insctructions :)

keep on the good work, love your stack so far!