audiostreamingservice's People
audiostreamingservice's Issues
Production ready solution
There are more popular and supported solutions like https://github.com/mapstruct/mapstruct
Please think about more generic approach (less manual) to mappings if possible.
Code smell
Remove empty lines. Please do some research in google on that problem. Example:
https://www.yegor256.com/2014/11/03/empty-line-code-smell.html
Remove commented out code through all project code.
It's a bad practice to leave commented code in production code.
https://kentcdodds.com/blog/please-dont-commit-commented-out-code
What is it for?
There is the same controller mapping in song-service module. Please explain the application design.
Code is not readable
Remove commented out code
Decorator annotation value is not used?
Please fix. No need to always wrap implementations with ResourceIORetryDecorator and ResourceDBDecorator. Add decoration when it is specified in the annotation.
Think about how to add multiple decorations:
@decorate(decorations = {ResourceIORetryDecorator.class, ResourceDBDecorator.class})
Commented out code
Please complete implementation or remove code that is not used
Please move to the correct package or remove if not needed
Please refactor.
This is important part of the app. Please move it to a separate class.
Security issue
Please secure all endpoints except those that are allowed to be accessed anonymously.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.