agritheory / check_run Goto Github PK

🚨 The automated release from the version-14 branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the version-14 branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

The release 14.1.0 on branch version-14 cannot be published as it is out of range.

Based on the releases published on other branches, only versions within the range >=14.2.2 can be published from branch version-14.

The following commits are responsible for the invalid release:

• feat: check payment entries for cancelled or paid invoices before submitting (#108) (adbca4d)
• V14 ports (#98) (b7adf96)
• chore: fix account names (#99) (7946bdf)
• Merge pull request #90 from alibaig4u/version-14 (5afcfd1)
• The hook jenv is deprecated New variable is jinja (6ef71b7)
• Merge pull request #87 from agritheory/v14_ci (bf296ec)
• ci: fix release correctly on V14 also (3ff2d65)
• ci: remove registry from package.json (607db96)
• Merge pull request #85 from agritheory/v14_fix_release (997c42c)
• ci: fix release CI (9c954d5)
• feat: custom immediate origin value in settings (#76) (813be9e)
• [v14] handle errors in background queue (#72) (1b9b592)
• V14 party lookup (#68) (7f940f3)
• fix: remove check_digit argument in ACH generation (#66) (8476235)
• V14 timeout fix (#64) (825bf70)
• feat: port timeout fix to v14 (#62) (6f50230)
• Bank account lookup fix (#61) (c4357a8)
• feat: fix lookup for non-existient bank account info, improve UX (4ef8a91)
• test: fix net 14 days (3acea48)
• fix: add on hold fixes to query builder (a1e3114)
• test: add payment terms to test data (8b4073e)
• test: add on hold invoice to test data (6867d42)
• feat: add logic for handling on-hold invoices, setting for automatic release and docs (da93c1d)
• docs: add translations page (6e9c977)
• feat: update translations to capture button text (ccc4b67)
• fix: remove undeclared variable reference (6a36c84)
• feat: add Canadian DFI Routing Number validation for bank (b4d9df9)
• feat: add Canadian/GB English translations (1e86c00)
• fix: MOP ignore keypress if input is focused (e073c09)
• ci: update installation and workflows (23c4f83)
• feat: split checks by address (b32f0c9)
• feat: validate docstatus of selected invoices still saved/submitted (#44) (78b3e25)

Those commits should be moved to a valid branch with git merge or git cherry-pick and removed from branch version-14 with git revert or git reset.

A valid branch could be version-13 or version-14.

See the workflow configuration documentation for more details.

Good luck with your project ✨

Your semantic-release bot 📦🚀

This is an existing feature but would benefit from documentation about how to utilize it and what to expect.

... which leads to duplicate payment entries.

Multi-part solution:

• As soon as process_check_run is called
  • Remove the primary action button
  • Freeze the page
  • Set the status to "Submitting"
• Use the __onload hook to check to see if a background job is running for processing any Check Run and if so, don't permit this one to be processed again by setting an __onload flag

There are custom fields that should not belong to Check Run that are being included in the exports
https://github.com/agritheory/check_run/blob/version-14/check_run/check_run/custom/supplier.json#L124

To keep track of documentation topics to add and where they stand:

Using Check Run

• Installation guide (see installationguide.md, README links there, too)
• How it works / what it does (see index.md)
• Key navigation
• Configuring Mode of Payment for Employees and Suppliers (see configuration.md)
• Example data (see exampledata.md)
• Render PDF sequence
• ACH generation
• Example voucher check print format
• Positive Pay (see positivepay.md)
• Check Run Settings
• Permissions:
  • first user on Record feature,
  • only one draft per account/ payable combination allowed,
  • recommended Roles and permissions

Settings

• Include Journal Entries
• Include Expense Claims
• Check overdue items automatically
• Allow cancellation, cascade cancellation to payment entries?
• ACH file options like file extension, more options

Installation Guide

• Production environment steps
• Confirm app works with ERPNext V14 (it doesn't, new issue created to address this)

And for checks, show the split based on the value/default in Check Run Settings

This would be a Vue component ~2/2.5 lines high that floats on the bottom of the page showing the various modes of payment selected and their totals.

(4) ACH/EFT: $1,500.00 | (15/11) Check: $3615.00 | (1) Cash: $100.0

Invoices that are 'On Hold' currently appear in a Check Run

🚨 The automated release from the version-14 branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the version-14 branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

The release 14.1.0 on branch version-14 cannot be published as it is out of range.

Based on the releases published on other branches, only versions within the range >=14.2.1 can be published from branch version-14.

The following commits are responsible for the invalid release:

• chore: fix account names (#99) (7946bdf)
• Merge pull request #90 from alibaig4u/version-14 (5afcfd1)
• The hook jenv is deprecated New variable is jinja (6ef71b7)
• Merge pull request #87 from agritheory/v14_ci (bf296ec)
• ci: fix release correctly on V14 also (3ff2d65)
• ci: remove registry from package.json (607db96)
• Merge pull request #85 from agritheory/v14_fix_release (997c42c)
• ci: fix release CI (9c954d5)
• feat: custom immediate origin value in settings (#76) (813be9e)
• [v14] handle errors in background queue (#72) (1b9b592)
• V14 party lookup (#68) (7f940f3)
• fix: remove check_digit argument in ACH generation (#66) (8476235)
• V14 timeout fix (#64) (825bf70)
• feat: port timeout fix to v14 (#62) (6f50230)
• Bank account lookup fix (#61) (c4357a8)
• feat: fix lookup for non-existient bank account info, improve UX (4ef8a91)
• test: fix net 14 days (3acea48)
• fix: add on hold fixes to query builder (a1e3114)
• test: add payment terms to test data (8b4073e)
• test: add on hold invoice to test data (6867d42)
• feat: add logic for handling on-hold invoices, setting for automatic release and docs (da93c1d)
• docs: add translations page (6e9c977)
• feat: update translations to capture button text (ccc4b67)
• fix: remove undeclared variable reference (6a36c84)
• feat: add Canadian DFI Routing Number validation for bank (b4d9df9)
• feat: add Canadian/GB English translations (1e86c00)
• fix: MOP ignore keypress if input is focused (e073c09)
• ci: update installation and workflows (23c4f83)
• feat: split checks by address (b32f0c9)
• feat: validate docstatus of selected invoices still saved/submitted (#44) (78b3e25)

Those commits should be moved to a valid branch with git merge or git cherry-pick and removed from branch version-14 with git revert or git reset.

A valid branch could be version-13 or version-14.

See the workflow configuration documentation for more details.

Good luck with your project ✨

Your semantic-release bot 📦🚀

This will eliminate the cases (surprisingly frequent) where someone has renamed a supplier after including them in a check run.

Payables Attachments report should also be refactored to use Frappe query builder

With the very lightweight interactions we have with non-Check Run doctypes, we want to move their doc event hooks to hooks.py to make interoperability with third party apps better.

https://python-semantic-release.readthedocs.io/en/latest/

• Mypy (V14)
• Prettier
• frappe/black (tabs)

Supplier group wise show purchase invoice in list view

Payment Terms can more more complex than just the 'due date' field on Purchase Invoices (this feature is not applicable to Expense Claim or Journal Entry). We want to pull in these as separate lines in the Check Run. If a partial or scheduled payment is what is agreed upon with the vendor, we want to respect that. This would most likely be implemented as a subquery in PI query.

Target V14 branch; at this time, we want to start adding features to V14 and not have to do backports unless required.

Checking against draft Check Runs in a before_cancel hook on Purchase Invoice, Expense Claim and Journal Entry.

Preview branch has introduced the inability to delete a file. We should be seeing an 'X' between the lock and PDF icons.

This fix should be applied to version-13 branch and #151

RBC documentation for ACH:
http://www.rbcroyalbank.com/ach/file-889947.pdf

An incomplete list of regionalization effort would be:

• Translating "Check" to "Cheque" wherever appropriate
  • There currently is not a en-CA language in ERPNext. Need to verify if en-GB or en-US is more correct
• Changing the "ABA Number" on the Bank account to "DFI Routing Number", this is more technically correct anyway.
• Additional Validation on Bank Account doctype that this number not exceed 8 characters if a Canadian bank

🚨 The automated release from the version-14 branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the version-14 branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

The release 14.1.0 on branch version-14 cannot be published as it is out of range.

Based on the releases published on other branches, only versions within the range >=14.3.1 can be published from branch version-14.

The following commits are responsible for the invalid release:

• V14 pre process validation (#113) (232beb7)
• feat: check payment entries for cancelled or paid invoices before submitting (#108) (adbca4d)
• V14 ports (#98) (b7adf96)
• chore: fix account names (#99) (7946bdf)
• Merge pull request #90 from alibaig4u/version-14 (5afcfd1)
• The hook jenv is deprecated New variable is jinja (6ef71b7)
• Merge pull request #87 from agritheory/v14_ci (bf296ec)
• ci: fix release correctly on V14 also (3ff2d65)
• ci: remove registry from package.json (607db96)
• Merge pull request #85 from agritheory/v14_fix_release (997c42c)
• ci: fix release CI (9c954d5)
• feat: custom immediate origin value in settings (#76) (813be9e)
• [v14] handle errors in background queue (#72) (1b9b592)
• V14 party lookup (#68) (7f940f3)
• fix: remove check_digit argument in ACH generation (#66) (8476235)
• V14 timeout fix (#64) (825bf70)
• feat: port timeout fix to v14 (#62) (6f50230)
• Bank account lookup fix (#61) (c4357a8)
• feat: fix lookup for non-existient bank account info, improve UX (4ef8a91)
• test: fix net 14 days (3acea48)
• fix: add on hold fixes to query builder (a1e3114)
• test: add payment terms to test data (8b4073e)
• test: add on hold invoice to test data (6867d42)
• feat: add logic for handling on-hold invoices, setting for automatic release and docs (da93c1d)
• docs: add translations page (6e9c977)
• feat: update translations to capture button text (ccc4b67)
• fix: remove undeclared variable reference (6a36c84)
• feat: add Canadian DFI Routing Number validation for bank (b4d9df9)
• feat: add Canadian/GB English translations (1e86c00)
• fix: MOP ignore keypress if input is focused (e073c09)
• ci: update installation and workflows (23c4f83)
• feat: split checks by address (b32f0c9)
• feat: validate docstatus of selected invoices still saved/submitted (#44) (78b3e25)

Those commits should be moved to a valid branch with git merge or git cherry-pick and removed from branch version-14 with git revert or git reset.

A valid branch could be version-13 or version-14.

See the workflow configuration documentation for more details.

Good luck with your project ✨

Your semantic-release bot 📦🚀

I've tested on version-15-beta versions of Frappe, ERPNext, and HRMS. The following issues will need to be resolved:

• Frappe no longer requires PyPDF2. Either port the code to pypdf or explicitly require pypdf2.
• Update to Vue 3.
  If/when you're ready to open a v15 branch, I'd be glad to work on these.

https://frappeframework.com/docs/v14/user/en/api/query-builder

I get this error from JPMorgan Chase when I upload my ACH File:

Batch 1: We can't accept this file because it includes an effective entry date that's in the past or falls on a non-business day. Dates must allow at least 2 days for employee payments, 1 day for vendor payments or 1 day for ACH collections to be processed.

This is because the effective_entry_date and the file_creation_date are both using the getdate() function, and end up the same date. I propose using the check run doc's posting_date for the effective entry date. For people that don't need to customize, it will still be the same as before. For people that do, they can use the "Posting Date" field to set the Effective Entry Date as needed.

I've tested this in my fork and it seems to be working correctly for me. I can create a PR.

Should be defined on a per- Check Run Settings - basis

• Add dependency for HRMS app
• Add new build command (vite/esbuild/ etc)

https://github.com/agritheory/check_run/blob/version-13/check_run/overrides/payment_entry.py#L11

This would let a Payment Entry Reference (completed outside of Check Run ) like "Via ACH" to pass, which then cannot be incremented.

Fix should target both version-13 and version-14 branches.

Also make bank and bank account fields required if payment type == 'electronic'

Remove code that updates this by counting through the Check Run
Offer check number when processing manually and bank account value changes in Payment Entry

🚨 The automated release from the version-14 branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the version-14 branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

The release 14.1.0 on branch version-14 cannot be published as it is out of range.

Based on the releases published on other branches, only versions within the range >=14.5.1 can be published from branch version-14.

The following commits are responsible for the invalid release:

• fix: show purchase returns in check run (#131) (b1cd85b)
• fix: broken translation string in csv (#122) (9c2ded2)
• feat: add validate when processing, enable on_update_after_submit hook (#115) (d58a106)
• V14 pre process validation (#113) (232beb7)
• feat: check payment entries for cancelled or paid invoices before submitting (#108) (adbca4d)
• V14 ports (#98) (b7adf96)
• chore: fix account names (#99) (7946bdf)
• Merge pull request #90 from alibaig4u/version-14 (5afcfd1)
• The hook jenv is deprecated New variable is jinja (6ef71b7)
• Merge pull request #87 from agritheory/v14_ci (bf296ec)
• ci: fix release correctly on V14 also (3ff2d65)
• ci: remove registry from package.json (607db96)
• Merge pull request #85 from agritheory/v14_fix_release (997c42c)
• ci: fix release CI (9c954d5)
• feat: custom immediate origin value in settings (#76) (813be9e)
• [v14] handle errors in background queue (#72) (1b9b592)
• V14 party lookup (#68) (7f940f3)
• fix: remove check_digit argument in ACH generation (#66) (8476235)
• V14 timeout fix (#64) (825bf70)
• feat: port timeout fix to v14 (#62) (6f50230)
• Bank account lookup fix (#61) (c4357a8)
• feat: fix lookup for non-existient bank account info, improve UX (4ef8a91)
• test: fix net 14 days (3acea48)
• fix: add on hold fixes to query builder (a1e3114)
• test: add payment terms to test data (8b4073e)
• test: add on hold invoice to test data (6867d42)
• feat: add logic for handling on-hold invoices, setting for automatic release and docs (da93c1d)
• docs: add translations page (6e9c977)
• feat: update translations to capture button text (ccc4b67)
• fix: remove undeclared variable reference (6a36c84)
• feat: add Canadian DFI Routing Number validation for bank (b4d9df9)
• feat: add Canadian/GB English translations (1e86c00)
• fix: MOP ignore keypress if input is focused (e073c09)
• ci: update installation and workflows (23c4f83)
• feat: split checks by address (b32f0c9)
• feat: validate docstatus of selected invoices still saved/submitted (#44) (78b3e25)

Those commits should be moved to a valid branch with git merge or git cherry-pick and removed from branch version-14 with git revert or git reset.

A valid branch could be version-13 or version-14.

See the workflow configuration documentation for more details.

Good luck with your project ✨

Your semantic-release bot 📦🚀

PR should be for V14 branch only

JPMorgan Chase Bank requires different values for Immediate Destination and Immediate Origin fields in the File Header section of the NACHA file output. They require a value of 0000000000 for Immediate Origin and the Routing Number for the Immediate Destination.

Currently, both values are set in apps/check_run/check_run/check_run/doctype/check_run/check_run.py (lines 593 and 594) to the same variable company_bank_aba_number fetched from the branch_code field of the Bank Account document (line 542):

company_bank_aba_number = frappe.db.get_value('Bank Account', doc.bank_account, 'branch_code')
....
immediate_destination=company_bank_aba_number if not settings.omit_destination else "",
immediate_origin=company_bank_aba_number,

It would be great to accommodate this requirement somehow.

🚨 The automated release from the version-13 branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the version-13 branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

No npm token specified.

An npm token must be created and set in the NPM_TOKEN environment variable on your CI environment.

Please make sure to create an npm token and to set it in the NPM_TOKEN environment variable on your CI environment. The token must allow to publish to the registry https://registry.npmjs.org/.

Good luck with your project ✨

Your semantic-release bot 📦🚀

🚨 The automated release from the version-14 branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the version-14 branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

The release 14.1.0 on branch version-14 cannot be published as it is out of range.

Based on the releases published on other branches, only versions within the range >=14.2.0 can be published from branch version-14.

The following commits are responsible for the invalid release:

• Merge pull request #90 from alibaig4u/version-14 (5afcfd1)
• The hook jenv is deprecated New variable is jinja (6ef71b7)
• Merge pull request #87 from agritheory/v14_ci (bf296ec)
• ci: fix release correctly on V14 also (3ff2d65)
• ci: remove registry from package.json (607db96)
• Merge pull request #85 from agritheory/v14_fix_release (997c42c)
• ci: fix release CI (9c954d5)
• feat: custom immediate origin value in settings (#76) (813be9e)
• [v14] handle errors in background queue (#72) (1b9b592)
• V14 party lookup (#68) (7f940f3)
• fix: remove check_digit argument in ACH generation (#66) (8476235)
• V14 timeout fix (#64) (825bf70)
• feat: port timeout fix to v14 (#62) (6f50230)
• Bank account lookup fix (#61) (c4357a8)
• feat: fix lookup for non-existient bank account info, improve UX (4ef8a91)
• test: fix net 14 days (3acea48)
• fix: add on hold fixes to query builder (a1e3114)
• test: add payment terms to test data (8b4073e)
• test: add on hold invoice to test data (6867d42)
• feat: add logic for handling on-hold invoices, setting for automatic release and docs (da93c1d)
• docs: add translations page (6e9c977)
• feat: update translations to capture button text (ccc4b67)
• fix: remove undeclared variable reference (6a36c84)
• feat: add Canadian DFI Routing Number validation for bank (b4d9df9)
• feat: add Canadian/GB English translations (1e86c00)
• fix: MOP ignore keypress if input is focused (e073c09)
• ci: update installation and workflows (23c4f83)
• feat: split checks by address (b32f0c9)
• feat: validate docstatus of selected invoices still saved/submitted (#44) (78b3e25)

Those commits should be moved to a valid branch with git merge or git cherry-pick and removed from branch version-14 with git revert or git reset.

A valid branch could be version-13 or version-14.

See the workflow configuration documentation for more details.

Good luck with your project ✨

Your semantic-release bot 📦🚀

Version-13 will continue to be supported but will no longer receive new features. New features should be developed against version-14 or version-15 branches. A version-15 branch is planned but won't be started until ERPNext v15 is announced.

Should be a configurable option in Check Run Settings

This covers a case where a vendor requires one check per invoice

I have an ACH-only Check Run document that's been submitted, and when starting a new check run, it is subsequently being considered a draft, so it is loaded instead of starting a new document. I believe this happens because "Submitted" is the final status for this type of document, but check_run.py considers it a draft in the check_for_draft_check_run function:
Line 335: 'status': ['in', ['Draft', 'Submitted']],

"Submitted" could be removed from the list, but I suspect there's a good reason it's there. Also I see an ach_only function in the code that seems to determine if all the transactions in the check run document are ACH. Maybe the code could check for this and if it sees that is the case, create a new document? Or perhaps a new status could be created for ACH check runs called "Downloaded" which would be analogous to "Printed" and would be set on the document when the ACH file is downloaded.

JPMorgan Chase Bank requires the Company Discretionary Data field in the Batch Header be set in the NACHA output file be set to the funding account number. Currently, in apps/check_run/check_run/check_run/doctype/check_run/check_run.py, this is set to a null value in line 580:

company_discretionary_data='',

Would it be possible to either create a field for this or to have the option to use the Bank Account document's bank_account_no field to fill this in the NACHA output file?

🚨 The automated release from the version-14 branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the version-14 branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

The release 14.1.0 on branch version-14 cannot be published as it is out of range.

Based on the releases published on other branches, only versions within the range >=14.3.2 can be published from branch version-14.

The following commits are responsible for the invalid release:

• fix: broken translation string in csv (#122) (9c2ded2)
• feat: add validate when processing, enable on_update_after_submit hook (#115) (d58a106)
• V14 pre process validation (#113) (232beb7)
• feat: check payment entries for cancelled or paid invoices before submitting (#108) (adbca4d)
• V14 ports (#98) (b7adf96)
• chore: fix account names (#99) (7946bdf)
• Merge pull request #90 from alibaig4u/version-14 (5afcfd1)
• The hook jenv is deprecated New variable is jinja (6ef71b7)
• Merge pull request #87 from agritheory/v14_ci (bf296ec)
• ci: fix release correctly on V14 also (3ff2d65)
• ci: remove registry from package.json (607db96)
• Merge pull request #85 from agritheory/v14_fix_release (997c42c)
• ci: fix release CI (9c954d5)
• feat: custom immediate origin value in settings (#76) (813be9e)
• [v14] handle errors in background queue (#72) (1b9b592)
• V14 party lookup (#68) (7f940f3)
• fix: remove check_digit argument in ACH generation (#66) (8476235)
• V14 timeout fix (#64) (825bf70)
• feat: port timeout fix to v14 (#62) (6f50230)
• Bank account lookup fix (#61) (c4357a8)
• feat: fix lookup for non-existient bank account info, improve UX (4ef8a91)
• test: fix net 14 days (3acea48)
• fix: add on hold fixes to query builder (a1e3114)
• test: add payment terms to test data (8b4073e)
• test: add on hold invoice to test data (6867d42)
• feat: add logic for handling on-hold invoices, setting for automatic release and docs (da93c1d)
• docs: add translations page (6e9c977)
• feat: update translations to capture button text (ccc4b67)
• fix: remove undeclared variable reference (6a36c84)
• feat: add Canadian DFI Routing Number validation for bank (b4d9df9)
• feat: add Canadian/GB English translations (1e86c00)
• fix: MOP ignore keypress if input is focused (e073c09)
• ci: update installation and workflows (23c4f83)
• feat: split checks by address (b32f0c9)
• feat: validate docstatus of selected invoices still saved/submitted (#44) (78b3e25)

Those commits should be moved to a valid branch with git merge or git cherry-pick and removed from branch version-14 with git revert or git reset.

A valid branch could be version-13 or version-14.

See the workflow configuration documentation for more details.

Good luck with your project ✨

Your semantic-release bot 📦🚀

Test to include ~150 invoices
Timeout typically happens when submitting takes over a minute and the payment entries are created at a pace of less than one per second but not appreciably.
Probably means we need to add a state for "Submitting" when this is the case and adding a fmr.set_intro that explains that it's generating and no actions can be taken until it completes.

This feature should be accessible in three places:
In every file attachment:

In the Check Run selection pane:

And from a new report "Payables Attachments" - based on the visible columns in the Purchase Invoice Report View, plus a column for attachments. In this view the flyin can be visible all the time.

I get this error from JPMorgan Chase when I upload my ACH File:

Batch 1, Transaction XXXXXXXXX: Please tell us an individual identification number using only letters and numbers because special characters aren't accepted. Remember that identification numbers should never be social security numbers. Please see the Chase file specs for more information. (Error code: 57090)

This is because currently, individual_id_number='' in check_run.py. I propose setting this to pe.party, but stripping non-alphanumeric characters and making it all upper case. I've tested some code to do this in my fork and it's working for me. I can create a PR.

This might be kind of an edge case, though. I'm not sure how many other banks need this field set in the NACHA file. According to the NACHA dev guide it's an optional field. Unfortunately, Chase has decided to make it mandatory for them. Let me know if you think this would be useful to have or not.