Comments (2)
Please sanitize, escape, and validate your POST calls
When you include POST/GET/REQUEST/FILE calls in your plugin, it's important to sanitize, validate, and escape them. The goal here is to prevent a user from accidentally sending trash data through the system, as well as protecting them from potential security issues.
SANITIZE: Data that is input (either by a user or automatically) must be sanitized. This lessens the possibility of XSS vulnerabilities and MITM attacks where posted data is subverted.
VALIDATE: All data should be validated as much as possible. Even when you sanitize, remember that you don’t want someone putting in ‘dog’ when the only valid values are numbers.
ESCAPE: Data that is output must be escaped properly, so it can't hijack admin screens. There are many esc_*() functions you can use to make sure you don't show people the wrong data.
To help you with this, WordPress comes with a number of sanitization and escaping functions. You can read about those here:
https://developer.wordpress.org/plugins/security/securing-input/
https://developer.wordpress.org/plugins/security/securing-output/
Remember: You must use the most appropriate functions for the context. If you’re sanitizing email, use sanitize_email(), if you’re outputting HTML, use esc_html(), and so on.
Clean everything, check everything, escape everything, and never trust the users to always have input sane data.
Example(s) from your plugin:
Agora-Word-Press/admin/class-agora-channels-list-table.php:86: $args['s'] = $_REQUEST['s'];
Agora-Word-Press/admin/class-wp-agora-io-admin.php:205: isset( $_GET['page'] ) ? trim( $_GET['page'] ) : '',
Agora-Word-Press/admin/class-wp-agora-io-admin.php:210: $id = isset( $_POST['post_ID'] ) ? $_POST['post_ID'] : '-1';
from agora-wordpress.
New instances have been flagged by WP during the plugin review.
from agora-wordpress.
Related Issues (20)
- [BUG] Time-Sensitive: Location in code to change "Microphone Unmute" icon HOT 5
- How to Broadcast? HOT 1
- Only the broadcaster should be shown? HOT 9
- [BUG] Toggle fullscreen does not work on iPhone Safari HOT 1
- [FEATURE] Is there any way to create dynamic channel in wordpress? HOT 1
- [BUG] Screen Share fails on Safari 13.1.1 on branch 3.0.0.beta HOT 3
- Modular Approach HOT 2
- [BUG] cannot live on wordpress HOT 5
- Special Build needed HOT 2
- [BUG] After upgrading to latest versions of Agora plugin, videos no longer working HOT 7
- [BUG] URGENT - Audio and Disconnect Problems with Broadcast Channel HOT 1
- [BUG] Hosts cannot see Broadcast viewer's chat questions HOT 8
- [BUG] Chat window is cropped off -Horizontal mobile view HOT 4
- [BUG] S3 Cloud recording HOT 8
- [BUG] Several Black Rectangles Appearing HOT 5
- [BUG] Problems persist with Chat Window HOT 3
- [BUG] Screen Share HOT 1
- [BUG] Screen Share fails on Safari
- [BUG] Update to 2.0.8 and Agora no longer works on mobile devices - CRITICAL HOT 6
- Plugin doesn't capture entire camera? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from agora-wordpress.