Code Monkey home page Code Monkey logo

Comments (8)

sushain97 avatar sushain97 commented on May 20, 2024 1

@agoldis https://github.com/sushain97/web2fs-notepad/blob/issue-25/webpack.config.js

from webpack-require-from.

sushain97 avatar sushain97 commented on May 20, 2024 1

The solution works for me and the documentation looks good as well! The only note I have is that since window isn't supported in a web worker, self is required instead: sushain97/web2fs-notepad@06b3ece#diff-028b78cada5fa9a59260b989f3b86ffeR52. The URL needs to be passed from the main thread to the web worker as a message (might be useful to note this as well).

Thanks for your fast (and great) work!

from webpack-require-from.

agoldis avatar agoldis commented on May 20, 2024 1

Great, I will roll out a new npm release later this week

from webpack-require-from.

agoldis avatar agoldis commented on May 20, 2024 1

Resolved by https://github.com/agoldis/webpack-require-from/releases/tag/v1.8.0

from webpack-require-from.

agoldis avatar agoldis commented on May 20, 2024

Hi @sushain97! Thanks for discovering and reporting that issue!
Could you please share the webpack version you're using and may be a minimal reproducable example of the code.
Also, did you try to use other options, e.g. https://github.com/agoldis/webpack-require-from#replacesrcmethodname?

EDIT: Seems like the plugin doesn't support webworkers use case, I will need to implement it. I will keep you posted, prob won't take long

from webpack-require-from.

sushain97 avatar sushain97 commented on May 20, 2024

Awesome! Thank you for investigating (and taking up the enhancement).

FTR, my resolved Webpack version is 4.16.5.

from webpack-require-from.

agoldis avatar agoldis commented on May 20, 2024

@sushain97 Can you please share your webpack config

from webpack-require-from.

agoldis avatar agoldis commented on May 20, 2024

@sushain97 That was an interesting problem!

Would appreciate if you try to use

yarn add https://github.com/agoldis/webpack-require-from.git#next

and follow the instructions https://github.com/agoldis/webpack-require-from/tree/next#web-worker

Although I've validated the feature and implemented a test, I'd like to make sure it is clear how to use the pluging and support your use case.

There's also a working example https://github.com/agoldis/webpack-require-from/tree/next/example

I am waiting for your feedback regarding:

  1. The documentation and instructions
  2. Whether the solution is working for you

from webpack-require-from.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.