agelito / wimp-intellog Goto Github PK

I've made a branch with some improvements to the README.md file. Filing this issue for the PR.

Is your feature request related to a problem? Please describe.
The project changelog generation is based on conventional commits. It's hard to manually review that all PR's title and description matches conventional commits.

Describe the solution you'd like
Add automatic verification of PR's content matching conventional commits using GitHub actions.

Rename the cancellationToken parameter in LogWatcherServiceRunner to stoppingToken to match the base class declaration.

With the support for watching multiple channels a new configuration field was added. We need to update the README.md file to reflect these changes and also make users aware of the old single channel name field maybe being deprecated in the future.

Describe the bug
Since the application have in memory default configuration we don't have to keep the Config.json file in repository. Doing this reduces risk of any sensitive or deployment specific information being publicly accessible.

To Reproduce
Steps to reproduce the behavior:

1. Clone project
2. See Config.json file in project root

Expected behavior
No Config.json in project root after cloning.

Describe the bug
When running the application there's a lot of system log output. It would be better to only display information log messages and above coming from application code (instead of system code).

To Reproduce
Steps to reproduce the behavior:

1. Download release build v1.0.0
2. Run the build
3. Post messages in intel channel (or dummy test file)
4. See multiple log messages for each POST request made.

Expected behavior
Only see log output about warnings or errors.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows
• Version 10

currentFile object could be null on this line:
LogWatcherService.cs:79: fs = new FileStream(currentFile.Path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);

This would be an issue in rare cases where all observed files suddenly disappear.

Is your feature request related to a problem? Please describe.
In some cases corporations or alliances have multiple intel channels for different regions. It would be great if the application can track and process log messages from each channel.

Describe the solution you'd like

• Change configuration to allow passing an array of chat channel names.
• Instantiate a file observer for each chat channel name and process messages from each one.

Describe alternatives you've considered
Another possible alternative would be to launch one application with a different configuration for each chat channel. This alternative seems much harder to manage for the users.

Additional context
N/A

Describe the bug
When reading the EVE chat logs the file is opened in Unicode encoding instead of UTF8 encoding.

Expected behavior
Open the files in UTF8 encoding mode.

Is your feature request related to a problem? Please describe.
It might be hard for users to configure the eve log directory path.

Describe the solution you'd like
By allowing environment variables in the path a sane default can be provided.