africanlii / liiweb Goto Github PK

See the attached image. For consolidations imported without retrospective Gazette research, include the consolidation date (for Uganda - 31 Dec 2000) as a point on the Legislation timeline of the individual acts. Discussed with Edith and she suggests that the change should happen on LIIweb rather than Indigo (i.e. NOT make consolidation date a point in time on Indigo)

https://namiblii.org/akn/na/act/1961/25/eng@1996-07-15 is as at 15 July 1996

but the banner says This is the version of this legislation as it was from 1972-02-01 to 1972-02-01.

Some of our works have very long names, eg. "Application of the provisions of section 18 of the Native Administration Proclamation, 1928 (Proclamation 15 of 1928) (South-West Africa), and of the regulations published under Government Notice 70 of 1954 (South-West Africa) in the Territory of South-West Africa" - see https://edit.laws.africa/works/na/act/gn/1974/r192/

Can this field be expanded, or do we need to truncate the title?

The HTML for an expression may contain image links, such as <img src="media/foo.png">. This should show the correct foo.png file associated with the expression. Different expressions for the same work may have different foo.png files, and different works may also have files named foo.png.

A url such as https://example.com/akn/za/act/2009/5/eng@2019-01-01/media/foo.png would be ideal. However, if necessary, we can also rewrite the media urls easily. So we could use a different prefix such as https://example.com/files/media/akn-za-act-2009-5-eng-2019-01-01/foo.png.

So two key requirements:

• files need to be scoped to the expression with which they're linked
• the images need to be able to load via normal html img tags

Add this CSS to the legislation SCSS file:

@keyframes fadeout {
  from { background-color: yellow; }
  to { background-color: none; }
}

.akoma-ntoso :target {
  animation: fadeout 2s;
}

Click on either of the two judgments https://new.ulii.org/judgments/UGSC/1981 and error appears

The website encountered an unexpected error. Please try again later.
TypeError: Argument 1 passed to Drupal\liiweb\LiiWebUtils::getLatestFrbrUriForNode() must implement interface Drupal\node\NodeInterface, null given, called in /app/web/modules/custom/liiweb_api/src/PathProcessor/LiiWebPathProcessorAlias.php on line 44 in Drupal\liiweb\LiiWebUtils->getLatestFrbrUriForNode() (line 134 of modules/custom/liiweb/src/LiiWebUtils.php).

Make the call-outs on each PIT version on the timeline of this historical version of legislation: https://namiblii.org/akn/na/act/1995/13/eng@2017-08-21

linked to the document, as it is done in the latest version https://namiblii.org/akn/na/act/1995/13/eng@2021-02-09

When first deploying (before the database is setup), the first deployment fails because the postdeploy script runs and tries to interact with the database.

We could add a config setting that disables the scripts on the first deployment?

• static pages
• node detail pages

References

• https://www.drupal.org/docs/develop/using-composer/preparing-your-site-for-composer-2
• https://www.drupal.org/node/3132977

Mimic a page such as https://gazettes.africa/gazettes/na-government-gazette-dated-2009-09-28-no-4345

It is easy to accidentally add a number in the judgment number override box. The box should be moved to another tab, or a checkbox added next to it to add another step before the automatic judgment number assignment is overridden.

Basic judgment detail page, modelled on https://namiblii.org/na/judgment/high-court/2009/128

• Don't worry about "more like this"

Let's mirror the existing namiblii page structure for now:

1. court name listing (https://namiblii.org/courtnames/)
2. clicking on a court shows alphabetical and year-based listings (https://namiblii.org/courtnames/high-court)
3. by year: https://namiblii.org/courtnames/high-court/2019
4. alphabetical: https://namiblii.org/courtnames/high-court/g

The detailed layout will be adjusted once we have these pages.

When POSTing a file to /jsonapi/node/government_gazette/XXX/field_file, the server returns a 500 response:

LogicException: The controller result claims to be providing relevant cache metadata, but leaked metadata was detected. Please ensure you are not rendering content too early. Returned object class: Drupal\Core\Cache\CacheableResponse. in Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (line 154 of /Users/greg/coding/laws.africa/liiweb/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php).

• Disabling the filefield_paths module for that field removes the issue.
• This occurs whether we use s3 storage or local storage.
• Occurs if I create a single file field on another content type
• Does NOT occur on the legislation content type's multiple file field

Do we need file field paths for this field? Can we turn it off? Can we fix this?

As a user of legislation, I would like to easily view the section number in addition to the heading of a section in the TOC of legislation. Legislation is cited with a section number more frequently than with the full section heading

Include section number in the TOC of legislation, so each link to a section is preceded with the section number

• Basic footer, modelled on the mockup
• Links to other LIIs vertically (not horizontally)
• Contact information, etc.

Error: Call to undefined method Drupal\liiweb_api\Controller\LiiWebEntityResource::getNodeFromFrbrUri() in Drupal\liiweb_api\Controller\LiiWebEntityResource->post() (line 77 of

• needs test for API

• solr server
• search box in navbar
• search box on homepage
• search results page

If this page is complex to put together, then we may want to delay it (or make it very simple) until we can implement a richer design.

The listing page should by alphabetised like the existing one: https://namiblii.org/namibia-legislative-works-index

• exclude stub = True
• exclude parent_work is not null

https://namiblii.org/akn/na/act/1999/2/eng@1999-03-19 shows banner for "1999/22".

When I query the service with correct Accept header:

curl --fail -H "Accept: application/vnd.api+json" -u user:pass http://example.com/akn/za/act/1900/00/eng@1900-01-01

The call fails with 403, however when I'm sending application/json it works:

curl --fail -H "Accept: application/json" -u user:pass http://example.com/akn/za/act/1900/00/eng@1900-01-01

I did some debugging without success, also found few issues might help:

• https://www.drupal.org/project/jsonapi_aliases/issues/3014810
• https://www.drupal.org/project/drupal/issues/2664876 (and related links inside)

The site contains a legislation node type. A piece of legislation can change over time, and we store the different legislation versions as different Drupal revisions for a node. A developer wrote an adjustment to the Drupal REST API to allow us to read and update the revisions easily. Without the REST API, we cannot update historical versions of a piece of legislation.

The API is documented here: https://github.com/africanlii/liiweb/tree/master/docs/jsonapi

A specific URL format allows us to update different versions. For example:

• http://liiweb.test/akn/za/act/1900/00/eng@1900-01-01 -- this is the english (eng) version of act "00" of "1900" (.../act/1900/00/...) at the date 1900-01-01 (1 Jan 1900).
• http://liiweb.test/akn/za/act/1900/00/eng@1920-02-02 -- this is the same as the above, but at date 1920-02-02.

We associate a PDF version of each piece of legislation. Each historical version has its own PDF version.

We upload a PDF in two steps (see documentation here):

1. upload the file to get a file ID
2. attach the file to an existing node

The files are stored in S3.

The bug

When we try to attach a file to an existing node (step 2), we get this error:

LogicException: The controller result claims to be providing relevant cache metadata, but leaked metadata was detected. Please ensure you are not rendering content too early. Returned object class: Drupal\jsonapi\ResourceResponse. in Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (line 154 of /app/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php).

You can follow the instructions at https://github.com/africanlii/liiweb/tree/master/docs/jsonapi#attaching-files-to-an-expression to reproduce the bug

Integrate development workflow with Travis

After we are done with setting-up a single instance we can look over managing multiple instances from the same repository

Basic homepage modelled on https://namiblii.org/

• include 5 most recent gazettes
• include 5 most recent judgments
• include 5 most recently updated pieces of legislation (exclude stubs)

There's no reason to have drupal core committed to the repo. It can be installed with composer like everything else.

We probably want to look at removing it from the full repo history, too, to slim down the repo size.

See also #136

The FRBR URIs need to be integrated in Drupal, so that when nodes are rendered in any context (i.e. views, search etc.) they are rendered as links to their FRBR URI.

• Current revisions of nodes create via API will inherit the FRBR as URL alias
• URL handler pattern to server the correct node / revision
• Write tests which invokes API and creates works and expressions and test the URIs are correct

Remove pagination from year pages in gazettes view

Doing a GET or an api-based PATCH to an FRBR URI returns a 404.

It works for an FRBR URI such as:

/akn/za/1993/3/eng@1993-01-03

but not

/akn/za/act/1993/3/eng@1993-01-03

Note that the first example isn't a valid FRBR URI, whereas the second one is.

If possible, I suggest that the URI-matching code looks for /akn/ and then just blindly tries to find a matching node in the database. Parsing the FRBR URIs is complicated, because there are a number of optional parts to it. eg. /akn/za/act/1993/3, /akn/za-cpt/act/by-law/1993/3 and /akn/za-cpt/act/gn/1993-02-01/3 are all valid.

Links to other legislation cited should point to namiblii versions of legislation.
e.g. in https://new.namiblii.org/akn/na/act/gn/2020/233/eng@2020-10-21#defn-term-hospital
Act No. 36 of 1994 should take us to the https://namiblii.org/akn/na/act/1994/36 (or the new.namiblii.org equivalent for now) @longhotsummer

When creating a records via API, add an example how to properly populate the 'field_content' field.

• setup server
• configure schema

Currently the support in Drupal core to create translations and revisions is limited. There is a 3-years old discussion on how to implement this in JSON APIs with no clear solution foreseen since it has implications to the Drupal core: mainly because it is difficult to handle all edge cases in a generic way. Moreover, now JSON API is part of the Drupal core and we cannot just patch the module because it may block future core (security) updates.

Therefore the solution suggested is to create our own custom REST endpoint which allows handling both multilingual an revisions according to the project needs. Later, if there's another solution provided by the Drupal core, these endpoints can either be removed or preserved as a thin layer between the external tool and core REST API. Even so, the solution provided would be lightweight since it will handle exactly our use-case and it doesn't require to be generic.

References:

• https://www.drupal.org/project/drupal/issues/2794431
• https://www.drupal.org/docs/8/modules/jsonapi/translations
• https://www.drupal.org/node/2135829
• https://www.drupal.org/project/jsonapi

Filefield paths are incorrectly showing as temporary
See Download PDF from https://ulii.org/ug/judgment/court-appeal-uganda/2019/8 leads us to https://ulii.org/system/temporary?file=filefield_paths/2019-ugca-8.pdf

Eg: https://openbylaws.org.za/za-cpt/act/by-law/2015/ombudsman/eng@2015-07-03/

See https://github.com/laws-africa/openbylaws.org.za/blob/master/_includes/work_notices.html

Data required:

• latest expression?
• in force to

Using the API example twice I can create two works with same FRBR URI

|  16 | /node/42                      | /akn/za/1993/31/eng@1993-01-31 | en       |
|  17 | /node/43                      | /akn/za/1993/31/eng@1993-01-31 | en       |

Older cases are being added on the platform and it is difficult for users to find them as there is no sorting or indication on the actual documents that allows a view into the most recently added cases. Devise a UI to resolve this.

The clipboard should contain the correct citation information for the section/legislation being cited.

For example, see https://openbylaws.org.za/za-cpt/act/by-law/2010/air-quality-management/eng/ and the source at https://github.com/laws-africa/openbylaws.org.za/blob/master/_includes/work_notices.html

We will need to understand how to use the field_repeal_work relationship to fetch the FRBR URI and title of the repealing work, and then link to it.

Please use a basic bootstrap danger alert.

Hide the Body field in Full view display and replace with a PDFjs view of the PDF. Keep the Download PDF link as it currently is

Affected: Individual gazette page e.g. https://ulii.org/gazettes/ug-government-gazette-dated-2017-04-07-no-21

The current core version 8.8.1 is not covered by security updates. From my past experience update to 8.9.* most likely requires to update also the contrib modules.

Stubs , such as https://new.ulii.org/akn/ug/act/2020/11/eng@2020-07-27
import the link to the publication document (gazetted legislation) - adjust the view of the individual legislation content type to include that PDF and to display to the user under the timeline banner.

https://docs.google.com/document/d/1pytBOq4qeitcODcRuRwFlZ85HEuL0bb3Q5RaOvUlmVQ/edit#

• itemise content fields and types in documentation
• steps on how to create in UI
• export configuration and store in github

Implement PDF.js view on judgment nodes without text