afred / interloper Goto Github PK

Done when README.md has examples of how to use .inherit_callbacks_before and .inherit_callbacks_after.

Background: this is happening when .inherit_callbacks_for :some_method is called in a child class, but only one of the before or after callbacks is defined in the parent. This causes the child class to end up with a callback that is nil.

Done when: child class can call inherit_callbacks_for :some_method where only the before (or after) callback is defined in the parent, and it will inherit the defined callback without throwing a LocalJumpError: no block given.

Callbacks are being called for anonymous subclasses generated with test_class_factory method in our tests, but once we try to use non-anonymous classes, any callbacks defined on a subclass are not being called.

Done when: callbacks defined on a subclass are called, when the subclass and it's parent have actual constant names (i.e. are not anonymous).

One use case for this is when you want to log an error or warning under certain circumstances when a method is called, but you only want to log it on the first time, and not on every subsequent time.

This could be implemented either with a parmeter, or as a new class method...

# as a parameter
before(:foo, times: 1) do
  # ...
end

# as a class method...
once_before(:foo) do
  # ...
end

Done when: can run a callback just once for a given method call.

Done when:

• make sure types of params and return values are enclosed in square brackets.
• add @private to methods that don't need to be doc'd (i think this is how it works anyway).