afrase / kodiswift Goto Github PK

@sinap Please see and fix comments made by @thongld here
0254115

Currently, playable items can't play due to is_folder always returning true, even if is_folder is set to false and playable to true.

Thanks

Add to pypi https://pypi.python.org/pypi?%3Aaction=search&term=kodiswift&submit=search

The fix https://codecov.io/gh/Sinap/kodiswift/compare/8d715c01091da3952d8eb625420889732e5b4b84...18184ee1072af31726ed43a4740e57ed3adc79a4?src=pr from #6 fixed one part. But there is still an issue with another part of the code.

The error is:

22:49:02 T:140138852108032   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                         - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                        Error Type: <type 'exceptions.AttributeError'>
                                        Error Contents: 'list' object has no attribute 'as_tuple'
                                        Traceback (most recent call last):
                                          File "/home/sander/.kodi/addons/plugin.video.intergalacticfm/addon.py", line 168, in <module>
                                            plugin.run()
                                          File "/home/sander/.kodi/addons/script.module.kodiswift/lib/kodiswift/plugin.py", line 307, in run
                                            items = self._dispatch(self.request.path)
                                          File "/home/sander/.kodi/addons/script.module.kodiswift/lib/kodiswift/plugin.py", line 335, in _dispatch
                                            resp = self.finish(items=resp)
                                          File "/home/sander/.kodi/addons/script.module.kodiswift/lib/kodiswift/xbmcmixin.py", line 471, in finish
                                            self.add_items(items)
                                          File "/home/sander/.kodi/addons/script.module.kodiswift/lib/kodiswift/xbmcmixin.py", line 384, in add_items
                                            tuples = [item.as_tuple() for item in _items]
                                        AttributeError: 'list' object has no attribute 'as_tuple'
                                        -->End of Python script error report<--

The line https://github.com/Sinap/kodiswift/blob/master/kodiswift/xbmcmixin.py#L384 may only work for whem item is really a tuple. Fixing this will help at least three plugins that are/were using xbmcswift2 before and migrate to kodiswift.

I was adding "poster","Landscape" ... supporting to xbmcswift2, before I saw your fork

Please let http://kodi.wiki/view/Add-on:Kodiswift be created automatically by the KODI maintainers and get updated automatically too.

Since kodiswift is propose for development of addons it will be great to be able to:

• download all dependencies specified from addon.xml to specific folder
• ability to download from different repositories

Main goal of this feature to run kodiswift cli without import issues

There are many situations that we need both is_playable = False and is_folder = False in an item as describe here. For example, without that feature, kodiswift will get into trouble when working with proxy streaming like f4mTester as describe here

And then next lines are:

2022-09-12 22:17:41.860 T:2291131200  NOTICE: [kodiswift] Request for "/video/%2Fudalosti-ludka-stanka%2Fputin-je-pry-taky-jen-clovek-cte-motivacni-citaty-a-pripravuje-se-na-hudebni-vystoupeni-v-metru" matches rule for function "video"
2022-09-12 22:17:42.892 T:3011904896   ERROR: Playlist Player: skipping unplayable item: 0, path [plugin://plugin.video.mall.tv/video/%2Fudalosti-ludka-stanka%2Fputin-je-pry-taky-jen-clovek-cte-motivacni-citaty-a-pripravuje-se-na-hudebni-vystoupeni-v-metru]

Anything I can do please?

Sorry to post here, but I'm curious if this project is still alive, since the last commit was 2017. If not, are there any alternatives you know?

Thanks!

Add ability to build package for Kodi. As a result it will be zip file of addon which can be installed to Kodi

Hi,
there are some PRs adding compatibility with Kodi 19 Matrix waiting for few months. Is there any plan to add support for (just released) Kodi 19 into this project?

Or should we migrate ours plugins to something else and forget about kodiswift? What is your recommendation?

the is_playable option does not set an item as a file as it should.

https://github.com/Sinap/kodiswift/blob/cb4cac4022daa638ee614aa0a24a16d02d259647/kodiswift/listitem.py#L306 <- this line is missing listitem.is_folder = False

I've been writing pretty much all of my addons with xbmcswift and as you, have noticed that jbel has gone awol 2-4 years ago =)

I needed some features today that where in PR's against jbel (and not in pr's from few other forks) and noticed that you have been active recently on updating xbmcswift (and renaming it to kodiswift). One worry about this: older addons don't get fixes/new features without small rewrite.. Understandable approach but, yeah, can lead to frustrations =)

Anyway, my question: how soon you will be considering of trying to get kodiswift to be merged to official repos ?

It seems set_resolved_url does nothing

I would like to refactor some plugins away from xbmcswift2 to kodiswift as to fix a bug such as DamonToumbourou/plugin.video.c31#1

When will kodiswift be part of de the default Kodi repository so that a dependency on it will install it by default?