afischbacher / nhl.api Goto Github PK

Just started using this package, first of all, fantastic job, very easy to use.

I'm looking to get player stats by year, it seems like the 3rd party API supports getting stats for a specific player.
https://github.com/dword4/nhlapi#people

Could this request be supported here also?

It would be really excellent if the plays from the live feed included the players that were on the ice at the time of the play. This can be determined by pulling in data from:

https://api.nhle.com/stats/rest/en/shiftcharts?cayenneExp=gameId=${gamePk}

Having the team strength (5v5, 5v4, etc.) could also be gleamed from this data.

I like that there is the live updating on the LiveGameFeedResult class, but this should at least be configurable to turn off, or slow down. I have certain use cases where I'm pulling in the live feed to download shot data and I don't need live updating. I do have another case where the live updating is nice, but 250ms is way too fast. If this could be fixed ASAP, that would be excellent.

Currently, there are a couple of methods to get the current day's schedule and by date. There are a few additional endpoints that the NHL API exposes for getting schedules. In particular I'm looking to use the endpoint that gets the schedule for a particular season in order to know what games to download for that season.

It would be cool to enhance player statistics to include faceoffs won (FOW) as it is used quite often in Yahoo Fantasy Leagues.

Currently as a workaround I need to iterate over all games and check the boxscore and calculate on my own.

Today the nuget package stopped working and it looks like that NHL changes API endpoint.

https://gitlab.com/dword4/nhlapi/-/issues/110#note_1572143580

(We spoke on Reddit about this and you requested I open an issue)

The previous API endpoints for retrieving live game data included a datetime field for each event. The newest endpoints don't seem to provide this information anymore. Examples below.

This makes it impossible to chronologically sort events across several games, for example.

Thank you!

Example of old event shape:

{
  "result": {
    "eventCode": "ANA89",
    "eventTypeId": "HIT",
    "description": "Tomas Nosek hit Adam Henrique",
    "event": "Hit"
  },
  "players": [
    {
      "playerType": "Hitter",
      "player": {
        "link": "/api/v1/people/8477931",
        "fullName": "Tomas Nosek",
        "id": 8477931
      }
    },
    {
      "playerType": "Hittee",
      "player": {
        "link": "/api/v1/people/8474641",
        "fullName": "Adam Henrique",
        "id": 8474641
      }
    }
  ],
  "about": {
    "eventIdx": 123,
    "dateTime": "2023-01-09T02:42:01Z",   <------------------------------------------------
    "eventId": 89,
    "period": 2,
    "periodType": "REGULAR",
    "ordinalNum": "2nd",
    "periodTime": "04:13",
    "periodTimeRemaining": "15:47",
    "goals": {
      "away": 2,
      "home": 1
    }
  },
  "coordinates": {
    "x": 32,
    "y": -39
  },
  "team": {
    "name": "Boston Bruins",
    "link": "/api/v1/teams/6",
    "id": 6,
    "triCode": "BOS"
  }
}

Example of new event shape:

{
  "eventId": 57,
  "period": 1,
  "periodDescriptor": {
    "number": 1,
    "periodType": "REG"
  },
  "timeInPeriod": "00:25",
  "timeRemaining": "19:35",
  "situationCode": "1551",
  "homeTeamDefendingSide": "left",
  "typeCode": 509,
  "typeDescKey": "penalty",
  "sortOrder": 13,
  "details": {
    "xCoord": -94,
    "yCoord": 23,
    "zoneCode": "O",
    "typeCode": "MIN",
    "descKey": "tripping",
    "duration": 2,
    "committedByPlayerId": 8478493,
    "drawnByPlayerId": 8481564,
    "eventOwnerTeamId": 30
  }
}