afbora / kirby-blade Goto Github PK

View Code? Open in Web Editor NEW

20.0 3.0 5.0 2 MB

Enable Laravel Blade Template Engine for Kirby 3

License: MIT License

PHP 100.00%

kirby kirby-cms kirby3-plugin kirby-plugin kirby-blade blade laravel view template template-engine

kirby-blade's People

Stargazers

Watchers

Forkers

apecave deptrai21 lukasleitsch

kirby-blade's Issues

Usign with content representation

NotFoundException (error.template.default.notFound)

Add support for snippet templates

Currently only blade templates that are present in the configured template directory (/templates by default) are compiled. Is it possible to support compiling templates from the snippets directory too?

All of the snippets are basically really short templates, they're just organized elsewhere. Right now, my template templates are in beautiful blade syntax and my snippet templates are still wrapper in hard to read php tags

Template views using dot notation don't work

Hey there,
I'm used to name templates & stuff in dot notation, eg there's blog.article, blog.audio & blog.video for different formats of blog entries. Their templates would would be named blog.article.php etc, their content files blog.article.en.txt etc BUT when using your plugin, naming the template (= view) something like blog.article.blade.php doesn't work, because ..

.. line 86 in src/Template.php throws an InvalidArgumentException:

# src/Template.php
# line 86 be like:
$html = $this->blade->make($this->name, $data)->render();  # boom!

Here's an example from a page where the template name contact.press cannot be found:

3.7 Compatibility

Option `doMakeSameDomainsLinksRelative` requires array, not boolean

Hey there,
when looking at voku/htmlmin options, it's clear that doMakeSameDomainsLinksRelative is the only option receiving an array (not a boolean like the others). Therefore, it's logical that passing true / false inside config.php throws a TypeError:

I'd suggest passing every option 'as-is', or at least check for $option == 'doMakeSameDomainsLinksRelative' 😕

Cheers,
S1SYPHOS

Removing HTML Minify

I'm thinking of removing the HTML minify feature to make it work more stable. What do users of the plugin think? 👀

Redeclared function error

I have Kirby and kirby-blade both installed via composer:

"require": {
    "php": ">=7.1.0",
    "afbora/kirby-blade": "^1.7",
    "getkirby/cms": "^3.0"
},

I've got a markdown file with a title, and the default blad template is outputting <h1>@page('title')</h1>

When I run my dev server I get the following error:

Fatal error: Cannot redeclare e() (previously declared in /Users/[username]/Work/[repo]/vendor/illuminate/support/helpers.php:252) in /Users/[username]/Work/[repo]/kirby/config/helpers.php on line 160

Any ideas how this is happening and how I might get around it?

Is it possible to register/use components?

Is it possible to register/use components? Like here https://laravel.com/docs/7.x/blade#components ?

Illuminate\View\View::__toString()

It's almost impossible to debug when it fails

Custom directives only receive one argument

I've tried defining a custom directive in the config file, however the closure only ever receives one argument.

    'afbora.blade.directives' => [
        'test' => function ($foo, $bar) {
            return "bar:($bar) foo:($foo)";
        }
    ],

Usage:

@test('baz', 'quaz')

This results in the error:

ArgumentCountError thrown with message "Too few arguments to function Kirby\Filesystem\F::{closure}(), 1 passed and exactly 2 expected"

If I make the second argument optional function ($foo, $bar = null) then I get this output:

bar:() foo:('baz', 'quaz')

You see the second $bar properly is empty and $foo contains the string 'baz', 'quaz'

Illuminate/Kirby redeclaring the `e()` function

Just installed this plugin, I can't even load a page (any page), because there is a conflict with the e() function between Kirby and Illuminate.

PHP Fatal error:  Cannot redeclare e() (previously declared in /---/vendor/illuminate/support/helpers.php:607) in /---/kirby/config/helpers.php on line 162

I have absolutely no idea how to deal with this.

Thank you

New Test

New Test #5 by Ahmet Bora

Test

Broken HTML minification

Hey there,
when turning on HTML minification, I get the following ParseError: syntax error, unexpected token ")"

When disabling HTML minification, everything works fine and behaves as expected (great plugin, thanks <3).

Now, even when just using <html></html> and nothing else. I know that it originates somewhere in symfony/css-selector and I can't figure out which ) and where it comes from - but it's certainly not from within my HTML being passed to kirby-blade.

Use Laravel Blade templates in Plugin

We have developed a custom blocks plugin, it would be very handy if we could also store the default blade templates inside the plugin. Thank you.

Improvement HTML minify

New Feature

New Feature #4 by Ahmet Bora

Test

Minify HTML

Autoloading order with composer

https://getkirby.com/docs/guide/plugins/plugin-setup-basic#the-index-php

No stack trace when errors are thrown

The errors that blade throws are often useless because there is no real stack trace. Although there is no real stack trace it will produce a hint as to which view had the error in the top level error but only if you use a laravel directive to include it. If you use a kirby snippet() helper you will only see an error with no stack trace and a reference to the blade template that called it.

afbora / kirby-blade Goto Github PK

kirby-blade's People

Stargazers

Watchers

Forkers

kirby-blade's Issues

Recommend Projects

Recommend Topics

Recommend Org