aexolate / ped Goto Github PK

The header is Location persons by tag: filter, but it appears that the filter command works on other attributes other than tags as well. Perhaps the header could be changed to reflect the flexibility of the filter command?

e.g. filter e/bernice works even if it is not a tag

Entering command compareCalendars A B C does not result in any error and the command prompt shows RuntimeException is encountered.

The UI shown in the quickstart is drastically different from the actual UI of the application. That might be abit confusing to the readers.

The viewContactEvents command example showed deleteEvent instead

The filter command allows searching by name already. The find command seems redundant as it behaves like filter, except for the name attribute only.

filter n/Alex and filter n/Alex Yeoh was able to find the Alex Yeoh person the same way as find Alex and find Alex Yeoh.

The provided example in the UG does not work as it does not follow the format stated. Perhaps the example should be changed to fit the format given?

The UI does not show all the events added. Perhaps a scrollbar could be added to allow all the events to be viewed? Otherwise it is difficult to see what events are there.

Reproduction Steps:

1. Add a few events

Result: The event list is truncated

The calendar does not occupy the full width of its sub-window. It would be nicer if the calendar extended its width all the way to make full use of the space :)

The provided example compareCalendar 1 3 5 doesn't work, but compareCalendars 1 3 5 works. Perhaps the user guide should provide a working example?

Format: sortTasks PARAMETER
PARAMETER can only be DESCRIPTION or DEADLINE.

Sort persons : sort
Sorts all persons by specified comparator.
Examples:
    sort /byname sorts all contacts in UniMate address book by the full name of Person

According to the UG, although both are sorting functionalities, their format is very different. It might be easier for the users if they follow the same format, e.g.

sortTasks /bydescription
sort /byname

or

sortTasks DESCRIPTION
sort NAME

The sort command could also potentially have been named sortPerson to differentiate it from the tasks sorting.

addEvent d/Nap ts/2023-11-05 12:00 te/2023-11-04 12:00

The above command follows the stated format of yyyy-MM-dd HH:mm, but an error is still thrown. The error is likely being thrown as the start time is later than the end time, but the error message suggests it is a datetime formatting issue.

The provided format and example command for clearEvents does not work. Was it meant to be clearEvents ts/....?

The user guide does not make it clear how the sort command is used. For example, what is a comparator? and what comparators are available to be used? The UG only shows two examples /byname and /byaddress.
Perhaps it would be good to list out the available comparators in a table :)

In order to clear events, the whole command has to be retyped again.

1. clearEvents ts/2020-02-03 12:00 te/2099-02-03 14:00
2. clearEvents ts/2020-02-03 12:00 te/2099-02-03 14:00 c/CONFIRMED

It was quite time consuming to retype the whole command and would have been more convenient to use if I only had to type c/CONFIRMED or c/DECLINE for example instead of retyping the entire command.

It was also faster for me to use my mouse and copy the command output box than retype the command, making it not really optimized for CLI users.

The usage of the filter command is inconsistent between the main feature list and the command summary. The command summary seems to be the incorrect one.

sort was one of the command listed in the user guide, but missing in the command summary

The ellipsis from the event text exceeds the 'time slot box' when the event time period is very small.

Reproduction Steps:

1. addContactEvent 1 d/Team Meeting ts/2023-11-03 01:01 te/2023-11-03 01:02
2. Double click on first person to open their calendar view
3. The above issue will appear

To reproduce the error, enter the command compareCalendars without any INDEX. The program does not throw any error and the command prompt shows RuntimeException was encountered.

Input: addContactEvent 5 d/Team Meeting ts/2023-11-04 00:01 te/2023-11-04 00:01
Result:
The start date and time and end date and time should be in the format 'yyyy-MM-dd HH:mm' where: -'yyyy' is the year. -'MM' is the month. -'dd' is the day. -'HH:mm' is the time in 24-hour format.

The user guide does not seem to indicate that the START_DATE_TIME must be strictly greater than END_DATE_TIME. But the application has the constraint. Perhaps it could be added into the UG, or the behaviour of the application changed so the start and end time could be the same?