Code Monkey home page Code Monkey logo

Comments (2)

Yogu avatar Yogu commented on September 2, 2024 1

Thanks for your feedback. You're correct, the rootValue is currently not propagated. It makes sense to propagate the rootValue to endpoints without namespace declaration, like in your example. Does your use case also include endpoints with namespaces? I think it would still be a good idea to set the rootValue in the GraphQLResolveContext, but what about source? Should it be set to the rootValue`? Should we just try to access a field on the rootValue with the same name as the namespace on the endpoint?

from graphql-weaver.

moret avatar moret commented on September 2, 2024

hmm... in my particular case only the "old" schema, which has no namespace declaration, would use a rootValue, the other weaved schemas with namespaces are from upstream services, so the rootValue is not really useful to them. But I can imagine that other people might try to weave local schemas that implement patterns such as the one DataLoader per request with namespaces. Using fields with the same name on the rootValue sounds good.

from graphql-weaver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.