Comments (3)
We remove types that are neither rechable through a field, nor are implementations of reachable interfaces. This is the implementation. Thus, it would be expected to lose types that not reachable at all. Would this apply for _FileLink
and _ImageLink
? I could also imagine that it's broken for implementations of interfaces that are in turn only used in implementations of interfaces, or something similar.
Could you post the SDL / type definitions for the relevant types? I'm not quite sure how to read your syntax with _implementations:
etc.
from graphql-weaver.
@Yogu I think the issue is here:
graphql-weaver/src/pipeline/namespaces.ts
Line 25 in c7f7a34
We need to also provide types types: Object.values(schema.getTypeMap())
With this everything works fine
from graphql-weaver.
Oh, so the NamespaceModule
does not use transformSchema
at all. I guess your fix should be fine - we only wrap the root types (and reuse the old types as the field types), so we don't need to delete unused types here.
Could you submit a pull request with this change? A testcase also would be awesome, maybe you could just copy the interfaces
regression test (along with interfaces.graphql
and interfaces.result.json
) and add a namespace
to the endpoint config. If not, a PR with just the fix would also be cool :)
from graphql-weaver.
Related Issues (20)
- Misbehavior for scalar type , maybe an edge case ? HOT 5
- Woven Schemas lose their astNodes HOT 2
- Directives, especially and primarily, default ones, get duplicated for each schema HOT 1
- Linked field returns null when using linkFieldName HOT 6
- Create a schema from already weaved schemas
- Documentation on links, pipelines, fieldMetadata and more insufficient
- Apollo's schema stiching
- LaunchPad graphql endpoints no longer available HOT 1
- Support `skip` argument with @join
- woking with uploads via apollo-upload-server HOT 1
- Launchpad example broken
- Links return an error when recommendation service sets typePrefix HOT 7
- [FEATURE REQUEST]: Ability to include HTTP headers HOT 1
- Authenticating User at API Gateway and then redirecting them to microservices HOT 7
- How to rename fields properly?
- GraphQL 15 compatibility HOT 1
- Cannot read property 'map' of undefined (link issue with undefined variableDefinitions)
- Upgrade graphql-tools dependency to 6.x.x
- Change introspectionQuery to getIntrospectionQuery
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-weaver.