adzialocha / angular-swipe Goto Github PK

Can't get ng-click to fire on an element that also has ng-swipe-up directive from this module.

Adding the noPreventDefault class to the element did not help.

One of our projects failed to run properly after we found out that the 0.0.5 tag was removed from this repository. Would it be possible to restore that tag, and preserve any other tags for posterity?

If you really want to support bower properly, you need to add semver tags to the git repository, such as v0.0.4, v0.0.5. This will make life of consuming projects easier as pointing to SHAs or #master can lead to issues.

Please consider adding this as part of your release process if you want this module to be consumed by 3rd party projects.

Hi,
to start thanks for your work and your share.

I looked at your directive and choose to use it but can'install it by bower

2 case and same result.

case 1 : I put "angular-swipe": "https://github.com/marmorkuchen-net/angular-swipe.git" in my bower.json and then by terminal i got this :

bower install angular-swipe
bower not-cached https://github.com/marmorkuchen-net/angular-swipe.git#*
bower resolve https://github.com/marmorkuchen-net/angular-swipe.git#*
bower checkout angular-swipe#v0.0.5
bower resolved https://github.com/marmorkuchen-net/angular-swipe.git#0.0.5
bower ENOTFOUND Package angular-swipe not found

case 2 : I replace by "angular-swipe": "https://github.com/marmorkuchen-net/angular-swipe.git#master"

bower install angular-swipe
bower not-cached https://github.com/marmorkuchen-net/angular-swipe.git#master
bower resolve https://github.com/marmorkuchen-net/angular-swipe.git#master
bower checkout angular-swipe#master
bower resolved https://github.com/marmorkuchen-net/angular-swipe.git#5418174204
bower ENOTFOUND Package angular-swipe not found

I never register a project with bower so i just suppose that your directive name is not registered anymore by bower.

Can you give a look, until then I will download it with the zip.

BTW, what I am trying to achieve is to swipe up and down a nav bar at the bottom of the screen, it would be nice if I could make the animaion synchronize with the swipe event, but like it doesn't seems possible to set an animation currentValue, I am not sure to achieve completely what I expect

Thanks for your time :)

Please add a license to the project. Not specifying a license means that you automatically reserve all rights and no projects are allowed to rely on this module, except your own of course.

Hi there! How can i disable the mouse events and use them only on devices with touchscreen? Thank you!

The $swipe service still detects only left/right swipe, is this the intended behaviour?

The noPreventDefault solution does not work consistently on my phone app. There is a clickable div nested in the swipeable parent element and the "workaround" only works after a page refresh once have already loaded. For the moment I have removed prevent default behaviour from the source as my own workaround.

The docs clearly state to support Angular >= 1.3, however dependencies in bower.json are set to 1.3.x, only. Are there any known issues with Angular 1.4 or is that dependency marker wrong?

ngTouch also has ng-swipe-left and ng-swipe-right, and that results in triggering the functions twice.

Adding angular-swipe to bower.json as specified on README page leads to an error:

bower ECMDERR       Failed to execute "git ls-remote --tags --heads [email protected]:marmorkuchen-net/angular-swipe.git", exit code of #128

Adding it like this actually worked:

"angular-swipe": "marmorkuchen-net/angular-swipe"

Hello!

How are you?
How can I install it via npm?

This: https://www.npmjs.com/package/angular-swipe looks like another one... Although you have a package.json ....

Thanks,
Patrik

Thanks for your work on this. I recently start working with it and came across something weird. On applying a ng-swipe-up or ng-swipe-down I can't select input fields within that element. Remove and it works. Works fine to with ng-swipe-left/right.

For elements where I only want to enable swipe left/right, how do I disable swipe up/down?

Putting any of the ng-swipe-* directives on the same element as an ng-click directive will result in both the click and the swipe event to be fired when the user swipes. I would expect that only the swipe event would be fired.

Hi @adzialocha ,

we're using this package for quite a while now and we are very satisfied. After updating our application to angular 1.6, we get some bower warnings with your packge.

angular-swipe#0.2.0 depends on angular#~1.5.x which resolved to angular#1.5.11

Do you plan to update the angular-dependencies in the near future?

Cheers!

The contents of app.js are appended to angular-swipe.min.js which is creating a global variable app which conflicts with a default Phonegap project.

Hi marmorkuchen-net,

I am trying to call a function when I swipe down, however, it is not working for some reason. I followed the directions provided by the README and I can see that I even have 'angular-swipe' in my bower_components. I was wondering if you have any suggestions on how to get the swipe down and swipe up to work.

Here is how I am calling ng-swipe-down

div ng-swipe-left="nextImg()" ng-swipe-right="previousImg()" ng-swipe-down="dismissImg()" class="modal-content">

The ng-swipe-left and ng-swipe-right work fine. In my dismissImg() I just have an alert() to test.

$scope.dismissImg = function() {
//jQuery to press a esc key
alert("TESTING");
};

for instance, if i got a very long div, when use ng-swipe-up directive , i want to see the details on the end of div, it will not move the long div up.