adzap / grouped_validations Goto Github PK

www.dropbox.com/s/5565jhuv1zz6j1x/%D0%A1%D0%BA%D1%80%D0%B8%D0%BD%D1%88%D0%BE%D1%82%202013-10-07%2004.58.44.png

Any chance this gem could be compatible with Rails 4?

Any plans of supporting this with Rails 5? Are there any alternatives?

Currently, the last bit of the Usage section reads:

To define validation blocks just use the respective group validation method, like so

class Person < ActiveRecord::Base
  validation_group :name do
     validates_presence_of :first_name
     validates_presence_of :last_name
  end

  validate_name           {|r| # something custom on save }
  validate_name_on_create {|r| # something custom on create }
  validate_name_on_update {|r| # something custom on update }
end

But unless I am seriously mistaken, it should be more like:

To define validation blocks just include a custom 'validate' method within the validation group, like so

class Person < ActiveRecord::Base
  validation_group :name do
    validates_presence_of :first_name
    validates_presence_of :last_name
    validate           {|r| # something custom on save }
    validate_on_create {|r| # something custom on create }
    validate_on_update {|r| # something custom on update }
  end
end

Rails 4.0.1
Ruby 2.0.0-p247

I defined a group called :offer in my Quote model.

validation_group :offer do
validates_presence_of :initials
end

When I start the console and test the following:

[1] pry(main)> q = Quote.new
[2] pry(main)> q.valid?
NoMethodError: undefined method _run_validate_offer_callbacks' for #<Quote:0x00000101da89a8> from /Users/peter/.rvm/gems/ruby-2.0.0-p247/gems/activemodel-4.0.1/lib/active_model/attribute_methods.rb:439:inmethod_missing'

Same happens for q.groups_valid?(:offer)

I noticed that it works when you replace:
send(:"_run_validate_#{group}_callbacks")
with:
run_callbacks(:"validate_#{group}")

But I don't know if it's the proper way.

Looks like in some cases _run_validate_callbacks does not populate the @errors ivar so you end up with a nil value in the grouped errors hash.

Should change to use the errors getter method as that will create an empty Errors object

Passing a condition for the options argument results in an ArgumentError (wrong number of arguments (2 for 1)). This happens on Rails 3.0.5, using v0.2.2 of the gem.

validation_group :address, :if => address_required? do
    validates :address, :postal_number, :postal_address, :presence => true
end

def address_required?
    true
end

RubyGems.org doesn't report a license for your gem. This is because it is not specified in the gemspec of your last release.

via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

Including a license in your gemspec is an easy way for rubygems.org and other tools to check how your gem is licensed. As you can imagine, scanning your repository for a LICENSE file or parsing the README, and then attempting to identify the license or licenses is much more difficult and more error prone. So, even for projects that already specify a license, including a license in your gemspec is a good practice. See, for example, how rubygems.org uses the gemspec to display the rails gem license.

There is even a License Finder gem to help companies/individuals ensure all gems they use meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough issue that even Bundler now generates gems with a default 'MIT' license.

I hope you'll consider specifying a license in your gemspec. If not, please just close the issue with a nice message. In either case, I'll follow up. Thanks for your time!

Appendix:

If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file), GitHub has created a license picker tool. Code without a license specified defaults to 'All rights reserved'-- denying others all rights to use of the code.
Here's a list of the license names I've found and their frequencies

p.s. In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :). See the previous link or my blog post about this project for more information.