adrianolek / aotranslationbundle Goto Github PK

It can happen in some situations (when the translatable string is determined at runtime) that a null value is passed to the translator.

I consider this a bug because this doesn't crash the default Symfony translator: {{ null|trans }}.

The error presents itself on the db level: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'identification' cannot be null.

Null ids should be skipped. I will prepare a PR with fix when have the time.

When a message belonging to at least two caches is added then TranslationListener crashes with unique constraint violation database error. Probably some other circumstances cause the problem to manifest (it doesn't alway manifest). Couldn't reproduce clearly but narrowed it down to TranslationListener. The new cache was being added to message's relation even if it was already present.

Transchoice doesn't work if locale isn't set explicitly because null locale is passed to Symfony\Component\Translation\MessageSelector which does not determine the default locale on its own.

Adding this code:

if (!isset($locale)) {
    $locale = $this->getLocale();
}

to the top of AO\TranslationBundle\Translation\Translator::transChoice fixes the problem but is not the prettiest solution.