Code Monkey home page Code Monkey logo

nostalgic-tweaks's People

Contributors

adrenix avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

nostalgic-tweaks's Issues

[FORGE] Game crashing after trying to edit settings

Version Information

Minecraft Version: 1.20.1
Forge Version: (NeoForge 47.1.96)
Nostalgic Tweaks Version: 2.0.0 Beta 8.4.1

Describe the Bug

When I attempt to open the settings, the game just crashes

Crash Report

crash-2024-02-01_18.23.57-client.txt

Bug Context

The game was fine yesterday, I have no idea why this is happening now, I did not add any mod or modify any file.

Screenshots

If applicable, add screenshots to help explain your problem.
N/a

[FABRIC] 1.19.4 crashes on startup `java.lang.ExceptionInInitializerError`

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.19.4
Fabric Loader Version: 0.14.19
Fabric API Version: 0.78.0
Nostalgic Tweaks Version: 2.0.0-Beta-8.3

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

Game crashes on startup

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

latest.log

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

N/A

Screenshots

If applicable, add screenshots to help explain your problem.

[FABRIC] Crashing on startup with BetterNether installed

Hi, I am experiencing a startup crash with Nostalgic Tweaks when BetterNether (https://www.curseforge.com/minecraft/mc-mods/betternether) is installed. I have included two different crash reports, as the game displayed a crash report for both BetterNether and Nostalgic Tweaks, and they seem to be related.

Nostalgic Tweaks:
https://gist.github.com/Kaede4Life/42af51e7d11e7f81aa3e58bfff8d9bc9

BetterNether:
https://gist.github.com/Kaede4Life/63b0d8d970bef5c5d7a9321cd2f43c0c

[FABRIC] Nostalgia Tweaks seems to be incompatible with a mod/mods from Better Minecraft modpack

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.18.2
Fabric Loader Version: 0.14.9
Fabric API Version: 0.58.0
Nostalgic Tweaks Version: 1.0.5

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

The game console log gets spammed with constant error messages.
Some parts (chunks) of the world stop loading in, they do not refresh and cause the game to become unresponsive.

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

https://mclo.gs/tm0E1px

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

I believe it might be caused by some mods from the Better Minecraft/ Better MC modpack although I am not sure which.
It has to be mods that either do changes to biomes or other terrain features.
Additional mods I put into my mods folder are: Create and Ad Astra although without them the problem still occurs

Screenshots

If applicable, add screenshots to help explain your problem.

obraz

Inconsistency with old 2D floating items

Some items do not render as 2D items when dropped. In my limited testing it appears to be blocks such as slabs, stairs, trapdoors, pressure plates, buttons, and other transparent blocks. Testing was done with a fresh fabric install with only Nostalgic Tweaks installed.

Experience/Hunger labels don't respect hud hiding option when current screen isn't null

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.19
Nostalgic Tweaks Version: 2.0-beta3

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

When the hud is hidden the Experience/Hunger labels are hidden, but when you go to the pause screen they are not hidden

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

N/A

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

N/A

Screenshots

If applicable, add screenshots to help explain your problem.
image

[FORGE] The game crashes when Splash Potions are thrown when this mod is installed

Version Information

Minecraft Version: 1.20.1
Forge Version: Latest release for 1.20.1
Nostalgic Tweaks Version: NostalgicTweaks-1.20.1-Forge-2.0.0-Beta-8.4.1

Describe the Bug

Whenever a Splash Potion is thrown, there is a chance that the game will crash due to being unable to render it properly. It can be from a player, Witch, or any modded entity that uses Splash Potions.

Crash Report

The report states that Nostalgic Tweaks is susceptible for causing the crash.
https://pastebin.com/kTcTngp8

Bug Context

I was fighting a group of Zombies and a Witch in hopes of trapping the Witch in a boat in order to have a way to cure Zombie Villagers without the need to go to The Nether. Since I have an Enhanced AI installed, the Witch threw splash potions at the Zombies to buff them while she kept her distance. She threw Fire Resistance (which is not even necessary due to Mob Sunscreen being installed) and Regeneration. She threw a third potion, but the game crashed before I could see it. The game crashed again as soon as I opened the world again. This also happens when I use Splash Potions sometimes in Creative Mode.

Screenshots

N/A

[FABRIC] Create puts game into infinte mojang logo Loop

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.18.2
Fabric Loader Version: 0.15.3
Fabric API Version: 0.77.0
Nostalgic Tweaks Version: 2.0.0-Beta-8.4

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

It seems to happen with Create Fabric only, since disabling it made it work.

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

N/a (the game does not crash)

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

N/a (Happens at Mojang logo)

Screenshots

If applicable, add screenshots to help explain your problem.

image

With Create

image

Without Create

Other information

I am using Windows 8.1 Pro and the Launcher I am using is ATLauncher

Other mods are architectury, lazy-language-loader, lazydfu and sodium.

[FABRIC] Health bar displaced

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.19.3
Fabric Loader Version: 0.14.18
Fabric API Version: 0.76.0
Nostalgic Tweaks Version: 2.0.0-Beta-8.2

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

For some reason the health bar is displaced

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

Mods:

Architectury
Cloth Config V9
CustomSkinLoader
EntityCulling-Fabric
Fabric API
FerriteCore
Indium
Iris
Lithium
Mod Menu
Modern Beta Fabric
Nostalgic Tweaks (disabling fixed the health bar)
Sodium
ViaFabricPlus

I have confirmed that it is not a resource pack as after disabling all of them it remained

Screenshots

image

[FABRIC] [QUILT] Crash on entering the world

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.19.4
Fabric Loader Version: quilt 0.19.1
Fabric API Version: qfapi
Nostalgic Tweaks Version: 0.83.0 beta-9

Describe the Bug

crash on entering the world, console says something about nostalgic_tweaks and getmobcap

Crash Report

https://mclo.gs/MihVqVz

Bug Context

crash on entering the world

Screenshots

[FABRIC] and [FORGE]

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.19.x - 1.20.x
This issue also appears in both the Forge and Fabric versions.

Describe the Bug

Basically, the OLD_DAMAGE_ARMOR_TINT feature works well, HOWEVER, if you were to have an enchanted piece of armor on and then take damage, your armor's enchantment glint would not be showing during that moment of damage.

The Fix

I also ran into this issue while making the same feature in my mod after being inspired by Nostalgic Tweaks, and well, I actually really like Nostalgic Tweaks, so I feel very inclined to share the fix. In order to fix this, you should replace "getEntityCutoutNoCull" with "getEntityCutoutNoCullZOffset" (taken from yarn mappings). This fixed the issue for me.

Screenshots

Here are some screenshots for further proof.

In the first screenshot, the glint is clearly missing while taking damage. In the second image, the glint is visibly there whilst taking damage.
no_glint
yes_glint

[FABRIC] LunarClient Compatibilty

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.20.1
Fabric Loader Version: N/A
Fabric API Version: N/A
Nostalgic Tweaks Version: 1.20.1-Fabric-2.0.0-Beta

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

Game Crashing during launch

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

[2024-02-14 13:38:09.037] [info] java.lang.ClassCastException: class net.minecraft.client.gui.screens.AccessibilityOnboardingScreen cannot be cast to class com.moonsworth.lunar.RCICCIHHORIHRRIOICRCOIHRR.ORCOOCHOHOIOCCCHROHROCRHI.IOHHIIRCOCOHOHRIRHCORIOCI.ICOCOHCCRCHCHCRHROIOHORCO (net.minecraft.client.gui.screens.AccessibilityOnboardingScreen and com.moonsworth.lunar.RCICCIHHORIHRRIOICRCOIHRR.ORCOOCHOHOIOCCCHROHROCRHI.IOHHIIRCOCOHOHRIRHCORIOCI.ICOCOHCCRCHCHCRHROIOHORCO are in unnamed module of loader 'Genesis' @31428f76)
[2024-02-14 13:38:09.038] [info] at Genesis//net.minecraft.client.Minecraft.handler$zzg000$impl$setScreen(SourceFile:3265)
[2024-02-14 13:38:09.038] [info] at Genesis//net.minecraft.client.Minecraft.setScreen(SourceFile)
[2024-02-14 13:38:09.038] [info] at Genesis//net.minecraft.client.Minecraft.setInitialScreen(SourceFile:688)
[2024-02-14 13:38:09.038] [info] at Genesis//net.minecraft.client.Minecraft.(SourceFile:674)
[2024-02-14 13:38:09.039] [info] at Genesis//net.minecraft.client.main.Main.redirect$zbd000$impl$main$minecraft(SourceFile:639)
[2024-02-14 13:38:09.039] [info] at Genesis//net.minecraft.client.main.Main.main(SourceFile:211)
[2024-02-14 13:38:09.039] [info] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[2024-02-14 13:38:09.039] [info] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
[2024-02-14 13:38:09.040] [info] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
[2024-02-14 13:38:09.040] [info] at java.base/java.lang.reflect.Method.invoke(Unknown Source)
[2024-02-14 13:38:09.040] [info] at com.moonsworth.lunar.genesis.ClientGameBootstrap.apply(Unknown Source)
[2024-02-14 13:38:09.041] [info] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[2024-02-14 13:38:09.041] [info] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
[2024-02-14 13:38:09.041] [info] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
[2024-02-14 13:38:09.041] [info] at java.base/java.lang.reflect.Method.invoke(Unknown Source)
[2024-02-14 13:38:09.042] [info] at com.moonsworth.lunar.genesis.IOHHIIRCOCOHOHRIRHCORIOCI.RCICCIHHORIHRRIOICRCOIHRR(Unknown Source)
[2024-02-14 13:38:09.042] [info] at com.moonsworth.lunar.genesis.Genesis.run(Unknown Source)
[2024-02-14 13:38:09.042] [info] at com.moonsworth.lunar.genesis.Genesis.main(Unknown Source)

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

N/A

Screenshots

If applicable, add screenshots to help explain your problem.

[FORGE] improve mod compatiblity by cancelling forge events

Version Information

Minecraft Version: 1.20+

Describe the Bug

Nostalgic Tweaks directly sets fog near and far plane distance via RenderSystem calls, rather than let Forge's event system handle this by properly cancelling the fog event, and setting the event's near and far plane distance. This leads to issues with other mods that expect these values to pertain to the actual fog, such as AlexModGuy/AlexsCaves#781.

Bug Context

https://github.com/Adrenix/Nostalgic-Tweaks/blob/1.20/common/src/main/java/mod/adrenix/nostalgic/util/client/FogUtil.java#L170
Direct calls to RenderSystem bypass the forge event's setFarPlaneDistance() and setNearPlaneDistance(), meaning that any other mod which expects these values to return the start and end of the fog will recieve old, incorrect results. I propose you change the return type of the FogUtil methods to return the three wanted values, and use event's setters rather than set them directly.

[FABRIC] Lighting bug in the overworld

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.20.1
Fabric Loader Version: 0.14.23
Fabric API Version: 0.88
Nostalgic Tweaks Version: 2.0.0

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

When it's night outside, the overworld seems to act fullbright. This wasn't an issue in a earlier version of Nostalgic Tweaks. Grass renders fine for some bizarre reason. Underground also seems to act fine as well, so idk whats going on.

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

n/a

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

n/a

Screenshots

If applicable, add screenshots to help explain your problem.
2024-01-02_00 49 45

[FABRIC/FORGE] Old Water Lighting Doesn't Spread Skylight Change

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.19.2
Nostalgic Tweaks Version: 2.0.0

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

Water blocks don't spread their new skylight filter to neighboring blocks.

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

N/a

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

In the image, it looks like the air pockets are emitting light. The air blocks are not emitting light, but instead what's happening here is that the air blocks have a higher skylight value than the neighboring water blocks. This is what makes it look like the air blocks are emitting light. This happens due to the way I've implemented old water lighting.

When the game goes to retrieve a skylight value from the light engine for a water block, I swap out the skylight level with a new calculated skylight value based on what is above the water block. The problem with this is that this only applies to the water block requesting a skylight value. I don't know if it's possible to re-calculate neighboring blocks after chunk rendering. And if there is a solution to this issue, I would imagine it would require another rendering pass after creating a cache of blocks to re-render that would be impacted by water blocks using some type of flood algorithm.

There are a few things to note about any offered solution. First, the solution should keep the tweak client side. Second, if the solution comes at a performance cost, then it may be necessary to split the fix as its own tweak so that the user can decide if they're willing to live with the performance hit to avoid the visual glitch. Lastly, the solution must avoid the first implementation of this tweak.

When I first developed this tweak, I used to change the skylight filter amount saved on disk. This fixed the issue shown here, but caused other problems and wouldn't allow the tweak to work on servers without the mod installed. So I would prefer that any offered solution avoids regressing back to my original implementation.

Screenshots

If applicable, add screenshots to help explain your problem.
Image

[FABRIC] Old Torch Brightness tweak cannot be loaded

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.19.3
Fabric Loader Version: 0.14.17
Fabric API Version: 0.75.1+1.19.3
Nostalgic Tweaks Version: 2.0.0 Beta-8.2

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

The "Old Torch Brightness" tweak has no effect, with the red exclamation mark showing that it has not loaded.

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

N/a

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

It is not caused by mod incompatibility as the issue persists even after removing all mods other than the dependencies (fabric api & architectury), all lighting and torch tweaks have been turned on apart from old classic light rendering.

Screenshots

If applicable, add screenshots to help explain your problem.
2023-03-04_21 15 55
2023-03-04_21 18 57
2023-03-04_21 19 19
2023-03-04_21 15 09

[FORGE] Crash with vampirism

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.18.2
Forge Version: 40.2.8
Nostalgic Tweaks Version: forge 2.0.0 beta 0.8.3

Describe the Bug

Game crashes everytime i right-click the Altar of Inspiration from Vampirism with a Blood Bottle

Crash Report

https://mclo.gs/2vmZkKJ

Bug Context

The game crashes, when i try to advance in vampirism, after i right click the altar of inspiration from vampirism my game crashes, that only happens if i have nostalgic tweaks enabled. I've tried playing only with the two mods and my game crashed.

Screenshots

N/A

[FABRIC] Crash on startup in IDE

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.20.1
Fabric Loader Version: 0.15.2
Fabric API Version: 0.91.0+1.20.1
Nostalgic Tweaks Version:1.20.1+fabric+2.0.0-beta-8.4.1

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

The client loads all resources and then crashes without the window popping up

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

Caused by: java.lang.RuntimeException: Mixin transformation of net.minecraft.client.gui.widget.ClickableWidget failed
Caused by: java.lang.RuntimeException: Ambiguous Mixin: method lookup method_25365 (Z)V is not unique
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinPreProcessorException: Attach error for mixin.nostalgic_tweaks-common-widen.json:AbstractWidgetAccessor from mod nostalgic_tweaks during activity: [Attach method -> NT$setFocus(Z)V]
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered

(https://gist.github.com/PlanetNINE-Dev/223a49a99827d22fef25183a1a7885af)

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

N/a

Screenshots

If applicable, add screenshots to help explain your problem.

[FABRIC] Game crashes upon joining server

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.18.2
Fabric Loader Version: 0.4.11
Fabric API Version: 0.75.1
Nostalgic Tweaks Version: 2.0.0-Beta-8.4

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

The mod crashes my game upon joining a server, but not upon joining a singleplayer world. The server is my own, running Bukkit. I am using the mod on default settings, with Architectury version 4.11.93.

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

N/A.

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

N/A.

Screenshots

If applicable, add screenshots to help explain your problem.
N/A.

[FORGE] Visual Overhaul Incompatibility: Crash on Settings GUI Button Press

Minecraft Version: 1.20.1
Forge Version: 47.2.19
Nostalgic Tweaks Version: 2.0.0-Beta-8.4.1

Steps to Reproduce

  • Install versions above
  • Install Visual Overhaul (5.0.1)
  • Load the game, enter the mods screen
  • Enter Nostalgic tweaks config screen
  • Pressing the Settings button causes a NullPointerException.

Describe the Bug

Crash on pressing a button on the settings screen if Visual Overhaul is installed.

java.lang.NullPointerException: Cannot invoke "mod.adrenix.nostalgic.client.config.reflect.TweakClientCache.getValue()" because "this.tweak" is null
at mod.adrenix.nostalgic.client.config.gui.widget.button.BooleanButton.m_6035_(BooleanButton.java:42) ~[NostalgicTweaks-1.20.1-Forge-2.0.0-Beta-8.4.1.jar%23162!/:?] {re:classloading}
at eu.midnightdust.visualoverhaul.IconicButtons.init(IconicButtons.java:30) ~[visualoverhaul-forge-5.0.1.jar%23163!/:?] {re:mixin,re:classloading}
at eu.midnightdust.visualoverhaul.IconicButtons.(IconicButtons.java:27) ~[visualoverhaul-forge-5.0.1.jar%23163!/:?] {re:mixin,re:classloading}

A Visual Overhaul mixin is causing BooleanButton to contain a null TweakClientCache tweak member.

Crash Report

Cause of the bug

VO adds custom Icons to GUI Buttons, they seem to be using Mixins to do so.
I did not test pressing other buttons, but they probably also crash.
Disabling the Button icons in VOs config does not fix the crash (Mixins are not disabled on config settings)

It also shows the "saving chunks" screen bedore crashing, although I don't think that's relevant.

[FABRIC] Crashes with Extended Clouds 1.2.0

Version Information

Minecraft Version: 1.19.2
Fabric Loader Version: 0.14.9
Fabric API Version: 0.60.0
Nostalgic Tweaks Version: 1.2.0

Describe the Bug

Crashes randomly ingame.

Crash Report

Link

Bug Context

Joined a world with Extended Clouds and Nostalgia Tweaks, and the game crashed after a few seconds.

Screenshots

N/A

[FORGE] The player cannot eat if they have a shield in their offhand with classic food enabled (No hunger and food restore HP)

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.20.1
Forge Version: Latest release of Forge for 1.20.1
Nostalgic Tweaks Version: NostalgicTweaks-1.20.1-Forge-2.0.0-Beta-8.4.1.jar

Describe the Bug

The title states it all. Players cannot eat food if they have a shield in their offhand with the classic food system enabled. Players have to unequip their shield to eat. Is this an intended feature or bug? I find it a little annoying, especially since I have this mod installed alongside Sculk Horde, a mod that makes a shield necessary for survival.

[FABRIC]

Bro i cant sprint with the slow mod in minecraft.

[FABRIC] Classic item damage bar tweak breaks overrides to `Item.getBarColor`

Version Information

Minecraft Version: 1.20.1
Fabric Loader Version: 0.14.22
Fabric API Version: 0.87.0
Nostalgic Tweaks Version: v2.0.0 Beta 8.4

Describe the Bug

When using the classic item damage bar colours tweak, items which override damage-bar related methods (Im assuming its Item.getBarColor, but might also affect others like Item.getBarWidth?) are busted, usually resulting in an entirely empty bar, but sometimes not! sometimes its entirely filled and green, depends.

Crash Report

N/a

Screenshots

Tweak disabled.
Four golden shovels, an AE2 Entropy Manipulator, a Tech Reborn Basic Drill, two vanilla bundles, and an AE2 Matter Cannon.
image

Tweak enabled.
image

AE2's bars always seem to be at the empty stage...
image

...While Tech Reborn's seem to be largely always filled, except for some of the battery items which always appear empty
image

Tweak disabled for reference:
image

image

Edit: Just checked and the old damage bar tweak doesn't even touch Item.getBarColor directly as it i guess is just drawing the old-style bar graphics over the modern one?
I think the easiest fix would be to draw the old bar background parts, check if the item type overrides getBarColor, and return if it does before drawing the new coloured part. Maybe keep a map of itemtypes that do so too because idk how expensive the reflection is?

[FORGE] Old Lighting Rendering displays light levels 4 to 1 as light level 0.

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.18.2
Forge Version: 40.1.80
Nostalgic Tweaks Version: 1.0.7

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

The title describes pretty much the whole thing. I've noticed that the lighting coming from a block source of light ends very harshly. I then disabled the old lighting rendering to see if it was the case with vanilla lighting, which it wasn't as you can see in the screenshots below.

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

N/a

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

The first screenshot displays vanilla lighting at night time with lighting coming from a lantern. The second one is is the same except with old lighting rendering enabled. The third screenshot shows the F3 menu while standing on a block that should have a block lighting of 4, but it looks the exact same as light levels 3 to 0. The fourth screenshot is just the bug at display from a farther distance with the brightness set to 100%. In every other screenshot it was set to 0%.

Screenshots

2022-10-09_13 27 24
2022-10-09_13 27 37
2022-10-09_13 27 55
2022-10-09_13 28 05

[FORGE] [possibly fabric too] Tinyarm render when using Offhand combat

Minecraft Version: 1.18.2
[issue may be present in other versions too]

Forge Version: 40.2.1

NostalgicTweaks-1.18.2-Forge-2.0.0-Beta-8.2

Issue:
When old reequip logic is enabled and Offhandcombat is installed, the players arms are shorted and not available to see unless they are mining.

Mod-link(s):
https://www.curseforge.com/minecraft/mc-mods/off-hand-combat

fabric
https://www.curseforge.com/minecraft/mc-mods/off-hand-combat-fabric

Screenshots

image

[FABRIC] The "Disable Item Tooltips" parameter does not work.

Version Information

Minecraft Version: 1.20.1
Fabric Loader Version: 0.15.2
Fabric API Version: 0.91.0
Nostalgic Tweaks Version: 2.0.0 Beta-8.4.1

Describe the Bug

If you enable the "Disable Item Tooltips" option, the tooltips will continue to be displayed above the items in the inventory.

Crash Report

N/a

Bug Context

N/a

Screenshots

javaw_p2HHHQsqEc
javaw_J9Hzkvhxdk

[FORGE] (Mod Incompatibility) phantom lighting with Starlight and Old Light Rendering enabled

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.18.2
Forge Version: 40.1.84
Nostalgic Tweaks Version: 1.0.7
Starlight Version: 1.0.2+forge.546ae87

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

When using the Old Light Rendering with Starlight Installed, placing and breaking light blocks will often times result in the the light lingering until the chunk the torch was placed in is updated.

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

n/a

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

n/a

Screenshots

If applicable, add screenshots to help explain your problem.
Screenshot 2022-11-13 181331
Screenshot 2022-11-13 181545

[FABRIC] chest model conflicting with EBE and config for it isn't working properly

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.19.3
Fabric Loader Version: 0.14.14
Fabric API Version: 0.75.1
Nostalgic Tweaks Version: v2.0.0 Beta-8.2

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

Chest models are defaulting to Old Chest=On regardless of what was changed in the config (with EBE)
The original voxel shape stays the same.

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

latest.log

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

Conflicting mod, https://modrinth.com/mod/ebe
Works fine without EBE

Screenshots

If applicable, add screenshots to help explain your problem.

Mar05-2023.02.51.AM.mp4

[FABRIC] Stuck on world loading screen

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.19.2
Fabric Loader Version: 0.14.9
Fabric API Version: 0.60.0
Nostalgic Tweaks Version: 1.2.2

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

When loading into a world game gets stuck after "Building terrain" endlessly and refuses to actually render the world.

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

No errors in the logs.

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

When loading into the world.

Screenshots

If applicable, add screenshots to help explain your problem.

[FORGE] Can't exit "Texture Packs" menu by clicking "Done"

Minecraft Version: 1.19.4
Forge Version: 45.0.49
Nostalgic Tweaks Version: 2.0.0-Beta-8.3

When entering the "Texture Packs" menu on the title screen while Eye Candy > Interface Candy > Title Screen > Buttons > Old Button Layout is set to Beta, clicking "Done" does nothing and I remain stuck within the resource packs menu.

[FORGE] Compatability Issue with Industrial Foregoing's tanks

Version Information

Minecraft Version: 1.19.2
Forge Version: 43.3.0
Nostalgic Tweaks Version: 2.0.0-Beta-8.4
Industrial Foregoing Version: 3.3.2.3

Describe the Bug

Attempting to use a bucket to add certain fluids into a tank from Industrial Foregoing results in a crash if Nostalgic Tweaks is also installed. This seems to be related to how Nostalgic Tweaks modifies some of the sound code.

Crash Report

crash-2023-10-29_12.54.28-client.txt

Video Demonstration

out.mp4

[FORGE] Void Gui crash

Version Information

Minecraft Version: 1.201
Forge Version: 47.2.0
Nostalgic Tweaks Version: 8.4.1

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

World start up crash

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

n/a

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

Everytime i try to load up a world it crashes due to the void gui

Screenshots

If applicable, add screenshots to help explain your problem.
Cap
Capt
4

[FABRIC] startup crash with Optifabric

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.19.2
Fabric Loader Version: 0.14.10
Fabric API Version: 0.64.0
Nostalgic Tweaks Version: 1.2.2

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

Startup crash with OptiFabric

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

https://gist.githubusercontent.com/MexaHuka/83421ed2ea32f0a8047e20becd24f2cd/raw/e124b0d56b4d507699220db8a48faa54443ad6d3/gistfile1.txt

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

Startup crash with OptiFabric

Screenshots

If applicable, add screenshots to help explain your problem.
Screenshot_13

[FORGE] Controllable mod hunger bar position conflict

Version Information

Minecraft Version: 1.19.4
Forge Version: 45.1.0
Nostalgic Tweaks Version: 2.0.0 Beta 8.4

Describe the Bug

Hunger bar keeps original (Lower) position after turning on console hotbar setting on controllable mod

Crash Report

N/a

Bug Context

Anytime if Controllable's console hotbar is enabled even if all tweaks are disabled

Screenshots

2023-08-07_20 25 28

[FABRIC] "Old Water Lighting" reintroduces smooth water lighting bug with Sodium.

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.20.1
Fabric Loader Version: 0.15.1
Fabric API Version: 0.91.0
Nostalgic Tweaks Version: 2.0.0-Beta-8.4.1

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

In Vanilla Minecraft, smooth lighting is bugged and does not work on water.
image

With Sodium installed, this bug is fixed.
image

However, if I install Nostalgic Tweaks along with Sodium, and enable "Old Water Lighting", the bugged water is back.
image

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

N/A

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

Something to note is that some people may prefer having the lighting bug there, since that's how it was in old Minecraft, and some people may prefer having the water lighting smoothed out while still having the old water lighting.

Screenshots

If applicable, add screenshots to help explain your problem.

See above.

[FORGE] [1.18 - 1.19] Bad description bug with Tiered mod.

Tested On

Minecraft Version: 1.18.2
Forge Version: 40.2.8
Nostalgic Tweaks Version: 2.0.0-8.3 (latest curseforge)

Describe the Bug

Pretty much, the tiered mod doesn't show the descriptions of the following attribute bonuses for gear. This only occurs if NT is installed.
image

Crash Report

n/a

[FABRIC] Old Chest Voxel doesn't work unless Old Chest is enabled

Version Information

Minecraft Version: 1.19.3
Fabric Loader Version: 0.14.17
Fabric API Version: 0.76.0
Nostalgic Tweaks Version: v2.0.0 Beta-8.2

Describe the Bug

The option for Old Chest Voxel won't activate unless Old Chest is also enabled. So you can't, for instance, have chests the way they were in Minecraft Beta 1.8 where the smaller model was used, but it still counted as a full block.

Crash Report

N/a

Bug Context

Enabled the setting for Old Chest Voxel, created a new world, placed down a chest, and stood on it to test the hitbox.

[FABRIC] Strange lighting issue when using old alpha/beta lighting

Version Information

Minecraft Version: 1.20.1
Fabric Loader Version: 0.14.22
Fabric API Version: 0.89.0
Nostalgic Tweaks Version: 8.4.1

Describe the Bug

When I try to enable and use the old alpha/beta lighting I have an issue at night where the fog turns dark as well as certain entities such as doors and items I'm holding in my hand. However, placed blocks and chests all maintain their standard brightness they had in the daytime and it causes a very bizarre and jarring visual. I have old light color enabled with old light rendering. If I disable old light color it fixes my handheld items but nothing else.

Screenshots

Screenshot_1203
Screenshot_1204
Screenshot_1205

[FORGE] Compatibility Issue with Aether 1.19.4

Can't find the template others used, but:

Version: 1.19.4
2.0.0 beta 8.3

Basically, the issue is that the "old lighting" option, which is on by default, breaks the eternal daytime of the aether. Not sure if compatibility is a concern, but I figure if it's because it's using block light, the assigned block light could still be inferred using alternate what would be the sky light?

It does turn day if you use /time set day, but then time just starts progressing until it's dark again.

[FORGE] Game crashing at startup

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.20
Forge Version: 46.0.14
Nostalgic Tweaks Version: 2.0.0 Beta 8.4

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

I have a startup crash . I get java.lang.RuntimeException: null after trying to launch the game

Crash Report

https://pastebin.com/TKPMTFbi

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

n/a

Screenshots

If applicable, add screenshots to help explain your problem.

image

[FABRIC] Animals always drop one non-stackable food item.

Description

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

[ I've noticed when playing with food stacking disabled that all animals always drop 1 of each non-stackable item instead of a random number. Pigs used to drop 0โ€“2 pork chops when killed before release 1.3.1, so animals should be dropping random amounts of food instead of one every time. ]

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.