adoptopenjdk / lambda-tutorial Goto Github PK

Exercise_1_Test has one test case which requires Shape#toString method, and the following test case expects the use of Shape#getColor to build the result string. The latter test case should just use Shape#toString, for consistency.

Whilst there's not too many classes to overhaul, this is a good opportunity to get this right early. + package-info files as well.

The solution for Exercise 1, Test 3 requires that multiple statements are executed in a single lambda. However, the syntax for doing has not been introduced.

The fix would be to put an example of that syntax somewhere in the JavaDocs.

Following OO principles of not having public access to private members

This can be done 'automatically' via the maven license plugin that will shortly be supplied to this project.

This is a great learning project.

However I’ve noticed a lot of the content is focused on either EA or earlier versions of IDEs (in a Wiki) or compatible JDK.

Given latest versions of JDK (as if request 14-15) and with new release schedule, suggest

(1) updating JDK references in readme and source where applicable
(2) for IDE setup wiki pages changes since JDK 8 is readily supported if not mandatory now with recent IDE versions.

The source files for the following classes seem to be missing: StarRating, UserRatedMusicLibrary, CloudScrobblingMusicLibrary, UserRatedLocalFilesystemMusicLibrary.

The following imports do not resolve:

import org.adoptopenjdk.lambda.tutorial.exercise5.musicplayer.StarRating;
import org.adoptopenjdk.lambda.tutorial.exercise5.musicplayer.UserRatedMusicLibrary;
import org.adoptopenjdk.lambda.tutorial.exercise5.thirdpartyplugin.CloudScrobblingMusicLibrary;
import org.adoptopenjdk.lambda.tutorial.exercise5.thirdpartyplugin.UserRatedLocalFilesystemMusicLibrary;