adoptopenjdk / install-jdk Goto Github PK

As AdoptOpenJDK has been transferred to Adoptium, I suggest following the upstream project and introduce a configuration parameter distribution for the new Eclipse Temurin runtime.

I recently started using the maven-enforcer-plugin to warn if AdoptOpenJDK as a Java vendor wasn't being used, which works locally, but after the first pipeline run, it detected a different vendor in use as you can see here:

1247  Warning:  Rule 1: org.apache.maven.plugins.enforcer.RequireJavaVendor warned with message:
1248  Eclipse Foundation is not an included Required Java Vendor

The expectation is that this would not throw a warning because I use AdoptOpenJDK/[email protected] before this step with the following configuration:

- name: Install AdoptOpenJDK
  uses: AdoptOpenJDK/[email protected]
  with:
    version: '16'
    architecture: x64
    impl: hotspot

Is something in the environment not being set by this action that causes Eclipse Foundation to be the detected vendor that my project is compiling against?

I will be testing soon to see if using actions/setup-java produces the same result as this action is now more configurable with import features like configuring the global settings.xml file for automated deployments to maven central, however, for regular build workflows, I still prefer to use AdoptOpenJDK/install-jdk.

URL sources which redirect are not handled by the action.
Example SDK source: https://corretto.aws/downloads/latest/amazon-corretto-8-x64-linux-jdk.tar.gz

As title...
When I use this action I get this warning from GitHub.

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: AdoptOpenJDK/[email protected]

Can you fix it please before they shut down node js 12 please?

Thanks.

Using the adopt install jdk action returns a warning

      - name: Set up AdoptOpenJDK 15
        uses: AdoptOpenJDK/install-jdk@v1
        with:
          version: '15'
          architecture: x64

this is the warning with some errors.

Run AdoptOpenJDK/install-jdk@v1
C:\windows\System32\WindowsPowerShell\v1.0\powershell.exe -NoLogo -Sta -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command "$ErrorActionPreference = 'Stop' ; try { Add-Type -AssemblyName System.IO.Compression.FileSystem } catch { } ; [System.IO.Compression.ZipFile]::ExtractToDirectory('D:\a\_temp\5dc80748-a307-4a7c-b574-02c961aae42d', 'D:\a\_temp\temp_746465718')"
Warning: The `add-path` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Warning: The `set-env` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

probably you know it but an issue is just a reminder :)
thank you for your great product.

Hi all,
this is a feature request, is it possible to implement the creation of the settings.xml for maven as in the
setup-java action described here:
https://docs.github.com/en/free-pro-team@latest/actions/guides/publishing-java-packages-with-maven

using the AdoptOpenJDK/install-jdk@v1 action

      - name: Set up AdoptOpenJDK 15
        uses: AdoptOpenJDK/install-jdk@v1
        with:
          version: '15'
          architecture: x64

Thanks for your support and for your great project.

As per the title, when I use this action I get this warning from GitHub:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: AdoptOpenJDK/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Can this be upgraded?

Thanks in advance.

Similarly to the Jenkins Grinder, there should be options for setting the flags TEST_IMAGES_REQUIRED and DEBUG_IMAGES_REQUIRED

Instead of requiring the archiveExtension parameter to be specified if the source is a URL, determine the archiveExtension automatically in code based on the source URL.

JDKs for Macos download from AdoptOpenJDK have different directory structure from jdk from Zulu. JDKs Macos from AdoptOpenJDK have extra directory layer /Contents/Home/. That means we can't run java program if we install macos jdk as JAVA_HOME.

We can easily fix this by appending /Contents/Home/ to current JAVA_HOME( this is what run-aqa action does to work around this mac issue, which shouldn't be done at that layer).

Or if we could know the story of this difference between AdoptOpenJDK and Zulu we can make a better decision?

The AdoptOpenJDK API provides a way to consume AdoptOpenJDK releases and nightly builds. Current only download releases(GA) JDKs is supported. Nice to also support download nightly (EA) JDKs.

https://github.com/AdoptOpenJDK/install-jdk/blob/master/src/installer.ts#L66

Which would be consistent with AdoptOpenJDK/openjdk-tests story. I.E. sdk source: nightly, releases, customized, upstream.

nightly --> AdoptOpenJDK V3 API EA
releases --> AdoptOpenJDK V3 API GA
customized --> A custom source location of a JDK. A local directory, a compressed file, or a url.
upstream --> AdoptOpenJDK/build-jdk action or could be included in customized as a local
compressed file